[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[PATCH] Add exposed root option

"Jesse W. Hathaway" <jesse at mbuki-mvuki.org> writes:

>> "Jesse W. Hathaway" <jesse at mbuki-mvuki.org> writes:
>> >> Otavio Salvador wrote:
>> >> > Jesse, can you update it using my tree as reference so I can merge
>> >> > your patch when I start to merge my pending fixes for a31?
>> >> 
>> >> jesse, do you have a git tree where i can merge from, or do you prefere
>> >> me to apply the patch manually?
>> >
>> > Here is a new cut of the exposed root patch rebased off the current
>> > head. Let me know if there are any changes you would like to see before
>> > it gets merged.
>> >
>> > commit deac4cd3cf66f67d43ea072c1b0c35101f4769bf
>> > Author: Jesse Hathaway <jesse at mbuki-mvuki.org>
>> > Date:   Tue Oct 23 16:56:43 2007 -0400
>> >
>> >     add exposedroot option which exposes the root fs as ro
>> >     
>> >     This option allows you to expose the root read only.  Using
>> >     this option a person could upgrade the root filesystem or
>> >     add packages without requiring the user to reboot. The root
>> >     filesystem could be kept on an nfs volume or some other
>> >     persistent medium. Multiple clients could then be booted off
>> >     the same root fs. I used LTSP as a template to determine which
>> >     directories to make rw.
>> I've looked this patch and I've found a minor problem with the
>> identation of lh_chroot_hacks file. It add lines with empty space on
>> it... please remove this empty space as done on all other new lines.
> I tried to add space only when I thought it made the code easier to
> read, or to highlight an important piece of code. Space is used like
> this throughout the existing code so I thought it was permissible. But
> if you & Daniel would prefer no white space then I will remove it.

If you use git show, with color enabled, you'll see that those lines
will be marked red. That's useless spaces after new line.

An examble, would be that instead of: "\n\n\t<code>" you did


        O T A V I O    S A L V A D O R
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
"Microsoft sells you Windows ... Linux gives
 you the whole house."

Reply to: