Check_package () buggy? s/if `Chroot ...`/[ -n "`Chroot ...`"]
On Tue, Jul 31, 2007 at 03:48:13PM -0400, Justin Pryzby wrote:
> I got this message after removing some .stage/ stampfiles:
> |/usr/share/live-helper/functions/packages.sh: line 21: Package:: command not found
>
> Is this patch sane?
>
> --- /tmp/packages.sh 2007-07-31 15:40:49.000000000 -0400
> +++ /usr/share/live-helper/functions/packages.sh 2007-07-31 15:40:54.000000000 -0400
> @@ -18,7 +18,7 @@
> enabled)
> for ITEM in ${PACKAGE}
> do
> - if ! `Chroot "dpkg-query -s ${ITEM}"`
> + if [ -n "`Chroot "dpkg-query -s ${ITEM}"`" ]
Crap; the test was reversed.
--- /tmp/packages.sh 2007-07-31 15:40:49.000000000 -0400
+++ /usr/share/live-helper/functions/packages.sh 2007-07-31 16:19:03.000000000 -0400
@@ -18,7 +18,7 @@
enabled)
for ITEM in ${PACKAGE}
do
- if ! `Chroot "dpkg-query -s ${ITEM}"`
+ if [ -z "`Chroot "dpkg-query -s ${ITEM}"`" ]
then
PACKAGES="${PACKAGES} ${ITEM}"
fi
(It should probably be `... 2>/dev/null`, too).
Reply to: