Some corrections/suggestions to live-helper
Antonio Amorim wrote:
> First of all, my thanks. Live-helper is really becoming an excellent tool!
welcome.
> 1 - On /etc/cron.daily/live-helper
> the ARCHITECTURE options -a amd64 or -a i386 are missing from
> the make-live statment.
> Something like:
> if [ "$ARCHITECTURE" == "amd64" ]
> then
> OPTIONS="${OPTIONS} -a amd64"
> fi
> if [ "$ARCHITECTURE" == "i386" ]
> then
> OPTIONS="${OPTIONS} -a i386"
> fi
not needed. the architecture is, if unset, guessed by the host system.
as long as you don't want to build for another architecture (like
building i386 on amd64), this is not needed.
> 2 - For amd64, in lh_binary_debian-installer, downloading the elilo
> package raises an exception that is caught by trap and messes
> everything. Please remove it.
done.
> 3 - If one has a package list that contains many packages aptitude can
> go into an infinite loop while guessing the dependences. I have seen
> this behavior systematically in etch.
> Everything is fine if aptitude installs one package at the time.
> My patch goes in lh_chroot_packageslists:
i'm not sure if we want this by default. aptitude does much better
conflicts handling when all packages are installed in one shot and the
loop/segfault of aptitude afaik only happens with really, really long lists.
> I hope this can help a bit your excellent work.
jup, thanks for reporting.
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: daniel.baumann at panthera-systems.net
Internet: http://people.panthera-systems.net/~daniel-baumann/
Reply to: