Bug#400247: casper: non-standard mount option syntax is confusing

[synrg at sanctuary.nslug.ns.ca (Ben Armstrong)]

Package: casper
Version: 1.77+debian-5
Severity: minor

In scripts/casper:

    mount -r -o move ${copyto} ${copyfrom}

Just because busybox considers -o option and --option to be the same (probably
done so that the option processing code can be streamlined, saving precious
bytes) doesn't mean you should exploit that "feature" when you write scripts
that use busybox mount.  Please use the standard "--move" switch instead of
"-o move" so that when people consult the mount manpage for standard mount,
they'll understand what the code is doing.  I spent a good 30 minutes with
another developer scratching my head over this code and couldn't figure it out
until I got the busybox source and found:

/* parse long options, like --bind and --move.  Note that -o option
 * and --option are synonymous.  Yes, this means --remount,rw works. */

Lovely.

Ben

-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-1-k7
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)