[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Git][lintian/lintian][master] In files/source-missing check, look for longest lines only in JavaScript and HTML files



Title: GitLab

Bastien Roucariès pushed to branch master at lintian / lintian

Commits:

  • 84030380
    by Andrius Merkys at 2025-08-20T22:47:39+00:00
    In files/source-missing check, look for longest lines only in _javascript_ and HTML files
    

1 changed file:

Changes:

  • lib/Lintian/Check/Files/SourceMissing.pm
    ... ... @@ -44,6 +44,8 @@ const my $DOLLAR => q{$};
    44 44
     const my $DOT => q{.};
    
    45 45
     const my $DOUBLE_DOT => q{..};
    
    46 46
     const my $ITEM_NOT_FOUND => -1;
    
    47
    +const my $JS_SUFFIX => qr/\.js$/;
    
    48
    +const my $HTML_SUFFIX => qr/\.(?:x?html?\d?|xht)$/;
    
    47 49
     
    
    48 50
     use Moo;
    
    49 51
     use namespace::clean;
    
    ... ... @@ -147,6 +149,10 @@ sub visit_patched_files {
    147 149
             return;
    
    148 150
         }
    
    149 151
     
    
    152
    +    return
    
    153
    +      unless $item->basename =~ /$JS_SUFFIX/i
    
    154
    +      || $item->basename =~ /$HTML_SUFFIX/i;
    
    155
    +
    
    150 156
         my @lines = split(/\n/, $item->bytes);
    
    151 157
     
    
    152 158
         my $longest;
    
    ... ... @@ -164,7 +170,7 @@ sub visit_patched_files {
    164 170
         return
    
    165 171
           if !defined $longest || $length <= $VERY_LONG_LINE_LENGTH;
    
    166 172
     
    
    167
    -    if ($item->basename =~ m{\.js$}i) {
    
    173
    +    if ($item->basename =~ /$JS_SUFFIX/i) {
    
    168 174
     
    
    169 175
             $self->pointed_hint('source-contains-prebuilt-_javascript_-object',
    
    170 176
                 $item->pointer);
    
    ... ... @@ -182,7 +188,7 @@ sub visit_patched_files {
    182 188
               );
    
    183 189
         }
    
    184 190
     
    
    185
    -    if ($item->basename =~ /\.(?:x?html?\d?|xht)$/i) {
    
    191
    +    if ($item->basename =~ /$HTML_SUFFIX/i) {
    
    186 192
     
    
    187 193
             # html file
    
    188 194
             $self->pointed_hint('source-is-missing', $item->pointer)
    


  • Reply to: