[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Git][lintian/lintian][master] Allow for "=" in --home option when checking maintainer-script-lacks-home-in-adduser

Title: GitLab

Maytham Alsudany pushed to branch master at lintian / lintian

Commits:

  • 69a6c7b0
    by Maytham Alsudany at 2025-03-20T00:22:34+00:00 
    Allow for "=" in --home option when checking maintainer-script-lacks-home-in-adduser

Previously, lintian wrongfully emitted the tag for the following:

adduser --system --home=/var/lib/myuser myuser

This fixes the issue by making a minor adjustment to the regex allowing
for "=" in the --home option, and adds a corresponding test.

Closes: #1055591

3 changed files:

Changes:

  • data/scripts/maintainer-script-bad-command
    ... ... @@ -32,7 +32,7 @@ maintainer-script-hides-init-failure ~~ 0 ~~ 0 ~~
    32 32 
     maintainer-script-changes-ld-so-conf                            ~~ 0 ~~ 0 ~~^libc               ~~          ~~(?:\A\s*(?:cp|mv)\s+.*\s+|>\s*)/etc/ld\.so\.conf\s*(?:\s|\Z)
    33 33 
     maintainer-script-changes-netbase                               ~~ 0 ~~ 0 ~~                    ~~          ~~(?:\A\s*(?:cp|mv)\s+.*\s+|>\s*)(/etc/(?:services|protocols|rpc))\s*(?:\s|\Z)
    34 34 
     maintainer-script-should-not-parse-etc-passwd-or-group          ~~ 0 ~~ 0 ~~                    ~~          ~~\b([ef]?grep\b.*/etc/(?:passwd|group))\b
    35 
    -maintainer-script-lacks-home-in-adduser                         ~~ 1 ~~ 0 ~~                    ~~          ~~(adduser\s(?:(?!.*(?<=\s)--home\s.*\s--system).*(?<=\s)--system(?=\s)(?!.*\s--home\s+(?:["]?/(?!home/)|["]?\$[\(\[\{]?))|--home\s+["]?/home/.*\s--system(?:\s|$)).*)
    35 
    +maintainer-script-lacks-home-in-adduser                         ~~ 1 ~~ 0 ~~                    ~~          ~~(adduser\s(?:(?!.*(?<=\s)--home[\=\s].*\s--system).*(?<=\s)--system(?=\s)(?!.*\s--home[\=\s]\s*(?:["]?/(?!home/)|["]?\$[\(\[\{]?))|--home[\=\s]\s*["]?/home/.*\s--system(?:\s|$)).*)
    36 36 
     maintainer-script-calls-chown-improperly                        ~~ 0 ~~ 0 ~~                    ~~          ~~(chown(?:\s+--?[A-Za-z-]+)*\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+
    37 37 
     maintainer-script-should-not-use-dpkg-maintscript-helper        ~~ 1 ~~ 1 ~~                    ~~          ~~dpkg-maintscript-helper
    38 38 
     maintainer-script-updates-fontconfig-cache-improperly           ~~ 0 ~~ 0 ~~^(fontconfig)$      ~~          ~~${LEADING_PATTERN}(?:/usr/bin/)?fc-cache(?:\s|\Z)

  • t/recipes/checks/scripts/scripts-maintainer-general/build-spec/debian/postinst
    ... ... @@ -147,9 +147,9 @@ rm /dev/.hiddenfile
    147 147 
     # adduser system
    148 148 
     adduser --system foo
    149 149 
     adduser --system foo2 --home /home/foo2
    150 
    -adduser --system bar --home /var/lib/bar
    150 
    +adduser --system bar --home=/var/lib/bar
    151 151 
     adduser --home /var/lib/fnord --system fnord
    152 
    -adduser --home /home/fnord2 --system fnord2
    152 
    +adduser --home=/home/fnord2 --system fnord2
    153 153
    154 154 
     # other test case for gconftool
    155 155 
     /usr/bin/gconftool-2 --makefile-install-rule foo.schema

  • t/recipes/checks/scripts/scripts-maintainer-general/eval/hints
    ... ... @@ -55,7 +55,7 @@ scripts-maintainer-general (binary): maintainer-script-lacks-home-in-adduser "ad
    55 55 
     scripts-maintainer-general (binary): maintainer-script-lacks-home-in-adduser "adduser --system foo2 --home /home/foo2" [postinst:149]
    56 56 
     scripts-maintainer-general (binary): maintainer-script-lacks-home-in-adduser "adduser --system foo" [postinst:148]
    57 57 
     scripts-maintainer-general (binary): maintainer-script-lacks-home-in-adduser "adduser --system --quiet --ingroup ntp --no-create-home ntp" [postinst:199]
    58 
    -scripts-maintainer-general (binary): maintainer-script-lacks-home-in-adduser "adduser --home /home/fnord2 --system fnord2" [postinst:152]
    58 
    +scripts-maintainer-general (binary): maintainer-script-lacks-home-in-adduser "adduser --home=/home/fnord2 --system fnord2" [postinst:152]
    59 59 
     scripts-maintainer-general (binary): maintainer-script-interpreter /bin/sh [prerm]
    60 60 
     scripts-maintainer-general (binary): maintainer-script-interpreter /bin/sh [preinst]
    61 61 
     scripts-maintainer-general (binary): maintainer-script-interpreter /bin/sh [postrm]

    • —
    View it on GitLab.
    You're receiving this email because of your account on salsa.debian.org. Manage all notifications · Help

    Reply to: