[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Git][lintian/lintian][master] Emit error when a trailing comma is present in the Maintainer field



Title: GitLab

Louis-Philippe Véronneau pushed to branch master at lintian / lintian

Commits:

  • 8ec38122
    by Maytham Alsudany at 2025-03-19T22:20:43+00:00
    Emit error when a trailing comma is present in the Maintainer field
    
    Closes: #1089649
    

5 changed files:

Changes:

  • lib/Lintian/Check/Fields/Maintainer.pm
    ... ... @@ -48,6 +48,9 @@ sub source {
    48 48
         $self->hint('no-human-maintainers')
    
    49 49
           if $is_list && !$self->processable->fields->declares('Uploaders');
    
    50 50
     
    
    51
    +    $self->hint('trailing-comma-in-maintainer-field', $maintainer)
    
    52
    +      if $maintainer =~ /,$/;
    
    53
    +
    
    51 54
         return;
    
    52 55
     }
    
    53 56
     
    

  • t/recipes/checks/fields/maintainer/fields-trailing-comma-in-maintainer-field/build-spec/fill-values
    1
    +Skeleton: upload-native
    
    2
    +Testname: fields-trailing-comma-in-maintainer-field
    
    3
    +Description: Checks for a trailing comma in the Maintainer field
    
    4
    +Author: Maytham Alsudany <maytha8thedev@gmail.com>,

  • t/recipes/checks/fields/maintainer/fields-trailing-comma-in-maintainer-field/eval/desc
    1
    +Testname: fields-trailing-comma-in-maintainer-field
    
    2
    +Check: fields/maintainer

  • t/recipes/checks/fields/maintainer/fields-trailing-comma-in-maintainer-field/eval/hints
    1
    +fields-trailing-comma-in-maintainer-field (source): trailing-comma-in-maintainer-field Maytham Alsudany <maytha8thedev@gmail.com>,

  • tags/t/trailing-comma-in-maintainer-field.tag
    1
    +Tag: trailing-comma-in-maintainer-field
    
    2
    +Severity: error
    
    3
    +Check: fields/maintainer
    
    4
    +Explanation: The Maintainer field contains a trailing comma, which is not
    
    5
    + permitted as there can only be one maintainer. This breaks the parsing of some
    
    6
    + tools such as the Debian Package Tracker.
    
    7
    +See-Also: debian-policy 5.6.2, Bug#1089649


  • Reply to: