[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1014083: Leaves many mldbm files in /tmp without cleanup



Investigating this bug.

The artifacts created all seem related to ELF items.

Lintian::Storage::MLDBM, which defines a `create` and a `DESTROY` function, is used by Lintian::Index::Elf.

The latter has `elf_storage` and `elf_storage_by_member` functions, that do call the `create` function, but never the `DESTROY` one.

Those two functions are then used in Lintian::Index::Item, that define the `elf` and the `elf_by_member` functions.

These two functions (yes, going down the rabbit hole), are then called directly all over the Lintian code to actually define checks.

My Perl-foo isn't strong enough yet to know where `Lintian::Storage::MLDBM->DESTROY('foobar')` should be called, but it currently isn't and it should be.

A good design would have the `DESTROY` function be called automatically at when that storage isn't needed anymore, instead of people having to manually call it once they are done in their check.

Cheers,

--
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   pollo@debian.org / veronneau.org
  ⠈⠳⣄


Reply to: