[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Git][lintian/lintian][master] Validate domain's TLD when checking for bogus-mail-host.



Title: GitLab

Bastien Roucariès pushed to branch master at lintian / lintian

Commits:

  • df6b9c25
    by Louis-Philippe Véronneau at 2024-09-10T16:51:31-04:00
    Validate domain's TLD when checking for bogus-mail-host.
    
    Closes: #1081316
    
    The `domain_disable_tld_validation => 1` variable in
    `Data::Validate::Domain` used not to do anything, since the version of
    this library in Debian (0.10) had not implemented it. This feature has
    only been available since 0.13. Upgrading the library to 0.15 added the
    feature and thus broke out testsuite.
    
    Since the goal of the check was to validate TLDs anyway, this patch restores
    the previous behavior.
    

1 changed file:

Changes:

  • lib/Lintian/Check/Fields/MailAddress.pm
    ... ... @@ -110,7 +110,7 @@ sub check_single_address {
    110 110
         }
    
    111 111
     
    
    112 112
         $self->hint('bogus-mail-host', $role, $parsed->address)
    
    113
    -      unless is_domain($parsed->host, {domain_disable_tld_validation => 1});
    
    113
    +      unless is_domain($parsed->host);
    
    114 114
     
    
    115 115
         $self->hint('mail-address-loops-or-bounces',$role, $parsed->address)
    
    116 116
           if any { $_ eq $parsed->address } @KNOWN_BOUNCE_ADDRESSES;
    


  • Reply to: