[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1025452: lintian: useless checks of debian/tests datafiles



title 1025452 spurious warnings emitted when parsing broken ELF files
thanks

Hi,

I think that it's totally normal that lintian flags those files: they are broken ELF files. The fact they are in debian/tests doesn't change anything IMO.

Looking at upx-ucl 4.2.4, it seems you managed to override the elf-warning tag, which is the right thing to do.

I'm changing the title of this bug though, as I agree the warning messages are spurious: Lintian already emits tags, no need to add other, unoverrideable warning messages.

The warnings are produced by these lines in lib/Lintian/Index/Elf.pm, introduced in commit 824cc18145967ab2e00cc33dcff6665d453f8f0e:

----------------------------------------------------------------------
if (@matches != $TOTAL_FIELDS) {

    warn "Parse error in readelf section headers [row $row]: $line";
    next;
}
----------------------------------------------------------------------

The next step would be:

1. remove those lines
2. rebuild lintian
3. test against upx-ucl to see if that removed the warnings
4. run the testsuite to see if something broke

Cheers,

--
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   pollo@debian.org / veronneau.org
  ⠈⠳⣄


Reply to: