Bug#1028125: wrong source-contains-prebuilt-windows-binary for GB18030-encoded text file
Package: lintian
Version: 2.115.3
Severity: important
Hi,
I get (well, got, it's overriden now)
libreoffice source: source-contains-prebuilt-windows-binary
on LibreOffices sw/qa/extras/txtimport/data/GB18030.txt
Looking at that file gives:
rene@frodo:~/LibreOffice/git/master$ cat
sw/qa/extras/txtimport/data/GB18030.txt
�������֮������ʮ�����ǧ������ΪһԪ��
rene@frodo:~/LibreOffice/git/master$ file
sw/qa/extras/txtimport/data/GB18030.txt
sw/qa/extras/txtimport/data/GB18030.txt: COM executable for DOS
which is suspicious indeed, BUT GB18030 is a chinese character encoding
so I just tried recode:
rene@frodo:~/LibreOffice/git/master$ recode GB18030..UTF-8
sw/qa/extras/txtimport/data/GB18030.txt
rene@frodo:~/LibreOffice/git/master$ cat
sw/qa/extras/txtimport/data/GB18030.txt
盖闻天地之数，有十二万九千六百岁为一元。
rene@frodo:~/LibreOffice/git/master$ file
sw/qa/extras/txtimport/data/GB18030.txt
sw/qa/extras/txtimport/data/GB18030.txt: UTF-8 Unicode text
so it's text, as the directory says :-) (And yes, it needs to be GB18030
because that is exactly the purpose of the unit test using it - test
GB18030 text files import).
This is overriden now. :)
(BTW: Windows binary is also wrong in an other way. file says
"COM executable for DOS". DOS != Windows. Windows binaries would be
reported by file as Windows:
rene@frodo:~/LibreOffice/git/master$ file
testtools/source/cliversioning/version_libs/*
testtools/source/cliversioning/version_libs/readme.txt: ASCII text
testtools/source/cliversioning/version_libs/version_3_0_0.dll: PE32
executable (DLL) (console) Intel 80386 Mono/.Net assembly, for MS Windows
testtools/source/cliversioning/version_libs/version_3_0_1.dll: PE32
executable (DLL) (console) Intel 80386 Mono/.Net assembly, for MS Windows
testtools/source/cliversioning/version_libs/version_3_1_1.dll: PE32
executable (DLL) (console) Intel 80386 Mono/.Net assembly, for MS Windows
testtools/source/cliversioning/version_libs/version_3_1.dll: PE32
executable (DLL) (console) Intel 80386 Mono/.Net assembly, for MS Windows
testtools/source/cliversioning/version_libs/version_3_2_1.dll: PE32
executable (DLL) (console) Intel 80386 Mono/.Net assembly, for MS Windows
testtools/source/cliversioning/version_libs/version_3_2.dll: PE32
executable (DLL) (console) Intel 80386 Mono/.Net assembly, for MS Windows
testtools/source/cliversioning/version_libs/version_3_3.dll: PE32
executable (DLL) (console) Intel 80386 Mono/.Net assembly, for MS Windows
rene@frodo:~/Software$ file *.exe
<removed, OSS windows software>: PE32 executable (GUI) Intel 80386, for
MS Windows, Nullsoft
rene@frodo:~/Software$ file FRITZOS/FRITZ.Box_7590_AX-07.31-recover.exe
FRITZOS/FRITZ.Box_7590_AX-07.31-recover.exe: PE32 executable (GUI) Intel
80386, for MS Windows
as PE32)
Filing as important since wrong source-contains-prebuilt-windows-binary
_might_ (just an assumption) be a reason ftp-masters might reject -
*especially if the windows binary is "hidden" in a .txt file*...
Regards,
Rene
Reply to: