[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1029555: lintian: license-problem-font-adobe-copyrighted-fragment-no-credit false positive



Package: lintian
Followup-For: Bug #1029555
X-Debbugs-Cc: roland@debian.org

Dear Maintainer,

Please find attached a potential fix for this lintian check bug.

Thanks,
James
>From 9fe45fdcbbc2fef8771cb049822307c5bbbafd15 Mon Sep 17 00:00:00 2001
From: James Addison <jay@jp-hosting.net>
Date: Wed, 7 Jun 2023 15:11:20 +0100
Subject: [PATCH] license-problem-font-adobe-copyrighted-fragment-no-credit:
 previously-checked code is now open source, so check for other,
 non-open-source code from the same publication

---
 lib/Lintian/Check/Fonts/Postscript/Type1.pm | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/lib/Lintian/Check/Fonts/Postscript/Type1.pm b/lib/Lintian/Check/Fonts/Postscript/Type1.pm
index 87cbef7c6..de5de8992 100644
--- a/lib/Lintian/Check/Fonts/Postscript/Type1.pm
+++ b/lib/Lintian/Check/Fonts/Postscript/Type1.pm
@@ -90,7 +90,25 @@ sub visit_installed_files {
         # copyright adobe a few line before the only
         # place where the startlock is documented is
         # in the black book copyrighted fragment
-        if ($line =~ m/startlock\s*get\s*exec/) {
+        #
+        # 2023-06-05: this check has been adjusted because
+        # Adobe's type hint code[1] (including Flex[2]) became
+        # open source[3] with an Apache-2.0 license[4] as
+        # committed on 2014-09-19, making that check a false
+        # positive[7].
+        #
+        # We continue to check for copyrighted code that is not
+        # available under an open source license from the origin
+        # publication,  "Adobe Type 1 Font Format"[5][6].
+        #
+        # [1] - https://github.com/adobe-type-tools/afdko/blob/2bf85cf44a64148353b24db17e0cc41ede5493b1/FDK/Tools/Programs/public/lib/source/t1write/t1write_hintothers.h
+        # [2] - https://github.com/adobe-type-tools/afdko/blob/2bf85cf44a64148353b24db17e0cc41ede5493b1/FDK/Tools/Programs/public/lib/source/t1write/t1write_flexothers.h
+        # [3] - https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1375813.html
+        # [4] - https://github.com/adobe-type-tools/afdko/blob/2bf85cf44a64148353b24db17e0cc41ede5493b1/LICENSE.txt
+        # [5] - https://adobe-type-tools.github.io/font-tech-notes/pdfs/T1_SPEC.pdf
+        # [6] - https://lccn.loc.gov/90042516
+        # [7] - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029555
+        if ($line =~ m/UniqueID\s*6859/) {
 
             $self->pointed_hint(
                 'license-problem-font-adobe-copyrighted-fragment-no-credit',
-- 
2.39.2


Reply to: