[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Are we back on adding debian/changelog entries with commits and running test suite at build time without discussion?



Hi,

I was very surprised to see debian/changelog entries added with
commits despite the

  * WIP (generated at release time: please do not add entries below).

clearly being at top of debian/changelog.

This breaks our current "gbp dch" workflow severly as it cannot
determine anymore which commits are needed to be added to
debian/changelog and which not.

Bastien: I'm really hapy that you are back on Lintian development and
especially thankful for your work on performance and the sliding
window implementation stuff, but I would have been more happy if you
first discussed or at least announced such a severe change in our
workflow. (I'm fine with both workflows, but we should strictly abide
to one of them, otherwise our changelog becomes highly unreliable.)

So let's please first discuss which workflow we'll use in the future
(with reasoning) before changing it again. So what's your reason for
editing the debian/changelog directly?

BTW: Your commit 198c3645c88496bcb08614e64e2892d01c42f13a already
shows what happens if we don't abide to one of the workflows.

Additionally these older commits are currently missing in the current
debian/changelog entry due to this unannounced workflow change:

* 9279fb89fd7fbad7963c8d3ba8b8f8fea58e3c1d
* acb2073d805aead92080ddcadfad74e83db8401a

I've added the according debian/changelog entries now. Please stop
adding new debian/changelog entries until shortly before releasing or
uploading or until we _decide_ together to change our workflow back to
editing debian/changelog with each commit.

I've also added a more prominent note than the existing one as that
one didn't seem to be read. We can remove it (and update the WIP note)
if we decide to switch back to editing debian/changelog with each
commit again.


The same counts for running the test suite at build time. The test
suite IMHO currently takes way too long for running at build time.

IMHO we first need revert splitting up running separate tests for each
tag back to running combined tests again to get down the test suite
run-time before we can really enable running tests at build time
again.

In addition to that we need to document how to build lintian without
running the test suite. Waiting 40 minutes to just test some changes
is inacceptable.

I've though haven't reverted that change. I will like add proper
documentation for how to build lintian without waiting 40 minutes for
a build.

Besides: salsa.debian.org is spelled "Salsa", not "salci". I've fixed
that, too, in debian/changelog.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Attachment: signature.asc
Description: PGP signature


Reply to: