[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Literal Unicode COMBINING TILDE OVERLAY in checks/group-check.pm (now lib/Lintian/Check/GroupChecks.pm)



Hi Niels,

while hunting down the fallout of
https://github.com/Perl-Critic/Perl-Critic/issues/925 in Lintian's
test suite, I stumbled upon this confusing line of code:

98:            join(' |̈́ ', $one->name, @provides_one));
[…]
108:                join(' | ', $two->name, @provides_two));

Note that the joining string of the first join() contains the Unicode
character U+0334 "COMBINING TILDE OVERLAY" after the pipe.

Via "git blame" I traced the introduction of that character (and
actually both these lines) to this commit from 2012 (!):

commit 1d64fd8a88d18511d45af4e8fd64f4d4f38b43d3
Author: Niels Thykier <niels@thykier.net>
Date:   Sat May 12 23:03:44 2012 +0200

    group-check: Include Provides in the Conflicts check

    Signed-off-by: Niels Thykier <niels@thykier.net>

I will very likely remove that unexpected Unicode character because
— especially with the second line not having it — it just doesn't seem
to make any sense.

Nevertheless I would like to know if this was an accident which has
been undetected for 10 years (and one month :-) or if this COMBINING
TILDE OVERLAY character was added was on purpose. (In case of the
latter, I'd be very curious about that purpose. :-)

		Kind regards, Axel
-- 
PGP: 2FF9CD59612616B5      /~\  Plain Text Ribbon Campaign, http://arc.pasp.de/
Mail: abe@deuxchevaux.org  \ /  Say No to HTML in E-Mail and Usenet
Mail+Jabber: abe@noone.org  X
https://axel.beckert.ch/   / \  I love long mails: https://email.is-not-s.ms/

Attachment: signature.asc
Description: PGP signature


Reply to: