Bug#864555: lintian: please use a more reliable heuristic than line length to detect source-is-missing
On Sat, Jun 10, 2017 at 12:11:51PM -0300, David Bremner wrote:
> Package: lintian
> Version: 2.5.50.4
> Severity: normal
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On polymake 3.1 source lintian reports:
>
> E: polymake source: source-is-missing external/js/renderers/SVGRenderer.js line length is 258 characters (>256)
>
> An examination reveals this to be a false positive. The file is not minified, but happens to contain long lines like
>
> _svgNode.setAttribute( 'style', 'fill: none; stroke: ' + material.color.getStyle() + '; stroke-width: ' + material.linewidth + '; stroke-opacity: ' + material.opacity + '; stroke-linecap: ' + material.linecap + '; stroke-linejoin: ' + material.linejoin );
>
> One can argue about whether that's nice programming style, but that's not really lintian's job.
> Presumably that's the way the upstream author likes to edit code.
I agree source-is-missing has far too much false positive to be useful.
To detect minified js, maybe one should also check that the lines only
have very few whitespaces, or even only whitespace between quotes.
Cheers,
--
Bill. <ballombe@debian.org>
Imagine a large red swirl here.
Reply to: