Bug#1012732: lintian: output-of-updaterc.d-not-redirected-to-dev-null only emitted for first update-rc.d call
Package: lintian
Version: 2.114.211
Severity: minor
While debugging test failures in t/recipes/checks/init-d/init.d-general,
I noticed the following unexpected change in emitted tags at commit
9e7db94ee5eadab0e6e7b4509abdea7c2087af31 (i.e. the 211th commit after
2.114.0):
I moved the #DEBHELPER# token in
t/recipes/checks/init-d/init.d-general/build-spec/debian/init.d-general-bugs.postinst
behind the additional update-rc.d call to hopefully get less often
changing line numbers after new debhelper releases (which was actually
the cause for the test failure):
diff --git a/t/recipes/checks/init-d/init.d-general/build-spec/debian/init.d-general-bugs.postinst b/t/recipes/checks/init-d/init.d-general/build-spec/debian/init.d-general-bugs.postinst
index e3bb515a1..d14ad23f9 100644
--- a/t/recipes/checks/init-d/init.d-general/build-spec/debian/init.d-general-bugs.postinst
+++ b/t/recipes/checks/init-d/init.d-general/build-spec/debian/init.d-general-bugs.postinst
@@ -2,9 +2,9 @@
set -e
-#DEBHELPER#
-
if [ "$1" = "configure" ] ; then
# duplicate call as debhelper will add one for us
update-rc.d init.d-general-bugs word
fi
+
+#DEBHELPER#
And suddenly, lintian correctly emitted
init.d-general-bugs (binary): output-of-updaterc.d-not-redirected-to-dev-null init.d-general-bugs [postinst:7]
which it didn't do beforehand but should have.
How to reproduce:
Checkout commit 9e7db94ee5eadab0e6e7b4509abdea7c2087af31, apply the
patch above and run
private/runtests -o check:init-d
Lintian will show you the diff as follows:
Failed test: t/recipes/checks/init-d/init.d-general
-init.d-general-bugs (binary): duplicate-updaterc.d-calls-in-postinst init.d-general-bugs [postinst:17]
+init.d-general-bugs (binary): output-of-updaterc.d-not-redirected-to-dev-null init.d-general-bugs [postinst:7]
+init.d-general-bugs (binary): duplicate-updaterc.d-calls-in-postinst init.d-general-bugs [postinst:13]
>>> Fix test (y), accept all (a), do not fix (n), quit (q/default)?
Note that not just the line number changed as expected, but an
additional tag showed up.
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.16.0-6-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled
Versions of packages lintian depends on:
ii binutils 2.38-4
ii bzip2 1.0.8-5
ii clzip [lzip-decompressor] 1.13-3
ii diffstat 1.64-1
ii dpkg 1.21.8
ii dpkg-dev 1.21.8
ii file 1:5.41-4
ii gettext 0.21-6
ii gpg 2.2.35-2
ii intltool-debian 0.35.0+20060710.5
ii iso-codes 4.10.0-1
ii libapt-pkg-perl 0.1.40+b1
ii libarchive-zip-perl 1.68-1
ii libberkeleydb-perl 0.64-1+b2
ii libcapture-tiny-perl 0.48-1
ii libclass-xsaccessor-perl 1.19-3+b8
ii libclone-perl 0.45-1+b2
ii libconfig-tiny-perl 2.28-1
ii libconst-fast-perl 0.014-1.1
ii libcpanel-json-xs-perl 4.29-1
ii libdata-dpath-perl 0.58-1
ii libdata-validate-domain-perl 0.10-1.1
ii libdata-validate-uri-perl 0.07-2
ii libdevel-size-perl 0.83-1+b3
ii libdigest-sha-perl 6.02-1+b4
ii libdpkg-perl 1.21.8
ii libemail-address-xs-perl 1.04-1+b4
ii libencode-perl 3.17-1
ii libfile-basedir-perl 0.09-1
ii libfile-find-rule-perl 0.34-1
ii libfont-ttf-perl 1.06-1.1
ii libhtml-html5-entities-perl 0.004-1.1
ii libhtml-tokeparser-simple-perl 3.16-4
ii libio-interactive-perl 1.023-1
ii libio-prompt-tiny-perl 0.003-1
ii libipc-run3-perl 0.048-2
ii libjson-maybexs-perl 1.004003-1
ii liblist-compare-perl 0.55-1
ii liblist-someutils-perl 0.58-1
ii liblist-utilsby-perl 0.12-1
ii libmldbm-perl 2.05-2.1
ii libmoo-perl 2.005004-3
ii libmoox-aliases-perl 0.001006-2
ii libnamespace-clean-perl 0.27-1
ii libpath-tiny-perl 0.122-1
ii libperlio-gzip-perl 0.19-1+b8
ii libperlio-utf8-strict-perl 0.009-1+b1
ii libproc-processtable-perl 0.634-1+b1
ii libsereal-decoder-perl 4.023+ds-1
ii libsereal-encoder-perl 4.023+ds-1
ii libsort-versions-perl 1.62-1
ii libsyntax-keyword-try-perl 0.27-1
ii libterm-readkey-perl 2.38-1+b3
ii libtext-glob-perl 0.11-2
ii libtext-levenshteinxs-perl 0.03-4+b9
ii libtext-markdown-discount-perl 0.13-1+b1
ii libtext-xslate-perl 3.5.9-1+b1
ii libtime-duration-perl 1.21-1
ii libtime-moment-perl 0.44-1+b4
ii libtimedate-perl 2.3300-2
ii libunicode-utf8-perl 0.62-1+b3
ii liburi-perl 5.10-1
ii libwww-mechanize-perl 2.08-1
ii libwww-perl 6.66-1
ii libxml-libxml-perl 2.0207+dfsg+really+2.0134-1
ii libyaml-libyaml-perl 0.83+ds-1+b1
ii lunzip [lzip-decompressor] 1.13-3
ii lzip [lzip-decompressor] 1.23-3
ii lzop 1.04-2
ii man-db 2.10.2-1
ii patchutils 0.4.2-1
ii perl [libencode-perl] 5.34.0-4
ii plzip [lzip-decompressor] 1.10-3
ii t1utils 1.41-4
ii unzip 6.0-26
ii xlunzip [lzip-decompressor] 0.7-5
ii xz-utils 5.2.5-2.1
lintian recommends no packages.
Versions of packages lintian suggests:
ii binutils-multiarch 2.38-4
ii libtext-template-perl 1.61-1
-- no debconf information
Reply to: