Felix Lechner pushed to branch master at lintian / lintian
Commits:
- 
c1c05b07
by Felix Lechner at 2022-01-20T09:31:45-08:00
4 changed files:
- lib/Lintian/Check/Testsuite.pm
- t/recipes/checks/testsuite/does-not-query-declared-python-versions/eval/hints
- + tags/d/drop-python-version-declaration.tag
- − tags/q/query-declared-python-versions-in-test.tag
Changes:
| ... | ... | @@ -317,7 +317,7 @@ sub check_test_file { | 
| 317 | 317 |                && !$debian_control->source_fields->declares(
 | 
| 318 | 318 |                  'X-Python3-Version');
 | 
| 319 | 319 |  | 
| 320 | -            $self->pointed_hint('query-declared-python-versions-in-test',
 | |
| 320 | +            $self->pointed_hint('drop-python-version-declaration',
 | |
| 321 | 321 |                  $pointer,
 | 
| 322 | 322 |                  $debian_control->source_fields->value('X-Python3-Version'))
 | 
| 323 | 323 |                if $options =~ m{ \s (?: -\w*s | --supported ) }x
 | 
| 1 | -does-not-query-declared-python-versions (source): query-declared-python-versions-in-test >= 3.4 [debian/tests/script:13]
 | |
| 2 | -does-not-query-declared-python-versions (source): query-declared-python-versions-in-test >= 3.4 [debian/tests/script:12]
 | |
| 3 | -does-not-query-declared-python-versions (source): query-declared-python-versions-in-test >= 3.4 [debian/tests/script:11]
 | |
| 4 | -does-not-query-declared-python-versions (source): query-declared-python-versions-in-test >= 3.4 [debian/tests/script:10] | |
| 1 | +does-not-query-declared-python-versions (source): drop-python-version-declaration >= 3.4 [debian/tests/script:13]
 | |
| 2 | +does-not-query-declared-python-versions (source): drop-python-version-declaration >= 3.4 [debian/tests/script:12]
 | |
| 3 | +does-not-query-declared-python-versions (source): drop-python-version-declaration >= 3.4 [debian/tests/script:11]
 | |
| 4 | +does-not-query-declared-python-versions (source): drop-python-version-declaration >= 3.4 [debian/tests/script:10] | 
| 1 | +Tag: drop-python-version-declaration
 | |
| 2 | +Severity: warning
 | |
| 3 | +Check: testsuite
 | |
| 4 | +Renamed-From:
 | |
| 5 | + query-requested-python-versions-in-test
 | |
| 6 | + query-declared-python-versions-in-test
 | |
| 7 | +Explanation:
 | |
| 8 | + Your sources request a specific set of Python versions via the control
 | |
| 9 | + field <code>X-Python3-Version</code> but the named test is ready to work
 | |
| 10 | + with all installed versions.
 | |
| 11 | + .
 | |
| 12 | + You may wish to drop the <code>X-Python3-Version</code> control field
 | |
| 13 | + unless other tests work only with specific Python versions.
 | |
| 14 | + .
 | |
| 15 | + Sources shipping the <code>X-Python3-Version</code> field may not be able
 | |
| 16 | + to remain in Debian <code>testing</code> when Python version 3.9 is
 | |
| 17 | + dropped from there.
 | |
| 18 | + .
 | |
| 19 | + Lintian infers that the specified test is ready because it queries all
 | |
| 20 | + <em>supported</em> Python version with the command
 | |
| 21 | + <code>py3versions --supported</code>.
 | |
| 22 | +See-Also:
 | |
| 23 | + py3versions(1),
 | |
| 24 | + Bug#1001677 | 
| 1 | -Tag: query-declared-python-versions-in-test
 | |
| 2 | -Severity: warning
 | |
| 3 | -Check: testsuite
 | |
| 4 | -Renamed-From:
 | |
| 5 | - query-requested-python-versions-in-test
 | |
| 6 | -Explanation: The specified test queries all <em>supported</em> Python versions
 | |
| 7 | - with the command <code>py3versions --supported</code> but your sources request
 | |
| 8 | - a specific set of versions via the field <code>X-Python3-Version</code>.
 | |
| 9 | - .
 | |
| 10 | - Please query only the requested versions with the command
 | |
| 11 | - <code>py3versions --requested</code>.
 | |
| 12 | -See-Also:
 | |
| 13 | - py3versions(1),
 | |
| 14 | - Bug#1001677 |