[Git][lintian/lintian][master] Recognize pybuild-plugin-pyproject as a valid prerequisite for the python3...

["Felix Lechner (@lechner)" <gitlab@salsa.debian.org>]

Title: GitLab

Felix Lechner pushed to branch master at lintian / lintian

Commits:

• ac114aa6
  by Felix Lechner at 2022-01-13T05:34:48-08:00

  Recognize pybuild-plugin-pyproject as a valid prerequisite for the python3 Debhelper plugin. (Closes: #1003668)
  
  The prerequisite handling in Lintian for Python is more complicated than any
  other Debhelper build system or sequence. [1] It is presently unclear that it
  must be so.
  
  The current code adds another level of exemption to code that already provides
  for manual adjustment [2] of an automated procedure. [3] A review of the code by
  the Python team would be appreciated.
  
  As can be seen below, The offending hint in poetry is now gone.
  
  Thanks to Andrius Merkys for bringing the matter to our attention!
  
  [1] https://salsa.debian.org/lintian/lintian/-/blob/master/lib/Lintian/Check/Debhelper.pm#L806-817
  [2] https://salsa.debian.org/lintian/lintian/-/blob/master/lib/Lintian/Check/Debhelper.pm#L120-121
  [3] https://salsa.debian.org/lintian/lintian/-/blob/master/lib/Lintian/Check/Debhelper.pm#L338-341
  
  * * *
  
  ➤ bin/lintian -X cruft /mirror/debian/pool/main/p/poetry/poetry_1.1.12+dfsg-1.dsc
  P: poetry source: update-debian-copyright 2020 vs 2021 [debian/copyright:11]
  X: poetry source: debian-watch-does-not-check-gpg-signature [debian/watch]
  X: poetry source: prefer-uscan-symlink filenamemangle s/.+\/v?(\d\S+)\.tar\.gz/$1\.tar\.gz/ [debian/watch:7]
  X: poetry source: upstream-metadata-file-is-missing
  

2 changed files:

• lib/Lintian/Check/Debhelper.pm
• t/recipes/checks/debhelper/debhelper-dh-with-python3/eval/hints

Changes:

lib/Lintian/Check/Debhelper.pm

---

...	...	@@ -805,7 +805,7 @@ sub source {
805	805
806	806	# As a special case, the python3 addon needs a dependency on
807	807	# dh-python unless the -dev packages are used.
808		- my $python_source = 'dh-python:any';
	808	+ my $python_source = 'dh-python:any | pybuild-plugin-pyproject:any';
809	809
810	810	$self->pointed_hint('missing-build-dependency-for-dh-addon',
811	811	$drules->pointer,$addon, "(does not satisfy $python_source)")

t/recipes/checks/debhelper/debhelper-dh-with-python3/eval/hints

---

1		-debhelper-dh-with-python3 (source): missing-build-dependency-for-dh-addon python3 (does not satisfy dh-python:any) [debian/rules]
	1	+debhelper-dh-with-python3 (source): missing-build-dependency-for-dh-addon python3 (does not satisfy dh-python:any | pybuild-plugin-pyproject:any) [debian/rules]
2	2	debhelper-dh-with-python3 (source): debian-build-system dh [debian/rules]
3	3	debhelper-dh-with-python3 (source): debhelper-compat-virtual-relation 13 [debian/control]
4	4	debhelper-dh-with-python3 (source): debhelper-compat-level 13

—
View it on GitLab.
You're receiving this email because of your account on salsa.debian.org. If you'd like to receive fewer emails, you can adjust your notification settings.