[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#824552: marked as done (lintian: Issues missing-python-build-dependency despite Build-Depends: python:native)

Your message dated Sun, 9 Jan 2022 19:53:06 -0800
with message-id <CAFHYt57cH1VCxXDieumbFCti6XPKWqYrPpmoWz=zTksMvOxDmQ@mail.gmail.com>
and subject line Re: lintian: Issues missing-python-build-dependency despite Build-Depends: python:native
has caused the Debian Bug report #824552,
regarding lintian: Issues missing-python-build-dependency despite Build-Depends: python:native
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
824552: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824552
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libjsoncpp
Version: 1.7.2-1
Severity: wishlist
Tags: patch

Hi,

I noticed that libjoncpp fails to cross build. Since it uses debhelper's
dh_auto_configure for cmake (which supports cross building), it almost
works. Still two aspects are broken:

 * libjsoncpp Build-Depends: python. Since python is Multi-Arch:
   allowed, this refers to the host architecture python which can
   neither be run nor installed. What is needed though is the build
   architecture python, so annotate it with :native.
 * Tests cannot be run during cross compilation, so cross compiles
   typically set DEB_BUILD_OPTIONS=nocheck. Unfortunately, libjsoncpp
   has no support for this setting yet and runs the tests anyway.

I am attaching a patch that addresses both issues. Please consider
applying it.

Helmut

--- libjsoncpp-1.7.2/debian/changelog
+++ libjsoncpp-1.7.2/debian/changelog
@@ -1,3 +1,12 @@
+libjsoncpp (1.7.2-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    * Annotate Build-Depends: python with :native.
+    * Support DEB_BUILD_OPTIONS=nocheck.
+
+ -- Helmut Grohne <h.grohne@intenta.de>  Wed, 11 May 2016 10:09:20 +0200
+
 libjsoncpp (1.7.2-1) unstable; urgency=medium
 
   * Team upload.
--- libjsoncpp-1.7.2/debian/control
+++ libjsoncpp-1.7.2/debian/control
@@ -3,7 +3,7 @@
 Maintainer: Peter Spiess-Knafl <dev@spiessknafl.at>
 Uploaders: Cleto Martín <cleto@debian.org>
 Testsuite: autopkgtest
-Build-Depends: cmake, debhelper (>= 9), doxygen, python
+Build-Depends: cmake, debhelper (>= 9), doxygen, python:native
 Standards-Version: 3.9.7
 Section: libs
 Homepage: https://github.com/open-source-parsers/jsoncpp
--- libjsoncpp-1.7.2/debian/rules
+++ libjsoncpp-1.7.2/debian/rules
@@ -4,13 +4,18 @@
 %:
 	dh $@ --parallel --buildsystem=cmake
 
+ifneq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
+CONFIGURE_FLAGS += -DJSONCPP_WITH_TESTS=Off
+endif
+
 override_dh_auto_configure:
 	dh_auto_configure -- \
 			-DBUILD_SHARED_LIBS=ON \
 			-DBUILD_STATIC_LIBS=ON \
 			-DJSONCPP_WITH_CMAKE_PACKAGE=ON \
 			-DLIB_SUFFIX="/$(DEB_TARGET_MULTIARCH)" \
-			-DINCLUDE_INSTALL_DIR=/usr/include/jsoncpp
+			-DINCLUDE_INSTALL_DIR=/usr/include/jsoncpp \
+			$(CONFIGURE_FLAGS)
 
 override_dh_auto_build-indep:
 	python doxybuild.py --doxygen=/usr/bin/doxygen

--- End Message ---
--- Begin Message --- 
Hi,

This issue was recently fixed. Lintian now recognizes multiarch
acceptors like :native.

The jsoncpp package no longer uses python:native (apparently having
switched to python3:any at some point) [1] but you can take a look at
cmake—now apparently in the hands of the same Debian distributor—and
the remaining caveats in Bug#1000234. [2]

Closing this bug.

Kind regards
Felix Lechner

[1] https://sources.debian.org/src/libjsoncpp/1.9.5-2/debian/control/#L4
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000234#38

--- End Message ---
Reply to: