[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1002824: marked as done (lintian: Should warn about packages installing _any_ file directly under /usr/lib/python3/dist-packages/docs/ and similar locations)

Your message dated Wed, 29 Dec 2021 14:40:59 +0000
with message-id <E1n2a8R-0001eQ-Tq@fasolo.debian.org>
and subject line Bug#1002824: fixed in python-gitlab 1:2.10.1-2
has caused the Debian Bug report #1002824,
regarding lintian: Should warn about packages installing _any_ file  directly under /usr/lib/python3/dist-packages/docs/ and similar locations
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1002824: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1002824
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: python3-gitlab
Version: 1:2.10.0-1
Severity: serious
Control: clone -1 -2
Control: clone -1 -3
Control: reassign -2 python3-diskcache 5.2.1-2
Control: retitle -2 python3-diskcache: Should likely not ship /usr/lib/python3/dist-packages/docs/conf.py ("trying to overwrite '/usr/lib/python3/dist-packages/docs/conf.py', which is also in package python3-gitlab 1:2.10.0-1")
Control: severity -3 wishlist
Control: reassign -3 lintian
Control: retitle -3 lintian: Should warn about packages installing _any_ file  directly under /usr/lib/python3/dist-packages/docs/ and similar locations

python3-gitlab 1:2.10.0-1 as well as python3-diskcache 5.2.1-2 both ship
/usr/lib/python3/dist-packages/docs/conf.py which is a serious bug
alone:

Unpacking python3-gitlab (1:2.10.1-1) over (1:2.10.0-1) ...
dpkg: error processing archive /var/cache/apt/archives/python3-gitlab_1%3a2.10.1-1_all.deb (--unpack):
 trying to overwrite '/usr/lib/python3/dist-packages/docs/conf.py', which is also in package python3-diskcache 5.2.1-2
Errors were encountered while processing:
 /var/cache/apt/archives/python3-gitlab_1%3a2.10.1-1_all.deb


For python3-diskcache, it should very likely not install these files at
all:

/usr/lib/python3/dist-packages/docs/Makefile
/usr/lib/python3/dist-packages/docs/api.rst
/usr/lib/python3/dist-packages/docs/cache-benchmarks.rst
/usr/lib/python3/dist-packages/docs/case-study-landing-page-caching.rst
/usr/lib/python3/dist-packages/docs/case-study-web-crawler.rst
/usr/lib/python3/dist-packages/docs/conf.py
/usr/lib/python3/dist-packages/docs/development.rst
/usr/lib/python3/dist-packages/docs/djangocache-benchmarks.rst
/usr/lib/python3/dist-packages/docs/index.rst
/usr/lib/python3/dist-packages/docs/make.bat
/usr/lib/python3/dist-packages/docs/tutorial.rst

And these files are probably edgy:

/usr/lib/python3/dist-packages/docs/sf-python-2017-meetup-talk.rst (clearly belongs to /usr/share/doc/python3-diskcache/)
/usr/lib/python3/dist-packages/docs/_static/core-p1-delete.png
/usr/lib/python3/dist-packages/docs/_static/core-p1-get.png
/usr/lib/python3/dist-packages/docs/_static/core-p1-set.png
/usr/lib/python3/dist-packages/docs/_static/core-p8-delete.png
/usr/lib/python3/dist-packages/docs/_static/core-p8-get.png
/usr/lib/python3/dist-packages/docs/_static/core-p8-set.png
/usr/lib/python3/dist-packages/docs/_static/custom.css
/usr/lib/python3/dist-packages/docs/_static/djangocache-delete.png
/usr/lib/python3/dist-packages/docs/_static/djangocache-get.png
/usr/lib/python3/dist-packages/docs/_static/djangocache-set.png
/usr/lib/python3/dist-packages/docs/_static/early-recomputation-03.png
/usr/lib/python3/dist-packages/docs/_static/early-recomputation-05.png
/usr/lib/python3/dist-packages/docs/_static/early-recomputation.png
/usr/lib/python3/dist-packages/docs/_static/gj-logo.png
/usr/lib/python3/dist-packages/docs/_static/no-caching.png
/usr/lib/python3/dist-packages/docs/_static/synchronized-locking.png
/usr/lib/python3/dist-packages/docs/_static/traditional-caching.png
/usr/lib/python3/dist-packages/docs/_templates/gumroad.html


For python3-gitlab, it should very likely not install these files at
all:

python3-gitlab: /usr/lib/python3/dist-packages/docs/__init__.py
python3-gitlab: /usr/lib/python3/dist-packages/docs/conf.py
python3-gitlab: /usr/lib/python3/dist-packages/docs/ext/__init__.py
python3-gitlab: /usr/lib/python3/dist-packages/docs/ext/docstrings.py


But I suspect that no package at all should ship a file in such a
generic location. So on the one hand not filing these issues against
"python3-gitlab _OR_ python3-diskcache" but against "python3-gitlab
_AND_ python3-diskcache".


And I'm filing this a wishlist bug against lintian as well.

I'd say any file …

* directly in /usr/lib/python3/dist-packages/docs/ should cause at least
  a warning or even an error.

* in a subdirectory of /usr/lib/python3/dist-packages/docs/ which is
  starting with an underscore ("_") should probably get a warning or at
  least a pedantic warning.

* And maybe for shipping any file in
  /usr/lib/python3/dist-packages/docs/ext/ as well.

* And according to #947264, #998820 and #973627 maybe also
  /usr/lib/python3/dist-packages/examples/,
  /usr/lib/python3/dist-packages/scripts/ and
  /usr/lib/python3/dist-packages/benchmarks/.

This likely is an expansion of the what
python-module-has-overly-generic-name already reports.

python-module-has-overly-generic-name is part of the
data/archive/auto-rejection.yaml and since both packages,
python3-diskcache as well as python3-gitlab seem to have no lintian
overrides, the tag seems not to have been triggered by these packages.

Then again, a local lintian run does not confirm this, at least not for
python3-gitlab:

$ lintian python3-gitlab_2.10.1-1_all.deb python3-diskcache_5.2.1-2_all.deb
E: python3-gitlab: python-module-has-overly-generic-name usr/lib/python3/dist-packages/docs/__init__.py (docs)
I: python3-diskcache: […]

So I wonder how python3-gitlab could get into the archive. Or is
data/archive/auto-rejection.yaml not in sync with the list that
ftp-masters actually use for lintian-based rejections? (JFTR: I checked
git HEAD of lintian, i.e. commit b996cbba, not the actual package in
unstable.)

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.15.0-trunk-amd64 (SMP w/4 CPU threads)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages python3-gitlab depends on:
ii  python3                    3.9.8-1
ii  python3-requests           2.25.1+dfsg-2
ii  python3-requests-toolbelt  0.9.1-1

python3-gitlab recommends no packages.

Versions of packages python3-gitlab suggests:
pn  python-gitlab-doc  <none>

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: python-gitlab
Source-Version: 1:2.10.1-2
Done: Federico Ceratto <federico@debian.org>

We believe that the bug you reported is fixed in the latest version of
python-gitlab, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1002824@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Federico Ceratto <federico@debian.org> (supplier of updated python-gitlab package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 29 Dec 2021 13:32:22 +0000
Source: python-gitlab
Architecture: source
Version: 1:2.10.1-2
Distribution: unstable
Urgency: medium
Maintainer: Federico Ceratto <federico@debian.org>
Changed-By: Federico Ceratto <federico@debian.org>
Closes: 1002824
Changes:
 python-gitlab (1:2.10.1-2) unstable; urgency=medium
 .
   * Remove unexpected directory (Closes: #1002824)
Checksums-Sha1:
 9065d1184b512a1e007a04489c0f60afc4c6db07 2277 python-gitlab_2.10.1-2.dsc
 b3af03e6f6a7fc27485fba0f10db59d5b1389cc6 4536 python-gitlab_2.10.1-2.debian.tar.xz
 7f975f67dbf46a8fa9b86acdff381a2da4fe0b2e 8467 python-gitlab_2.10.1-2_amd64.buildinfo
Checksums-Sha256:
 ac42214033a565a27ad45bb43e956d8873882a70fb09fc02fc50e7766848db0d 2277 python-gitlab_2.10.1-2.dsc
 5ca4962723e9c1523d44c26b09738b41e43f6d0648a48e4cadbba5fc04bc26d3 4536 python-gitlab_2.10.1-2.debian.tar.xz
 acdc3a5dc404ad5f581e1258543cb878f909633fbae53a1c72787da24b1aac50 8467 python-gitlab_2.10.1-2_amd64.buildinfo
Files:
 0656e63d3b3ed03037176d0c9322252c 2277 python optional python-gitlab_2.10.1-2.dsc
 be0f785aecdd13fa266d7e1eef9eb6cb 4536 python optional python-gitlab_2.10.1-2.debian.tar.xz
 a9950404666ec15ba8cb979a9591f7fc 8467 python optional python-gitlab_2.10.1-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfKfd+zM5IUCMbyuWbzG8RPUXfaoFAmHMZUsACgkQbzG8RPUX
farKsg/8C/htlC25ARygvgsMbmLwkdUKX4ZRAti3iVontQEjQHLf6kaD1nilKDIN
M+TMeDxiUaO3xfYz/SqKOPb+BTC5RSKtivIym4bXjC7ASliG1Qge8uwTPaXwLBIh
akzE6wsrBGLtBQiDZ7LpV+FoHl4XbRkNVLtb9o0ieI0kmnL23UlsSdTTcd4670Up
5yKiLl4gcYFgYCxC+fuifFh6YxMONLAVoGK18M4wyHr0bEFEt48mt7swj9WOWaX+
oBeKfUhTOBwcOEIEt55+WExTbL+yyoQDbkuvvklPuq7v4JYZxqPy/fSvJjNCNaBK
B54cpQ9c/aVBuRMEu4oceubNiPXJSMjBFd5Du0B2opbge5929Q4RkjflkDOJ4bUO
35QhmQwhor/p2OoUoHdF9zKxN6inP1qzS0ZbF+Z7Chu8LQnNxseg7poBFTbd2Lfs
TXkGV/vSlbFTaFCB0NiEMfuAz2AJDzJSrKE04MnD8TP5FcsydiMhbFqTzact/HgQ
1nD/KhhFBEds6eDl41XxE13ay10KCX1Uc9wdNvT4MNef226uOEsMN13SFzcRiRHd
acILiqDIbch74EicO9lTCNH9wMROhLy7CPs6Tv7eNqhEw3Gw+ikTCBxcNmpOwDsE
NZeAYMPMvDTflDoZr63CC6P7y0AgGQDB8H7IgVsxttuwAVk7NS4=
=YFUa
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: