[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#993813: warn about known invalid fields in debian/upstream/metadata



On Mon, Sep 06, 2021 at 03:10:05PM -0700, Felix Lechner wrote:
> On Mon, Sep 6, 2021 at 2:26 PM Jelmer Vernooij <jelmer@debian.org> wrote:
> > It won't provide maintainers of packages that use
> > invalid settings that they are. Isn't that purpose of lintian?
> I am not sure. Is it perhaps a gray zone the Janitor could fill?
I don't see how the janitor is related here. It's not a linting tool
and it can't report issues to maintainers. lintian-brush can fix a
subset of issues reported by lintian (where it can edit the canonical
source that matches the output scanned by lintian), but in the cases
where it can't we need the maintainer to fix the issue - and something
needs to tell the maintainer their package is wrong.

> There are a few open questions: Why for example does the Github signup
> page occur so often in the archive? [1] Do we actually need the field?
> [2] I am not even sure the reference is incorrect. What if an upstream
> manages bug reports via Github's issue tracker, like gocryptfs? [3]
> (Please don't worry—I did not set the Registration field there. [4])
> 
> To be sure, I am not opposed to your suggestion in principle, but
> people do a lot of weird stuff. Is the obscure (and often ignored)
> upstream metadata really worth our attention?

Whether these fields are useful enough to be included in
debian/upstream/metadata is a great question, and I'm very happy to
receive pushback in that regard. That should probably be a part of the
wider discussion around the finaliation of DEP-12.

> > Or, looking at a counter-example - there is e.g. a pypi-homepage
> > tag; not just a homepage classification.
> 
> I think there is a difference. A project's home page is often the
> first point of contact, especially in search of documentation. When do
> people look at the Registration field in the upstream metadata,
> please?

I think we should either kill these fields if they're not useful,
/or/ make sure that they have correct values in them. Leaving them with
often incorrect data makes them even less useful and just adds extra noise and work.

If they're a part of the debian/ packaging, then surely they're in the
realm of what lintian checks for? Should we create separate linters
for certain files under debian/ like debian/upstream/metadata ?

Jelmer

-- 
Jelmer Vernooij <jelmer@jelmer.uk>
PGP Key: https://www.jelmer.uk/D729A457.asc

Attachment: signature.asc
Description: PGP signature


Reply to: