Bug#972595: lintian: false positive unused-override on overrides disabled by negated arch lists

[Andreas Beckmann <anbe@debian.org>]

Package: lintian
Version: 2.94.0
Severity: important

Hi,

lintian 2.94.0 introduced a regression in the handling of negated arch lists.

These overrides:

========== 8< ==========
# The NVIDIA license does not allow any form of modification.
[!i386 !armhf]: spelling-error-in-binary
[!i386 !armhf]: hardening-no-bindnow
[!i386 !armhf]: hardening-no-fortify-functions
[!i386 !armhf]: hardening-no-relro

# On architectures no longer supported by the current driver,
# this is a dummy package depending on the 390xx legacy driver.
[i386 armhf]: transitional-package-not-oldlibs-optional
========== >8 ==========

now result in

I: xserver-xorg-video-nvidia: unused-override hardening-no-bindnow
I: xserver-xorg-video-nvidia: unused-override hardening-no-fortify-functions
I: xserver-xorg-video-nvidia: unused-override hardening-no-relro
I: xserver-xorg-video-nvidia: unused-override spelling-error-in-binary

on i386 and armhf.

This can be tested on xserver-xorg-video-nvidia_418.152.00-1_i386.deb,
i.e. the package from buster, but not sid (which has the transitional
packages removed).
(That uploaded package comes with an older version of the lintian overrides,
e.g. containing some renamed or removed tags, the pasted overrides above
have these fixed.)


Andreas