[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#742787: marked as done (lintian: Check for missing Disclaimer field in debian/copyright (for contrib/non-free packages))

Your message dated Fri, 24 Jul 2020 03:46:53 -0700
with message-id <CAFHYt56M8k+Dx-OANP07kWgTWBSUxQTr6rvbz2s9+MuW6im=aQ@mail.gmail.com>
and subject line lintian: Check for missing Disclaimer field in debian/copyright (for contrib/non-free packages)
has caused the Debian Bug report #742787,
regarding lintian: Check for missing Disclaimer field in debian/copyright (for contrib/non-free packages)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
742787: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=742787
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.5.21
Severity: wishlist

Heya,
  for contrib or non-free packages Policy §12.5 says (emphasis with asterisks
mine):

  Packages in the _contrib_ or _non-free_ archive areas *should* state in the
  copyright file that the package is not part of the Debian distribution and
  briefly explain why.

Debian Copyright Format 1.0 documents the "Disclaimer" field as the appropriate
place for such a statement (and points back to Policy 12.5):

  Disclaimer

  Formatted text, no synopsis: this field is used for non-free or contrib
  packages to state that they are not part of Debian and to explain why (see
  Debian Policy section 12.5).

It would be very nice to have a corresponding Lintian check if the field is
missing. I believe the conditions to trigger the check should be:

- the package is in contrib or non-free, and
- the package uses machine parseable debian/copyright, and
- debian/copyright lacks the Disclaimer field

How about it?

(and, as usual, my deepest admiration and infinite thanks for maintaining
lintian: the Debian world would be oh so much worse without it)

Cheers.

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils                       2.24-4
ii  bzip2                          1.0.6-5
ii  diffstat                       1.58-1
ii  file                           1:5.17-1
ii  gettext                        0.18.3.2-1
ii  hardening-includes             2.5
ii  intltool-debian                0.35.0+20060710.1
ii  libapt-pkg-perl                0.1.29+b1
ii  libarchive-zip-perl            1.30-7
ii  libclass-accessor-perl         0.34-1
ii  libclone-perl                  0.36-1
ii  libdpkg-perl                   1.17.6
ii  libemail-valid-perl            1.192-1
ii  libfile-basedir-perl           0.03-1
ii  libipc-run-perl                0.92-1
ii  liblist-moreutils-perl         0.33-2
ii  libparse-debianchangelog-perl  1.2.0-1
ii  libtext-levenshtein-perl       0.06~01-2
ii  libtimedate-perl               2.3000-1
ii  liburi-perl                    1.60-1
ii  man-db                         2.6.6-1
ii  patchutils                     0.3.2-3
ii  perl [libdigest-sha-perl]      5.18.2-2+b1
ii  t1utils                        1.37-2

Versions of packages lintian recommends:
ii  libautodie-perl                 2.23-1
ii  libperlio-gzip-perl             0.18-2
ii  perl-modules [libautodie-perl]  5.18.2-2

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.17.6
ii  libhtml-parser-perl    3.71-1+b1
ii  libtext-template-perl  1.46-1
ii  libyaml-perl           0.84-1
ii  xz-utils               5.1.1alpha+20120614-2

-- no debconf information

--- End Message ---
--- Begin Message --- 
Hi Zack,

>   Packages in the _contrib_ or _non-free_ archive areas *should* state in the
>   copyright file that the package is not part of the Debian distribution and
>   briefly explain why.

Your request was implemented but your bug was not closed. The tag exists:

Tag: missing-explanation-for-contrib-or-non-free-package
Severity: info
Check: debian/copyright/dep5
Info: The specified package is in the contrib or non-free archive
 area but does not include a "Comment" (or "Disclaimer") field in
 its copyright file.
 .
 Please add a brief comment why this package cannot be part of the
 main Debian distribution.
Ref: policy 12.5

This is the implementation:

    my $debian_control = $self->processable->debian_control;
    $self->tag('missing-explanation-for-contrib-or-non-free-package')
      if ($debian_control->source_fields->value('Section'))
      =~ m{^(?:contrib|non-free)(?:/.+)?$}
      && none { $header->exists($_) } qw(Comment Disclaimer);

The tag may be renamed to 'needs-disclaimer' and may become a warning,
but for now there is nothing to do. Closing this bug.

Thanks for helping to make Lintian better for everyone!

Kind regards
Felix Lechner

--- End Message ---
Reply to: