[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#965327: Lower severity of bash-completion-with-hashbang



Hi Vincent,

On Sun, Jul 19, 2020 at 9:03 AM Vincent Bernat <bernat@debian.org> wrote:
>
> bash-completion-with-hashbang got bump from
> minor to certain, after commit 70eaca50411.

I think that's a misunderstanding. We changed the scale back to the
simple EWI system after having classed tags by levels from the BTS for
some time. Due to Certainty: certain, this tag was always issued as a
warning. [1]

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935706#40

That being said, the tag was introduced just three weeks earlier (in
commit 6fbc952b) and may carry a severity higher than intended. (A
warning does not sound like minor, does it?) I will think about the
level.

> the shebang is harmless and I won't
> patch or other upstream about a harmless shebang.

As explained in this MR [2], we consider the hashbang an error. The
snippets are not meant to be executed. The upstream for
'bash-completion' also does not use them.

[2] https://salsa.debian.org/lintian/lintian/-/merge_requests/292

> Also, this helps
> editors turning on the right "mode" to edit the file.

This is an unrelated function that you may be able to resolve by using
[3] or [4].

[3] https://www.gnu.org/software/emacs/manual/html_node/emacs/Choosing-Modes.html
[4] http://vimdoc.sourceforge.net/htmldoc/syntax.html

You can see examples for both, at the top and the bottom of the file
respectively, here:

    https://salsa.debian.org/lintian/lintian/-/blob/master/checks/continuous-integration/salsa.pm

Kind regards
Felix Lechner


Reply to: