Bug#819460: lintian: duplicate-updaterc.d-calls-in-postinst false positive

["Chris Lamb" <lamby@debian.org>]

Hi Richard,

> FYI, I also had to silence a duplicate-updaterc.d-calls-in-postinst 
> false positive in ddclient. The two calls to update-rc.d are in the two 
> branches of an 'if' statement, so it is not actually called twice.
>
> See lines 139 and 149 of:
> https://salsa.debian.org/debian/ddclient/-/blob/debian/3.9.1-2/debian/postinst#L139
> 
> Commit that disabled the lintian check:
> https://salsa.debian.org/debian/ddclient/-/commit/b65a60e072334f0cee52b41ed4b254bce0d02bad

Glancing at this quickly, we now have:

        update-rc.d ddclient defaults >/dev/null
        invoke-rc.d ddclient start || exit 1

… yet we should be skipping the first due to:

    next unless /^(?:.+;|^\s*system[\s\(\']+)?\s*update-rc\.d\s+

So maybe we can fix this one. Can't immediately see why this is
not working.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-