[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#962158: marked as done (lintian: Swapped exit statuses and --fail-on default value require downstream adjustments)



Your message dated Tue, 23 Jun 2020 11:05:20 +0000
with message-id <E1jngjw-000Fyj-11@fasolo.debian.org>
and subject line Bug#962158: fixed in lintian 2.81.0
has caused the Debian Bug report #962158,
regarding lintian: Swapped exit statuses and --fail-on default value require downstream adjustments
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
962158: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962158
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.80.0
Severity: important

[ This probably deserves to be serious, but I'm not sure I can be
  bothered… ]

Hi,

As was mentioned on debian-devel@l.d.o, and on #debian-qa, the new
default is very problematic, and has not been properly justified.

The general expectation is that a linter is supposed to exit non-0
when it finds at least errors. When people use it in manual mode,
they will just see the reported tags, but in automatic settings the
error code is what makes this useful at all.

This change means that any current caller which uses lintian as part
of its acceptance testing will now silently let broken things through
(until someone eventually notices the breakage), some examples of this
in Debian are:

  - dupload/dput/dput-ng
  - sbuild
  - pbuilder
  - check-all-the-things
  - debomatic (?)
  - jenkins-debian-glue
  - pkg-perl-tools
  - dpkg-buildpackage --check-command
  - etc.

Then also any CI setup that uses lintian (say in .gitlab-ci.yml or
.travis, .circleci, or similar stuff).

While these could be adapted in Debian, it would still leave any CI or
in-house setup that calls lintian broken. This is made worse due to the
new option not being available in older releases before the default got
changed, which would imply cumbersome backward compatibility checks that
decide whether to use the new option or not.

If the default change made sense due to some technical rationale, this
effort might be worthwhile, but as it is, this is a bad default that will
require tons of useless work and introduces breakage for no good reason.

Thanks,
Guillem

--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.81.0
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 962158@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 23 Jun 2020 09:47:18 +0100
Source: lintian
Architecture: source
Version: 2.81.0
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 243158 554897 591665 755161 895597 904885 909696 914256 945869 950052 954459 954860 961709 961973 961975 962157 962158 962448 962583 962601 962671 963212
Changes:
 lintian (2.81.0) unstable; urgency=medium
 .
   [ Felix Lechner ]
   * Remove command line option --fail-on from the settings in configuration
     files. (Closes: #962157)
   * Use UTF-8 codepoint for copyright sign in copyright files.
     (Closes: #961975)
   * Add tag for architecture-specific paths in debian/not-installed.
     (Closes: #961973)
   * Rename tag to recursive-privilege-change and explain usage of
     runuser(1). (Closes: #895597)
   * Do not enable Perl warnings globally to reduce output clutter from
     external modules.
   * In debian/control, add dh-r to Build-Depends. (See: #961709)
   * Add two test cases from Ansgar's 'colorful' test package.
     (See: #962277)
   * Drop Email::Valid as obsolete and use regex to check emails for fully
     qualified hosts. (See: #962277)
   * Flag the use of acute accents in manpages. (Closes: #554897)
   * Flag ANSI escape characters in all fields of primary packaging control
     files. (See: #962277)
   * In check menus, title-case the hash keys representing field labels to
     make the tag context more human-readable.
   * Rename tag for mailing list on Alioth and convert to classification
     tag. (Closes: #962448)
   * Add a classification tag for field contents in primary package control
     files.
   * Find the correct section when looking at combined manpages.
     (Closes: #962601)
   * Read manual references as UTF-8 to show "en" dash correctly.
     (Closes: #904885)
   * Issue 'required-field' and 'recommended-field' tagsper Debian Policy
     section 5 instead of field-specific tags.
   * Fix mail host validation in debian/changelog and rename tag for bogus
     hosts.
   * Do not allow unsafe symlinks in autopkgtests. (Closes: #954860)
   * Broaden tag descriptions for lower custom compression settings.
     (Closes: #909696)
   * Do not impose a umask when running tests as it partially obscured a bug
     in Dpkg. (See: #945869 & #796257)
   * Emit a classification tags with octal file permissions for all files
     sources and installables. (See: #945869, #796257)
   * Reset process umask before unpacking source tarballs. (Closes: #945869)
   * Use case-sensitive field names in control files, package relations,
     debconf templates and autopkgtest files.
   * Mark commas not followed by whitespace in package descriptions.
     (Closes: #591665)
   * Do not use the Bash shell when syntax checking maintainer scripts using
     /bin/sh. (Closes: #954459)
   * Point out variant spellings of field names in control files.
   * Use case-sensitive Deb822 parser for profiles, tags, checks, internal
     harness tests,private scripts, and in readelf data within
     Processable::Objdump.
   * Add new tag breakout-link for such links in /usr/lib. (Closes: #243158)
   * Stop exempting files in debian/missing-sources from source-is-missing.
     (See: #962583)
   * Provide test case with JS sources in subdir of d/missing-sources.
     (Closes: #962583)
   * Issue tag for repeated path segments in installed files.
     (Closes: #950052)
   * Restore case-invariant access to control fields, per Debian Policy
     section 5.1.
   * Add an internal harness test requiring a declared diagnostic value for
     tag-related test. (Closes: #962671)
   * Parse mail addresses in package control fields in one place and
     validate domains using Data::Validate::Domain.
   * Add new checks for maintainer-provided manpages and desktop entries.
     (Closes: #755161)
   * Restore program failure when error tags are found. (Closes: #962158)
   * Rename documentation/man to documentation/manual and debian/manpages to
     debian/manual-pages. Also rename tags that refer to a 'manpage' to
     'manual-page' or another name.
   * Combine various national encoding tags into one and issue all in one
     check.
   * Rename new item-looping entry points in checks as not all items are
     files.
   * Provide script diagnostics in the "control index".
   * Remove conflict between no-template-description and
     untranslatable-debconf-templates. (Closes: #914256)
 .
   [ Chris Lamb ]
   * Update data/fields/perl-provides for Perl 5.030003.
 .
   [ Paul Wise ]
   * spelling: Add several corrections and sort using the UTF-8 locale.
 .
   [ Dylan Aïssi ]
   * Add the requires-r-api and ships-r-site-library tags for the R
     statistics language. (Closes: #961709)
 .
   [ Mo Zhou ]
   * Add a new "linked-with-obsolete-library" tag; marks only libcblas from
     the Debian Science team for now.
 .
   [ Rafael Laboissière ]
   * Fix false positives in the no-dh-sequencer tag when Makefile command
     prefixes (eg. "+") are used. (Closes: #963212)
Checksums-Sha1:
 c827536e0170ca0b9c3bb80c3f3c204636641d5b 4259 lintian_2.81.0.dsc
 bba8b80e8f76e90c1a919c3d0033c9179dab30c6 1964508 lintian_2.81.0.tar.xz
 9547d54655e65990094a4e98b69b56e5d3eb97dc 18003 lintian_2.81.0_amd64.buildinfo
Checksums-Sha256:
 1a68ba3e8bdc62b3155aa43295a57c27054cfafc2f69a7e7c1fdbf11e39d9451 4259 lintian_2.81.0.dsc
 3f247bf6c4c219bff2f4b9f32e7a83620d41c960c9206cb1638c1aed7148758a 1964508 lintian_2.81.0.tar.xz
 d7a19f0d1652160f4f928eeafdf5cb6e06e57e778a5a595d6d196da844bed08e 18003 lintian_2.81.0_amd64.buildinfo
Files:
 4182319680584c2feccea927a8f10125 4259 devel optional lintian_2.81.0.dsc
 d8528277fe6534a637ac4664f80804bf 1964508 devel optional lintian_2.81.0.tar.xz
 361761c781f8f587ae52058256d99e55 18003 devel optional lintian_2.81.0_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl7x3w8ACgkQHpU+J9Qx
HlgFeRAAq85vtyMdV7WdXQgNGHkMJaa5J2ruW3D219qMC0IoLlWB8R/7jcWwhXts
BGtcZ1ppAc6lrPhUN9g003gb/Ow1fnKc1+ZL9xk9VeNgUfNTjjIG/axO+F9k2c7t
BJ+qdsjW53pE9CrUnxXVAIe5Xz7klB0mZfmsoOyzmmlBE5rDxKwrIRrGK6iFxg/K
gI3PNS0W9aJBxgRcb82oV43G9Ec/blxxQXI1p0A0cf9w2eIk66u9ZwYp0joYv7zc
NEI2dMg2tFUVJl3QYewK7mZmZ6OWlEpVFsqCBgzKPzcXSn1KFRz0JFF3ZVEAW/QH
PsfS90Kdx6Z30l0Q32vzCyAp38cggsQI56Y7KTg1RxIqTM8cJ+OSlsWxTDqyWCe6
aEIP550c/Dz7jJUrPRbJCPkhOJRGzMwXdPxtHGQnPWGFiBFZPWX1rBBkeBtyQ7e3
MgJ6XUcm7p9UgQ4WTT3KTe1L0XYLBGDb2PJ7brP7+qPmp1tlOniYuwaJhhICnOZc
8c7duxLPE86iCQG8Vm/qsGzgxbPjg/6TgN0D3HRG0rBuDQGcxiP0AzuL7z0Dq1iI
8hOxEF9fu/dRZL6wCiwXrgSafrNfDbIIyII/saerc0TlRma6DTc1ODyeemZfsGkP
V8fM2w4NGlgo29IiI14S9ks7B4xYMr+nQxpE1J4qw1Iu38y1bw0=
=HJk0
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: