[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#706576: marked as done (lintian: Warn about git binary diffs in quilt patches)

Your message dated Wed, 17 Jun 2020 19:16:51 -0700
with message-id <CAFHYt54UuXfy46PBVMnq0tX37ZBHmY0L9o35GAO83i6K6z=9UQ@mail.gmail.com>
and subject line lintian: Warn about git binary diffs in quilt patches
has caused the Debian Bug report #706576,
regarding lintian: Warn about git binary diffs in quilt patches
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
706576: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=706576
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.5.12
Severity: wishlist
I've seen a package that had a quilt patch with a hunk being git binary diff (see bug #706508). Such hunks are currently ignored by patch(1) from wheezy/unstable, but they fail to apply with patch(1) from experimental. It would be nice if Lintian could warn of such patches. 

--
Jakub Wilk

--- End Message ---
--- Begin Message --- 
Hi Jakub,

I wrote a check, a tag and a test (attached for posterity) but they
are useless. dpkg exits because patch(1) refuses to apply the patch.
Please see the error at the bottom of this message for details.

The patch creates a binary file with the first 256 bytes of /bin/ls on
my system.

The condition you requested cannot be tested. Unfortunately, it will
not be available in Lintian. Closing this bug.

Kind regards
Felix Lechner

* * *

dpkg-source: warning: diff
'start-of-bin-ls-1.0/debian/patches/0001-Creates-a-binary-file-the-first-256-bytes-of-bin-ls.patch'
doesn't contain any patch
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building start-of-bin-ls using existing
./start-of-bin-ls_1.0.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
File start-of-bin-ls: git binary diffs are not supported.
dpkg-source: info: the patch has fuzz which is not allowed, or is malformed
dpkg-source: info: if patch
'0001-Creates-a-binary-file-the-first-256-bytes-of-bin-ls.patch' is
correctly applied by quilt, use 'quilt refresh' to update it
dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -E -b -B
.pc/0001-Creates-a-binary-file-the-first-256-bytes-of-bin-ls.patch/
--reject-file=- <
start-of-bin-ls-1.0.orig.Auu7Cz/debian/patches/0001-Creates-a-binary-file-the-first-256-bytes-of-bin-ls.patch
subprocess returned exit status 1

Attachment: binary-diff.pm
Description: Perl program

Attachment: git-binary-diff.desc
Description: Binary data

Attachment: testcase.tar.xz
Description: application/xz


--- End Message ---
Reply to: