[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#801528: marked as done (lintian: package-contains-timestamped-gzip false positive)

Your message dated Thu, 11 Jun 2020 23:41:13 -0700
with message-id <CAFHYt54VSyy-FfGnRm0+rK_CSV3OR0X6z4wQJ2sUmq6dK8Sw-Q@mail.gmail.com>
and subject line Re: Bug#801528: lintian: package-contains-timestamped-gzip false positive
has caused the Debian Bug report #801528,
regarding lintian: package-contains-timestamped-gzip false positive
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
801528: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801528
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.5.38
Severity: normal

Dear Debian Lintian Maintainers,

the tags package-contains-timestamped-gzip is documented as:

N:   The package contains a gzip-compressed file that has timestamps. Such
N:   files make the packages unreproducible, because their contents depend
N:   on the time when the package was built.

This of course only apply to files that are generated at build-time, not to files 
that are taken directly from the source package.
Lintian should not emit a warning in the later case, whether the file
is already compressed in the original source, or not.

Thanks for maintaining lintian!
-- 
Bill. <ballombe@debian.org>

Imagine a large red swirl here.

--- End Message ---
--- Begin Message --- 
Hi,

>    (gz_mtime != 0) and (gz_mtime - changelog >= 0)     (2)

That check was rewritten not too long ago. I ended up using exactly
that algorithm after some research (but without seeing this bug):

    https://salsa.debian.org/lintian/lintian/-/blob/master/checks/files/compressed/gz.pm#L78

Additional details can be found in these commits. (The code moved subsequently.)

    https://salsa.debian.org/lintian/lintian/-/commit/249dcbc7be8fa8615299e39f475ef92eda74c268
    https://salsa.debian.org/lintian/lintian/-/commit/aca68d8b7d0be0b2c5be8fe4985718477fe61d01

> but certainly now [that algorithm] won't work very well

A test case proves the tag works, but d/rules turns off dh-strip-nondeterminism:

    https://salsa.debian.org/lintian/lintian/-/commit/cea58cc580451211216459171c87f22be5c433e9

As predicted by Tomasz Buchert, the test fails when those lines are removed:

    -override_dh_strip_nondeterminism:
    -       # Skip, it messes with our test

> Basically it looks as if dh-strip-nondeterminism/toolchain strips/will
> strip so much that this tag may not be useful anymore.

That conclusion seems reasonable but is wrong: In a recent run across
the archive, the tag appeared in 143 source packages!

The tag works as intended. Closing this bug.

Kind regards
Felix Lechner

--- End Message ---
Reply to: