--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: lintian: Mass tag rename to unify naming convention
- From: Guillem Jover <guillem@debian.org>
- Date: Sun, 17 Feb 2019 22:34:20 +0100
- Message-id: <20190217213420.GB23841@gaara.hadrons.org>
Package: lintian
Version: 2.7.0
Severity: wishlist
Hi!
I brought this up for discussion on the mailing list some time ago [T],
and it resulted in the added support for renaming tags, which is great!
But the proposal then kind of died off.
[T] <https://lists.debian.org/debian-lint-maint/2015/08/msg00094.html>
I'm copying below that initial mail, and attaching the subsequent
rename proposals (plus a few more I think) as a patch using the added
mechanism, even though I've not checked for newly introduced tags since,
as a discussion starter. If there's agreement I could sit down and check
the rest of the tags, and actually rename them in the code base.
§§§
I've noticed the recent addition of tags with either very confusing
names like:
- debian-watch-may-check-gpg-signature
As reported in #735040, where the suggested name seems way better:
debian-watch-does-not-check-for-gpg-signature
- privacy-breach-may-use-debian-package
Does the privacy breach use the package? A better name could perhaps be:
privacy-breach-uses-embedded-file
Or names that instead of stating the detected fact, seem to dictate what
it would like to see.
- file-should-not-be-compressed
- debian-rules-should-not-automatically-update-control
- debian-rules-should-not-use-DEB_BUILD_OPTS
- debian-rules-should-not-use-or-modify-user-only-variable
- debian-rules-should-not-use-pwd
- debian-rules-should-not-use-underscore-variable
- maintainer-script-should-not-hide-init-failure
- maintainer-script-should-not-modify-ld-so-conf
- maintainer-script-should-not-modify-netbase-managed-file
- maintainer-script-should-not-use-adduser-system-without-home
- maintainer-script-should-not-use-ancient-dpkg-epoch-check
- maintainer-script-should-not-use-ancient-dpkg-multi-conrep-check
- maintainer-script-should-not-use-deprecated-chown-usage
- maintainer-script-should-not-use-dpkg-status-directly
- maintainer-script-should-not-use-fc-cache
- maintainer-script-should-not-use-gconftool
- maintainer-script-should-not-use-install-sgmlcatalog
- maintainer-script-should-not-use-service
- maintainer-script-should-not-use-start-stop-daemon
- maintainer-script-should-not-use-update-alternatives-remove
- maintainer-script-should-not-use-update-alternatives-set
I agree with Jakub Wilk's recent comments on the list that these are not
good names either. Lintian detects patterns, some might be problems that
must be fixed in all cases, others might be a matter of policy, others
might perhaps be issues sometimes, and that's why lintian allows
overridding/disabling them either per package or per profile. Encoding
either the severity/certainty or the possible solution in the tag name
duplicates the information contained elsewhere and makes them awkward
to change.
I'd request that no more such tag names be added, and ideally the
current ones be renamed, although the longer they stay the more
overrides they might accumulate. :/
I skimmed over other tag names and I've found also these patterns which
raise red flags for me (might have missed some), and do not conform
with the vast majority of other tags, or even related ones:
# -must-not-
- udeb-postinst-must-not-call-ldconfig
# -should-not-
- web-application-should-not-depend-unconditionally-on-apache2
- orphaned-package-should-not-have-uploaders
- changelog-should-not-mention-nmu
- debian-revision-should-not-be-zero
- library-in-debug-or-profile-should-not-be-stripped
# -might-not-
- description-synopsis-might-not-be-phrased-properly
# -should-
- changelog-should-mention-nmu
- changelog-should-mention-qa
- clean-should-be-satisfied-by-build-depends
- copyright-should-refer-to-common-license-file-for-apache-2
- copyright-should-refer-to-common-license-file-for-gfdl
- copyright-should-refer-to-common-license-file-for-gpl
- copyright-should-refer-to-common-license-file-for-lgpl
- debian-watch-file-should-dversionmangle-not-uversionmangle
- debian-watch-file-should-mangle-version
- debian-watch-file-should-use-sf-redirector
- debian-watch-file-should-uversionmangle-not-dversionmangle
- debug-file-should-use-detached-symbols
- debug-package-should-be-named-dbg
- debug-package-should-be-priority-extra
- games-package-should-be-section-games
- init.d-script-should-depend-on-virtual-facility
- menu-method-should-include-menu-h
- new-package-should-close-itp-bug
- postrm-should-call-ldconfig
- symlink-should-be-absolute
- symlink-should-be-relative
- transitional-package-should-be-oldlibs-extra
Thanks,
Guillem
From b094a6099aaeba702d3d88cca6da88494ce48297 Mon Sep 17 00:00:00 2001
From: Guillem Jover <guillem@debian.org>
Date: Sun, 17 Feb 2019 20:43:53 +0100
Subject: [PATCH] RFC: Mass tag rename to try to unify naming conventions
---
data/override/renamed-tags | 65 ++++++++++++++++++++++++++++++++++++--
1 file changed, 63 insertions(+), 2 deletions(-)
diff --git a/data/override/renamed-tags b/data/override/renamed-tags
index aa87b6113..cc51c01c8 100644
--- a/data/override/renamed-tags
+++ b/data/override/renamed-tags
@@ -1,16 +1,77 @@
-# list of renamed tag old name => new name. Please alpha sort by old name
+# list of renamed tag old name => new name. Please alpha sort by old name
+changelog-should-mention-nmu => changelog-does-not-mention-nmu
+changelog-should-mention-qa => changelog-does-not-mention-qa
+changelog-should-not-mention-nmu => changelog-mentions-nmu
+clean-should-be-satisfied-by-build-depends => debian-rules-clean-is-not-satisfied-by-build-depends
+copyright-should-refer-to-common-license-file-for-apache-2 => copyright-does-not-refer-to-common-license-file-for-apache-2
+copyright-should-refer-to-common-license-file-for-gfdl => copyright-does-not-refer-to-common-license-file-for-gfdl
+copyright-should-refer-to-common-license-file-for-gpl => copyright-does-not-refer-to-common-license-file-for-gpl
+copyright-should-refer-to-common-license-file-for-lgpl => copyright-does-not-refer-to-common-license-file-for-lgpl
debian-changelog-has-wrong-weekday => debian-changelog-has-wrong-day-of-week
+debian-revision-should-not-be-zero => debian-revision-is-zero
+debian-rules-should-not-automatically-update-control => debian-rules-automatically-updates-control
+debian-rules-should-not-use-DEB_BUILD_OPTS => debian-rules-uses-DEB_BUILD_OPTS
+debian-rules-should-not-use-or-modify-user-only-variable => debian-rules-uses-or-modifies-user-only-variable
+debian-rules-should-not-use-pwd => debian-rules-uses-pwd
+debian-rules-should-not-use-underscore-variable => debian-rules-uses-underscore-variable
+debian-watch-file-should-dversionmangle-not-uversionmangle => debian-watch-file-mangles-debian-version-with-uversionmangle ?
+debian-watch-file-should-mangle-version => debian-watch-file-does-not-mangle-version
+debian-watch-file-should-use-sf-redirector => debian-watch-file-does-not-use-sf-redirector
+debian-watch-file-should-uversionmangle-not-dversionmangle => debian-watch-file-mangles-upstream-version-with-dversionmangle
debian-watch-may-check-gpg-signature => debian-watch-does-not-check-gpg-signature
+debug-file-should-use-detached-symbols => debug-file-does-not-use-detached-symbols
+debug-package-should-be-named-dbg => debug-package-is-not-named-dbg
+debug-package-should-be-priority-extra => debug-package-is-not-priority-extra
dep5-file-paragraph-reference-header-paragraph => dep5-file-paragraph-references-header-paragraph
depends-on-build-essential-package-without-using-version => build-depends-on-build-essential-package-without-using-version
+description-synopsis-might-not-be-phrased-properly => description-synopsis-is-a-sentence
+doc-base-file-duplicated-field => duplicate-field-in-doc-base-file
+doc-base-file-duplicated-format => duplicate-format-in-doc-base-file
+duplicated-compressed-file => duplicate-compressed-file
+duplicated-tag-in-menu-item => duplicate-tag-in-menu-item
+duplicated-key-in-desktop-entry => duplicate-key-in-desktop-entry
fields-co-maintained-package-with-no-vcs-headers => fields-co-maintained-package-with-no-vcs-fields
+file-should-not-be-compressed => file-is-compressed
+games-package-should-be-section-games => games-package-is-not-section-games
+init.d-script-should-depend-on-virtual-facility => init.d-script-does-not-depend-on-virtual-facility
+library-in-debug-or-profile-should-not-be-stripped => library-in-debug-or-profile-is-stripped
+maintainer-script-may-use-dir_to_symlink_helper => maintainer-script-uses-ln-command-for-dir-to-symlink-switch
+maintainer-script-should-not-hide-init-failure => maintainer-script-hides-init-failure
+maintainer-script-should-not-modify-ld-so-conf => maintainer-script-modifies-ld-so-conf
+maintainer-script-should-not-modify-netbase-managed-file => maintainer-script-modifies-netbase-managed-file
+maintainer-script-should-not-use-adduser-system-without-home => maintainer-script-uses-adduser-system-without-home
+maintainer-script-should-not-use-ancient-dpkg-epoch-check => maintainer-script-uses-ancient-dpkg-epoch-check
+maintainer-script-should-not-use-ancient-dpkg-multi-conrep-check => maintainer-script-uses-ancient-dpkg-multi-conrep-check
+maintainer-script-should-not-use-deprecated-chown-usage => maintainer-script-uses-deprecated-chown-usage
+maintainer-script-should-not-use-dpkg-status-directly => maintainer-script-uses-dpkg-status-directly
+maintainer-script-should-not-use-fc-cache => maintainer-script-uses-fc-cache
+maintainer-script-should-not-use-gconftool => maintainer-script-uses-gconftool
+maintainer-script-should-not-use-install-sgmlcatalog => maintainer-script-uses-install-sgmlcatalog
+maintainer-script-should-not-use-service => maintainer-script-uses-service
+maintainer-script-should-not-use-start-stop-daemon => maintainer-script-uses-start-stop-daemon
+maintainer-script-should-not-use-update-alternatives-remove => maintainer-script-uses-update-alternatives-remove
+maintainer-script-should-not-use-update-alternatives-set => maintainer-script-uses-update-alternatives-set
+menu-method-should-include-menu-h => menu-method-does-not-include-menu-h
+new-package-should-close-itp-bug => new-package-does-not-close-itp-bug
+orphaned-package-should-not-have-uploaders => orphaned-package-has-uploaders
package-install-apt-preferences => package-installs-apt-preferences
package-install-apt-sources => package-installs-apt-sources
package-install-ieee-data => package-installs-ieee-data
package-install-into-obsolete-dir => package-installs-into-obsolete-dir
+postrm-should-call-ldconfig => postrm-does-not-call-ldconfig
privacy-breach-may-use-debian-package => privacy-breach-uses-embedded-file
source-copyright-license-header => source-copyright-license-field
+symlink-should-be-absolute => symlink-is-not-absolute
+symlink-should-be-relative => symlink-is-not-relative
systemd-no-service-for-init-rcS-script => missing-systemd-service-for-init.d-rcS-script
systemd-no-service-for-init-script => omitted-systemd-service-for-init.d-script
testsuite-unnecessary-testsuite-autopkgtest-header => testsuite-unnecessary-testsuite-autopkgtest-field
-transitional-package-should-be-oldlibs-extra => transitional-package-should-be-oldlibs-optional
+transitional-package-should-be-oldlibs-extra => transitional-package-is-not-oldlibs-optional
+transitional-package-should-be-oldlibs-optional => transitional-package-is-not-oldlibs-optional
+udeb-postinst-must-not-call-ldconfig => udeb-postinst-calls-ldconfig
+web-application-should-not-depend-unconditionally-on-apache2 => web-application-depends-unconditionally-on-apache2
+
+# 534938
+# usage: shlib > shared-library
+# confusion between shlibs file and shared libraries
+shared-lib-without-dependency-information => shlib-without-dependency-information
--
2.20.1.791.gb4d0f1c61a
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.79.0
Done: Chris Lamb <lamby@debian.org>
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 922544@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 01 Jun 2020 09:16:03 +0000
Source: lintian
Built-For-Profiles: nocheck
Architecture: source
Version: 2.79.0
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 534938 922544 935072 961855 961924
Changes:
lintian (2.79.0) unstable; urgency=medium
.
[ Felix Lechner ]
* Perform a mass-rename of tags for consistency according to the RFC.
(Closes: #922544)
* Use Email::Address::XS to parse all address components.
(Closes: #961924)
* Replace configuration option LINTIAN_PROFILE with 'profile'.
(Closes: #961855)
* Combine tags for missing native and non-native changelogs in
installation packages. (Closes: #935072)
* Clarify tag names related to shlibs control and shared libraries.
(Closes: #534938)
.
[ Paul Wise ]
* Add several spelling corrections.
Checksums-Sha1:
0ac3d4ad67f1eadf0fab793337283dbec1b8b246 4233 lintian_2.79.0.dsc
0226ebdea2cf6aeff5fc62aa3ae5954e826d6b9d 1892224 lintian_2.79.0.tar.xz
667627a5438e649b8577c82473db1c9d0e502ef7 5924 lintian_2.79.0_amd64.buildinfo
Checksums-Sha256:
2b511a5bbd7cbccb9acc5e1e9d14bfdd53ef01a3e196c57b97fe67bafcf2ef00 4233 lintian_2.79.0.dsc
4364af3a9e428b600a4630a16e3bca654442b92453cabeec93125f0922ca1a06 1892224 lintian_2.79.0.tar.xz
778405bf20833d323389ef917ad74fee6aefb86c70da9dd83f9eae0147b8251c 5924 lintian_2.79.0_amd64.buildinfo
Files:
856ae4730c565c84f5fe3d533e49f742 4233 devel optional lintian_2.79.0.dsc
51dc524d9d60967dff58bdb1684ac6f4 1892224 devel optional lintian_2.79.0.tar.xz
bca9929f28a2feb3a2e6b89d8f1c4cf5 5924 devel optional lintian_2.79.0_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl7Ux6oACgkQHpU+J9Qx
HlgpIA//RHYrHGUim+XoR6IRjgqSUFZPJlXW0XMKnC1E7Mc55GlQ2vYGkoyTtmtv
Dqg+3NmSfikz3bzECXITDS7OCBLB1zRBz3EVqeyBgD2e57SA+6+flbkeb+FzWJ+J
pk4myQswm0V/TJoRJXPcl2ud7VM3EI8y3RRCnZNp7BlThsshL80wvKK6ZsTQm5tj
NKkHwUDfhhcAMxhkgO1roEGBdAzTdf1xYMlnOaD3tiwZZQO0QSKjbUrQmbXT7p0R
RpZ9R6LvKjtKFI36aqqKhTcTUEuo+bwA6w0VFYJT9yjQ1EOHgMLwldXl/acOs3MA
L++O+9xNAdevAwrW9zBS3ui+NRkBzXMjIP7XBc/uHN15B19EQAKHyT7tzfJlTRAl
zDbqqgraedhe0TDKY5MX37amBCSJGNXYya0pSVRkdVA8eGG6aXcPTPRAV9vqFoUD
/XTVJMCUVNbPEXU0MPL+A/HjFfpP+8OZG6U364wELPXcLWikhab8ojLWWRptg8mK
BGdwGezpUvRGYxUEiJrYaZoHggMXJk5ySGM3XH8V7g2uyDh8PCEg7R5accJ81Xqs
uXectk97gPHNz2wKPB/OCu6f9al/7KTHKAQWO0wgS6c6MKgjHAvJLkhQjz9ILljI
21MuiqKm+IFVcscui6ihUhbasaLj4rVmAY0d5iY2IBSO1jOvqdo=
=ox88
-----END PGP SIGNATURE-----
--- End Message ---