[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#960807: Bug#950455: Don't emit override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS with debhelper 13



Hi gregor,

> On Sat, 16 May 2020 21:59:43 +0100, Chris Lamb wrote:
>
> > ACK; merging with #950455.
>
> Oops, sorry for missing that (ah, _src_:lintian)

My bad, I'm sure.

> > Simple in theory, but the well-tested code to parse the compat level
> > from various places is in debhelper.pm but we are parsing the
> > override_dh_auto_test in rules.pm.
> >
> > Making it "just" a library method is not that straightforward either
> > as the code in debhelper.pm also finds and reports on conflicting/
> > broken numbers, etc.

Glancing at this again, I think making extracting the compat level
into a library method would be the least worst option (vs. abstracting
out all the debian/rules.pm parsing).

Just need to think of the cleanest way of returning the many tags:
they should be emitted directly in debhelper.pm instead of in this
hypothetical subroutine. (For example,
debhelper-compat-file-contains-multiple-levels,
declares-possibly-conflicting-debhelper-compat-versions,
uses-debhelper-compat-file.)


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `- 


Reply to: