Bug#977332: Confusing debhelper tags (or perhaps duplicates)

[Felix Lechner <felix.lechner@lease-up.com>]

Package: lintian
Severity: normal

Hi,

During an experimental run (in which debhelper levels may not have
been available) the test suite produced the following output:

# --- debian/test-out/eval/checks/debhelper/debhelper-no-depends/tags.specified.calibrated
# +++ debian/test-out/eval/checks/debhelper/debhelper-no-depends/tags.actual.parsed
# -debhelper-no-depends (source):
package-needs-versioned-debhelper-build-depends 9
# +debhelper-no-depends (source):
package-lacks-versioned-build-depends-on-debhelper 9
#
# Unexpected tags:
#   package-lacks-versioned-build-depends-on-debhelper
#
# Missing tags:
#   package-needs-versioned-debhelper-build-depends

Those two tags sound very much alike (but carry different visibility
levels). Upon inspection, the code that triggers them also looks
similar. For details, please see below.

Please explain and differentiate the meanings of these tags in their
descriptions, or possibly combine them. Thanks!

Kind regards
Felix Lechner

* * *

    $dh_bd_version = $level if not defined($dh_bd_version);
    unless ($bdepends->implies("debhelper (>= ${dh_bd_version}~)")
        or $bdepends->implies("debhelper-compat (= ${dh_bd_version})")){
        my $tagname = 'package-needs-versioned-debhelper-build-depends';
        my @extra = ($level);
        $tagname = 'package-lacks-versioned-build-depends-on-debhelper'
          if ($dh_bd_version <= $compat_level->value('pedantic'));
        $self->hint($tagname, @extra);
    }

    $dh_bd_version = $level if not defined($dh_bd_version);
    unless ($bdepends->implies("debhelper (>= ${dh_bd_version}~)")
        or $bdepends->implies("debhelper-compat (= ${dh_bd_version})")){
        my $tagname = 'package-needs-versioned-debhelper-build-depends';
        my @extra = ($level);
        $tagname = 'package-lacks-versioned-build-depends-on-debhelper'
          if ($dh_bd_version <= $compat_level->value('pedantic'));
        $self->hint($tagname, @extra);
    }