-
d51ac081
by Chris Lamb
at 2019-09-21T03:09:16Z
Open new changelog entry.
Gbp-Dch: ignore
-
cddc69a4
by Chris Lamb
at 2019-09-21T15:47:42Z
Allow the lowercase version of "UNRELEASED" changelog entries in various tags. This is a convention used in the Debian ports archive. (Closes: #940877)
-
b8fa1e05
by Chris Lamb
at 2019-09-21T15:50:49Z
Drop matching for Source-Version substvars; they are not supported by dpkg-dev anymore and results in us accidentally matching an incorrect "Source-:Upstream-Version" variable. (Closes: #940878)
-
382a9d1a
by Chris Lamb
at 2019-09-21T18:07:38Z
Correct logic of debian-news-entry-has-strange-distribution.
Re. cddc69a4d58918387e3773849c8bb0160a751d65
Gbp-Dch: ignore
-
e2c33779
by Chris Lamb
at 2019-09-21T18:42:40Z
Bump severity of script-uses-unversioned-python-in-shebang (ie. "#!/usr/bin/env python") from classification to "pedantic" severity for now. (Closes: #934853)
-
97b85e49
by Chris Lamb
at 2019-09-22T07:03:34Z
Update test output now that we specify --pedantic.
Gbp-Dch: ignore
-
f779fe28
by Chris Lamb
at 2019-09-24T10:31:57Z
Release lintian/2.23.0 into unstable.
-
6b64cbaa
by Chris Lamb
at 2019-09-24T11:13:50Z
Open new changelog entry.
Gbp-Dch: ignore
-
2d29518c
by Felix Lechner
at 2019-09-24T15:35:36Z
Update centralized version parser to include backports.
There are several ways to parse the backports. A decision was made to
incorporate them here. The advantage is that the check looks a lot
more logical, at least to the author.
At the same time, the additional complexity in the parser isn't great.
Perhaps the parsing could be structured better in the future by
wrapping the version components for versions without backports in
another Lintian::Info::Changelog::Version.
The point is to standardize version processing and hide the details.
Both should work to reduce potential bugs.
Gbp-Dch: ignore
-
e8a5ad1d
by Felix Lechner
at 2019-09-24T15:35:36Z
Do not emit changelog-file-missing-explicit-entry when maintainer revision is 0. (Closes #940994)
Thanks to Simon McVittie for pointing it out, and for proposing a
great solution as well!
The tag was previously only issued for native packages, when it
related to NMUs (and not backports). It is now also issued when NMUs
do not have a proper prior version for non-native packages.
The latter seemed like a reasonable enhancement of functionality. It
was not based on the bug report.
-
636c8c35
by Felix Lechner
at 2019-09-24T15:35:36Z
Add a test for false positive.
This tests specifically for Simon McVittie's situation in Bug#940994,
which should now be fixed.
Gbp-Dch: ignore
-
67e781e8
by Felix Lechner
at 2019-09-24T15:35:36Z
Fix literal tests for lack of proper prior versions for non-native NMUs.
The tag changelog-file-missing-explicit-entry was previously only
issued for native packages when related to NMUs (and not backports).
The new check also issues the tag for non-native packages.
Several literal tests contain such a non-native NMU without proper
prior version. The newly appearing tags are added here.
Gbp-Dch: ignore
-
69ce6c43
by Felix Lechner
at 2019-09-26T12:39:25Z
In Lintian::Collect, cache result of method unfolded_fields; prevents duplicate tags.
The method unfolded_field could previously not be called multiple
times because it can trigger a tag. That tag could then appear
multiple times.
This adds caching to the method. The tag is only emitted when the
value is added to the cache, i.e. in the first invocation. There no
longer a risk of duplicate tags.
The method can now be invoked multiple times in one check or even in
multiple checks.
Gbp-Dch: ignore
-
14fa5a80
by Felix Lechner
at 2019-09-26T12:40:24Z
Split check/fields.pm into smaller components; invoke parts through old script.
This is the first step to divide the massive check 'fields' into
smaller components. They are invoked from the original script, meaning
they are not independent checks, in Lintian terminology.
Splitting the tests and the tags will take place later after it is
clear that no subchecks or tags need to be assigned to different
components. Then a '*.desc' file can be added, and the new check will
stand on its own.
This pattern may also be used for other large checks, such as files.
-
1d40cf38
by Felix Lechner
at 2019-09-26T12:40:32Z
Adjust literal tests for new tag output order.
In Lintian's output, tags appear in the order they are emitted.
Adjusts literal tests for changes is check execution order.
This commit contains no substantive changes.
Gbp-Dch: ignore
-
33710119
by Felix Lechner
at 2019-09-26T23:24:09Z
Fix t/bin/tagadjust to only remove tags in tagdiff once.
The previous algorithm removed all duplicates of a tag instead of only
one occurrence. Now removes only the first occurrence of a tag.
Gbp-Dch: ignore
-
aea28785
by Felix Lechner
at 2019-09-26T23:24:10Z
In checks/debian/changelog.pm, move all version-dependent tags to the source segment.
Parsing version requires the native or non-native status, which can
only be determined from a source package.
Moves the version related tags to the source facet of the check.
-
31f63d62
by Felix Lechner
at 2019-09-26T23:24:10Z
In checks/fields/version, move two tags relying on native detection to the source segment.
The two tags 'rc-version-greater-than-expected-version' and
'version-refers to distribution' depend on whether a package is
native. That detection is only reliable for source packages. The
Lintian facilities for binary packages will soon cease to offer it.
Going forward, the two tags will only be issued for source packages.
-
24efa9c6
by Felix Lechner
at 2019-09-26T23:24:10Z
Transfer binary heuristics for native status into checks/debian/changelog.pm.
The check debian/changelog depends in its binary segment on a
rudimentary form of native detection. The information is used to check
the installation paths for upstream and Debian changelogs, but not to
parse version numbers.
These checks cannot be be performed in source packages, and while they
should perhaps be part of the testsuite for dpkg-buildpackage instead,
it seemed unnecessary to lose this functionality right now.
Transfers the rudimentary native/non-native detection based on version
numbers out of Lintian::Collect::Binary, so it can be deleted from
there.
Gbp-Dch: ignore
-
72ff6754
by Felix Lechner
at 2019-09-26T23:24:10Z
In tests, update expected tags for checks restricted or transferred to source packages only.
Some tags switched from binary to source, and some tags moved. Some
checks related to the native detection of packages can only be
performed on source packages.
Gbp-Dch: ignore
-
8e834147
by Felix Lechner
at 2019-09-26T23:24:10Z
Remove support for native heuristics from Lintian facilities for installation (binary) packages.
There are many hints that a package is native, but the one that is
reliable only works for source packages. This removes from Lintian the
native detection facilities for installation (so-called binary)
packages.
There is history of inferring a native or non-native status for
installation (binary) packages from version numbers, but that
mechanism does not work all the time. There is also no reason why such
origin should matter for an installation package.
In Debian, a version string can only be parsed after the native or
non-native status was determined separately (which is no problem for
source packages). As a result of this requirement, many version
related tags can only issued for source packages.
-
212087c5
by Felix Lechner
at 2019-09-27T03:31:48Z
Remove duplicate test 'fields-version-bad' after moving check for rc-version-greater-than-expected-version.
The test case already exists for check debian/changelog. Removes the
copy for check fields, which is no longer needed once the related
check is moved.
The related check will be moved in the near future.
Gbp-Dch: ignore
-
43bf358b
by Felix Lechner
at 2019-09-27T03:58:10Z
Move check for tag 'rc-version-greater-than-expected-version' to check debian/changelog from fields/version.
This commit is a possible precursor to resolving Bug#782717. That fix
will require access to the previous changelog version, which is
available in the new location.
The mechanism to handle native package is slightly different because
the version parser in Lintian::Info::Changelog::Version returns native
package versions in the method maintainer_revision (but strips any
indicator for source NMUs).
The Dpkg parser, on the other hand, returned native package versions
in the same place as it would return an upstream version for a
non-native package.
Does not add back the regex string 'dev' that was removed in
Bug#732246.
-
ca455155
by Felix Lechner
at 2019-09-27T03:58:22Z
Associate tag 'rc-version-greater-than-expected-version' with check debian/changelog; fix description
The check for this tag was transferred to debian/changelog. Associates
the tag with that check.
Also fixes the tag description. The tag applies to both native and
non-native packages.
-
d25e4c02
by Felix Lechner
at 2019-09-27T03:58:22Z
In test 'fields-version-bad-rc', add expected tags after a check was moved.
This test already existed for debian/changelog. Adds a tag that
appeared after a check was transferred.
Gbp-Dch: ignore
-
249259ae
by Felix Lechner
at 2019-09-27T11:08:22Z
In check fields, sort list of submodules before execution to avoid test errors related to tag order.
-
f5ce33c7
by Chris Lamb
at 2019-09-27T14:57:30Z
Release lintian/2.24.0 into unstable.
-
94878c96
by Chris Lamb
at 2019-09-27T15:31:32Z
Merge tag '2.24.0' into buster-backports
Release lintian/2.24.0 into unstable.
Format: 1.8
Date: Fri, 27 Sep 2019 08:15:59 +0000
Source: lintian
Architecture: source
Version: 2.24.0
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 940994
Changes:
lintian (2.24.0) unstable; urgency=medium
.
[ Felix Lechner ]
* Do not emit changelog-file-missing-explicit-entry when maintainer
revision is 0 (eg. 1.2.5-0+deb10u1). (Closes: #940994)
* Remove internal support for checking whether binary packages are
"native".
* Various code cleanups, splitting checks/fields.pm into smaller
components, moving numerous tags, etc.
Checksums-Sha1:
428e4598ae5e1c20f9d3326630b37e03f9ea9284 3037 lintian_2.24.0.dsc
cc6bb3903d283714fc38201ee043fbaa6b7919aa 1765164 lintian_2.24.0.tar.xz
7e58c3ae3e76b229e388f41ece62beb89878a3e2 15668 lintian_2.24.0_amd64.buildinfo
Checksums-Sha256:
8342fbcf5cf9bcbba05d0612f0025d04e09df07723be355220f6beafd7a78eee 3037 lintian_2.24.0.dsc
52d562c45ea8038f8a6716b634e5372dcaa768c9cc64064cddc39957d497e850 1765164 lintian_2.24.0.tar.xz
fd7c8bf12a245aa51ece46ade0bd6ab1739db98ae40f5c4071b7ec0a93eb505d 15668 lintian_2.24.0_amd64.buildinfo
Files:
e41d21dea3799699265ab55961447009 3037 devel optional lintian_2.24.0.dsc
5da45313c9d16c67cc315337db16d1c8 1765164 devel optional lintian_2.24.0.tar.xz
f43ba17becaa11a680390783907c9964 15668 devel optional lintian_2.24.0_amd64.buildinfo
* tag '2.24.0': (27 commits)
Release lintian/2.24.0 into unstable.
In check fields, sort list of submodules before execution to avoid test errors related to tag order.
In test 'fields-version-bad-rc', add expected tags after a check was moved.
Associate tag 'rc-version-greater-than-expected-version' with check debian/changelog; fix description
Move check for tag 'rc-version-greater-than-expected-version' to check debian/changelog from fields/version.
Remove duplicate test 'fields-version-bad' after moving check for rc-version-greater-than-expected-version.
Remove support for native heuristics from Lintian facilities for installation (binary) packages.
In tests, update expected tags for checks restricted or transferred to source packages only.
Transfer binary heuristics for native status into checks/debian/changelog.pm.
In checks/fields/version, move two tags relying on native detection to the source segment.
In checks/debian/changelog.pm, move all version-dependent tags to the source segment.
Fix t/bin/tagadjust to only remove tags in tagdiff once.
Adjust literal tests for new tag output order.
Split check/fields.pm into smaller components; invoke parts through old script.
In Lintian::Collect, cache result of method unfolded_fields; prevents duplicate tags.
Fix literal tests for lack of proper prior versions for non-native NMUs.
Add a test for false positive.
Do not emit changelog-file-missing-explicit-entry when maintainer revision is 0. (Closes #940994)
Update centralized version parser to include backports.
Open new changelog entry.
...
-
a29130b8
by Chris Lamb
at 2019-09-27T15:31:36Z
Rebuild for buster-backports.