Bug#935607: lintian: classify "Starting $DESC" in init.d scripts

[Dmitry Bogatov <KAction@disroot.org>]

control: tags -1 -moreinfo

[2019-08-27 10:23] "Chris Lamb" <lamby@debian.org>
> Hi Dmitry,
>
> > [ Should I tag '-moreinfo' on reply, or you prefer doing it yourself? ]
>
> Please. A wishlist bug with "moreinfo" means (at least for me) that it
> is blocking on input from the reporter/requester and, if you believe
> you have resolved all the outstanding queries, then it makes sense to
> remove it so that it's easier to find things in the BTS that are ready
> to be worked on. Does that make sense?

Sure, it does. Just double-checked to not disrupt your workflow.

> > > > 	[ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC" "$NAME"
> > >
> > > Can you describe what is wrong with this? (So we can add it to the
> > > long description at the very least...)
> > 
> > Both behaviours are fine, as long they are used consistently.
>
> Oh, I think I see. Well, actually I was confused about this bug and
> indeed am not sure enough to implement anything yet. The problem is
> the use of the conditional checking of $VERBOSE, regardless of the
> action?
>
> I think what would be good is bunch of "good" and "bad" examples here
> to help me be 100% sure.

Again, there is no "good" and "bad" yet. Here is pseudo-code:

	for line in lines(/etc/init.d/script) {
		next unless if line =~ 'log daemon msg "(Starting|Stopping)';
		if line =~ '$VERBOSE' {
			classify 'do check for VERBOSE'
		} else {
			classify 'do NOT check for VERBOSE'
		}
	}

When we see, which of these styles is majority, we can proclaim other
unwanted and to be fixed.
-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.