Bug#935138: lintian: version-substvar-for-external-package only matches :Version and not :Upstream-Version

[Daniel Kahn Gillmor <dkg@fifthhorseman.net>]

Package: lintian
Version: 2.18.0
Severity: normal
Control: affects -1 src:wireguard

While resolving #930432 in the wireguard package, I noticed that the
code for lintian tag version-substvar-for-external-package appears to
only trigger if the dependency is on source:Version or binary:Version
but not on *:Upstream-Version.

While i'm legitimately overriding this tag in wireguard anyway, it
would probably make sense to test for :Upstream-Version too, for the
cases where it is actually catching a legitimate packaging mistake.

Thanks for your work on Lintian!

    --dkg

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (500, 'oldstable'), (200, 'unstable-debug'), (200, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils                     2.32.51.20190727-1
ii  bzip2                        1.0.6-9.2
ii  diffstat                     1.62-1+b1
ii  dpkg                         1.19.7
ii  dpkg-dev                     1.19.7
ii  file                         1:5.37-5
ii  gettext                      0.19.8.1-9
ii  gpg                          2.2.17-3
ii  intltool-debian              0.35.0+20060710.5
ii  libapt-pkg-perl              0.1.36+b1
ii  libarchive-zip-perl          1.64-1
ii  libcapture-tiny-perl         0.48-1
ii  libcgi-pm-perl               4.44-1
ii  libclass-accessor-perl       0.51-1
ii  libclone-perl                0.41-1+b1
pn  libdigest-sha-perl           <none>
ii  libdpkg-perl                 1.19.7
ii  libemail-valid-perl          1.202-1
ii  libfile-basedir-perl         0.08-1
ii  libfile-find-rule-perl       0.34-1
ii  libio-async-loop-epoll-perl  0.20-1
ii  libio-async-perl             0.74-1
ii  libipc-run-perl              20180523.0-1
ii  liblist-compare-perl         0.53-1
ii  liblist-moreutils-perl       0.416-1+b4
ii  libmoo-perl                  2.003004-2
ii  libpath-tiny-perl            0.108-1
ii  libtext-levenshtein-perl     0.13-1
ii  libtimedate-perl             2.3000-2
ii  libtry-tiny-perl             0.30-1
ii  libtype-tiny-perl            1.004004-1
ii  liburi-perl                  1.76-1
ii  libxml-simple-perl           2.25-1
ii  libyaml-libyaml-perl         0.79+repack-2
ii  man-db                       2.8.6.1-1
ii  patchutils                   0.3.4-2+b1
ii  perl                         5.28.1-6
ii  t1utils                      1.41-3
ii  xz-utils                     5.2.4-1

Versions of packages lintian recommends:
pn  libperlio-gzip-perl  <none>

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  libhtml-parser-perl    3.72-3+b3
ii  libtext-template-perl  1.55-1

-- no debconf information