Bug#934805: lintian: probably shouldn't emit package-supports-alternative-init-but-no-init.d-script for instanced systemd services (foo@.service)

["Chris Lamb" <lamby@debian.org>]

tags 934805 + patch
thanks

Hi Simon,

> - do not emit package-supports-alternative-init-but-no-init.d-script for
>   foo@.service at all, on the basis that the feature does not exist in
>   LSB init, so feature parity is not implementable

Indeed, we must have neglected these so-called "instanced" unit files
when implementing this.

I think a simple patch here would be:

    diff --git a/checks/init.d.pm b/checks/init.d.pm
    index 1850df31a..3f35c3c1a 100644
    --- a/checks/init.d.pm
    +++ b/checks/init.d.pm
    @@ -513,7 +513,7 @@ sub check_missing_script {
	 my ($info) = @_;
	 for my $file ($info->sorted_index) {
	     if (   $file =~ m,etc/sv/([^/]+)/run$,
    -            or $file =~ m,lib/systemd/system/(.*)\.service,) {
    +            or $file =~ m,lib/systemd/system/(.*)(?!@)\.service,) {
     
		 my $service = $1;
		 tag 'package-supports-alternative-init-but-no-init.d-script',$file

Thoughts?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-