--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: lintian: false positives for missing-systemd-timer-for-cron-script?
- From: "Francesco Poli (wintermute)" <invernomuto@paranoici.org>
- Date: Thu, 25 Apr 2019 18:06:40 +0200
- Message-id: <155620840049.12475.12884094392443023086.reportbug@crunch>
Package: lintian
Version: 2.12.0
Severity: normal
Hello,
on last Monday (April, the 22nd) I rebuilt my package (apt-listbugs)
inside a pbuilder-managed sid chroot environment and checked the
result with lintian/2.12.0 (that was the version available from sid
on that day: however, it seems to me that nothing relevant has
changed in version 2.13.0).
I got a new complaint from "lintian -EviIL +pedantic" :
missing-systemd-timer-for-cron-script
Well, nothing to say, that's true: apt-listbugs currently lacks
any systemd timer, but ships a cron.daily script.
Hence, I began doing some research on the proper way to ship a
systemd timer along with an equivalent cron script (while avoiding
conflicts between the two).
I looked for examples in other packages which seem to have already
done this. I think two examples could be man-db and logrotate,
is that correct?
$ dpkg -L man-db | grep 'cron\|systemd\/system\/[^\/]\+\.timer'
/etc/cron.daily
/etc/cron.daily/man-db
/etc/cron.weekly
/etc/cron.weekly/man-db
/lib/systemd/system/man-db.timer
$ dpkg -L logrotate | grep 'cron\|systemd\/system\/[^\/]\+\.timer'
/etc/cron.daily
/etc/cron.daily/logrotate
/lib/systemd/system/logrotate.timer
I even looked inside these files, and it seems to me that the systemd
timer is really equivalent to the cron script (in both cases).
But, to my great surprise, I see that lintian [complains] [about] those
two packages, as well!
[complains]: <https://lintian.debian.org/full/cjwatson@debian.org.html#man-db_2.8.5-2>
[about]: <https://lintian.debian.org/full/cgzones@googlemail.com.html#logrotate_3.14.0-4>
Are these false positives?
I took a look at the [code] that implements the check.
[code]: <https://salsa.debian.org/lintian/lintian/blob/master/checks/systemd.pm>
I have a question: is the following line
return if any { m,^/lib/systemd/system/\.timer$, } $info->sorted_index;
missing something in the regexp?
Should it be
return if any { m,^/lib/systemd/system/[^\/]+\.timer$, } $info->sorted_index;
or anyway something able to catch some characters between
"system/" and ".timer" ?
I am not sure this is the cause of the false positives, though.
Of course, I can well be completely off-track, so please bear with me!
Please clarify.
Thanks for your time!
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (800, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages lintian depends on:
ii binutils 2.31.1-16
ii bzip2 1.0.6-9
ii diffstat 1.62-1
ii dpkg 1.19.6
ii dpkg-dev 1.19.6
ii file 1:5.35-4
ii gettext 0.19.8.1-9
ii gpg 2.2.12-1
ii intltool-debian 0.35.0+20060710.5
ii libapt-pkg-perl 0.1.34+b1
ii libarchive-zip-perl 1.64-1
ii libcapture-tiny-perl 0.48-1
ii libcgi-pm-perl 4.40-1
ii libclass-accessor-perl 0.51-1
ii libclone-perl 0.41-1+b1
pn libdigest-sha-perl <none>
ii libdpkg-perl 1.19.6
ii libemail-valid-perl 1.202-1
ii libfile-basedir-perl 0.08-1
ii libio-async-perl 0.72-1
ii libipc-run-perl 20180523.0-1
ii liblist-moreutils-perl 0.416-1+b4
ii libparse-debianchangelog-perl 1.2.0-13
ii libpath-tiny-perl 0.108-1
ii libtext-levenshtein-perl 0.13-1
ii libtimedate-perl 2.3000-2
ii libtry-tiny-perl 0.30-1
ii liburi-perl 1.76-1
ii libxml-simple-perl 2.25-1
ii libyaml-libyaml-perl 0.76+repack-1
ii man-db 2.8.5-2
ii patchutils 0.3.4-2
ii perl 5.28.1-6
ii t1utils 1.41-3
ii xz-utils 5.2.4-1
Versions of packages lintian recommends:
ii libperlio-gzip-perl 0.19-1+b5
Versions of packages lintian suggests:
pn binutils-multiarch <none>
ii libhtml-parser-perl 3.72-3+b3
ii libtext-template-perl 1.55-1
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.14.0
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 927970@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 22 May 2019 07:47:56 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.14.0
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
lintian - Debian package checker
Closes: 927970 928126 928617
Changes:
lintian (2.14.0) unstable; urgency=medium
.
[ Chris Lamb ]
* Correct false-positives in missing-systemd-timer-for-cron-script due to
an incorrect regular expression. Thanks to Francesco Poli (wintermute)
for the patch. (Closes: #927970)
* Adjust package-contains-python-header-in-incorrect-directory as Python
3.8 dropped the "m" modifier that was used in Python 3.7 and below (eg.
/usr/include/python3.7m). (Closes: #928617)
.
[ Ivo De Decker ]
* Check for sources in the "main" section with only binaries in the
"contrib" section. (Closes: #928126)
.
[ Michael Biebl ]
* Consider the now-preferred /usr/share/dbus-1/{system,session}.d
directories (supported since dbus 1.9.18) when checking D-Bus services.
(MR: !187)
.
[ Xavier ]
* Fix an error where debian/tests/pkg-js/files contained deep (but valid)
directory. (MR: !199)
.
[ Paul Wise ]
* Add/fix several spelling corrections.
* Sort the dictionary
* Prefer American spelling for American typos
Checksums-Sha1:
3e8d55c4a948e245175a43f487940c8d86e454f4 3878 lintian_2.14.0.dsc
9578ebc31223011327548846339db1c1272af3c1 1713196 lintian_2.14.0.tar.xz
e2d551fe609f46296203caab7cfd1d679f089e95 1180072 lintian_2.14.0_all.deb
95538737dc90a170662640b2df9c2bae83747bf7 18114 lintian_2.14.0_amd64.buildinfo
Checksums-Sha256:
f40ac2cbce301a9331a1971aa92265f186a991a185a69e7081de85f39741e92d 3878 lintian_2.14.0.dsc
76962c76a0a35ff5fbcecc535f00ab58b10d3eee4b2dcae26fd9c9d2540309b6 1713196 lintian_2.14.0.tar.xz
3c19d1cc8b933a1efdd108e2f0956b2905f0540913a6c1392a90cb1762023cde 1180072 lintian_2.14.0_all.deb
57a87af37a955e6fd1813fa56130cd1f2fc504dc959e9a319b4665c6ee08b27d 18114 lintian_2.14.0_amd64.buildinfo
Files:
e7fd1107caebfc2509cd57608e91e59c 3878 devel optional lintian_2.14.0.dsc
541af73c6e4d513cef4c2cb6f5579ebd 1713196 devel optional lintian_2.14.0.tar.xz
97c97dd744ca843518dabedb3d9786fa 1180072 devel optional lintian_2.14.0_all.deb
eafc835de5c9beafb439808e1f73e863 18114 devel optional lintian_2.14.0_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlzlD04ACgkQHpU+J9Qx
Hliu6g//enaLBbkUBtdscPqdWs9QRJp3WHWs5HlLA0b143gYz5z5F1HciRJ9DMlf
mmy4zSe1IoNcF9e4R/ttQbHek3CydK2TznyFc190zQ6XDv2B/rF+MVg5DSzvEJdZ
g6F93MJ7wGvRYjIRz0EbYpoa1J7zu7UGStT5fmJd+b5O2kTqph60F9SopswA0xsc
2iHCUUFjILfsQPTk7gtRUjCHhYBEvLYtjH1xSC1LP5N1YaS2M/BBIYMZGPQCm3CP
CxL2UuNHfToNmHGwyhNWrcgyRTCulIDo4zzjQGqbTTfc1jx7VlWT4F2zG7vA6zLe
T4L/PbA/hTY00vWfT2a7/vABP1gQQ9yK7lcCPiZyVWjJuPK6U/iLHiIWRCQ7huoJ
t/V2xhPmopH5Jg3FmERxlXys6qYW0zv1zV9JUCmkuTIeJsHHE114h2tsah7R3U8/
l4Xb57EesRxcAAHDYSN4pBGLL9kxkoA8elDxL8trsHG/4bROkdCVUs9bvgixl7xn
GnSKonNJ4kkXdMIjXI/u+Fj90SmHNEz2MZ+tlu0mj3cs7IEWFkDyeQbfDwVPxitj
Ip19W9Hczhr0epFe1Hfm8wOxYnVMUmrpAFl29n9pcWLy64HY024Jqg6LG6IX5q+q
itzeHIjLyXn0l7cni/1VbsvXn47NVgyu6QsO1jk2IBQHt09KR1I=
=1ptl
-----END PGP SIGNATURE-----
--- End Message ---