Bug#928283: lintian: false positive pkg-js-tools-test-is-missing for openjk: assumes variables contain --with=nodejs

["Chris Lamb" <lamby@debian.org>]

tags 928283 + moreinfo
thanks

Hi Simon,

> I believe this is because it uses a variable in the dh invocation, to
> disable one binary package (which is not considered ready by upstream)
> unless built for experimental or with some DEB_BUILD_OPTIONS:
> 
>     dh_options =
>     ifneq ($(with_jk2),ON)
>     dh_options += -Nopenjk-outcast
>     endif
> 
>     ...
> 
>     %:
>             dh $@ --builddir=obj $(dh_options)
> 
> and checks/debhelper.pm assumes this might contain all possible addons:

That sounds about right. However, as alternative suggestion how would
you feel about simply not emitting these tags if notice the package
is using dynamic variables? This is an approach taken in quite a few
places already in Lintian so not only is there is prior art it
naturally prevents the codebase becoming too clever or special-cased.

Indeed, how common even is this false-positive? It might be even more
sensible to add a Lintian override until upstream accepts the package;
it's meant to be temporary until upstream reviews/accepts some change,
after all.


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-