[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#926767: marked as done (lintian: emit classification tag about patch system in use)



Your message dated Mon, 22 Apr 2019 09:33:42 +0000
with message-id <E1hIVKY-0001T9-7O@fasolo.debian.org>
and subject line Bug#926767: fixed in lintian 2.13.0
has caused the Debian Bug report #926767,
regarding lintian: emit classification tag about patch system in use
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
926767: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926767
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.9.1
Severity: wishlist
Tags: patch

Hi,

I'm working on generating historical stats about Debian packages, using
lintian to extract information from packages.

One thing I'd like to track is the usage of source formats, and for 1.0,
the usage of patch systems. An example graph is 
https://blop.info/pub/patch-systems-stacked.png

Could lintian emit a classification tag allowing me to track that?
The patch below works for me.

Also, I noticed that lintian currently ignores simple-patchsys.mk, other
than reporting, for example:
W: notify-python source: debian-rules-uses-deprecated-makefile line 3 /usr/share/cdbs/1/rules/simple-patchsys.mk

This patch system is still widely used according to
https://codesearch.debian.net/search?q=simple-patchsys.mk+path%3Adebian%2Frules

Thanks!

Lucas


diff --git a/checks/patch-systems.desc b/checks/patch-systems.desc
index 033c7fb3c..bce93cd9e 100644
--- a/checks/patch-systems.desc
+++ b/checks/patch-systems.desc
@@ -247,3 +247,8 @@ Info: The specified series file is a vendor-specific patch series file.
  such differing source packages or modify the build process to behave
  conditionally or to conditionally patch files explicitly.
 Ref: #904302, https://lists.debian.org/debian-devel-announce/2018/11/msg00004.html
+
+Tag: patch-system
+Severity: classification
+Certainty: certain
+Info: the patch system used by the package (if any)
diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
index 69f0b59b0..b720a7f85 100644
--- a/checks/patch-systems.pm
+++ b/checks/patch-systems.pm
@@ -63,6 +63,7 @@ sub run {
     #----- dpatch
     if ($build_deps->implies('dpatch')) {
         my $list_file;
+        tag 'patch-system', 'dpatch';
         tag 'package-uses-deprecated-dpatch-patch-system';
         $uses_patch_system++;
         $list_file = $dpdir->resolve_path('00list') if $dpdir;
@@ -147,6 +148,7 @@ sub run {
         if (not $patch_series or not $patch_series->is_open_ok) {
             tag 'quilt-build-dep-but-no-series-file' unless $quilt_format;
         } else {
+            tag 'patch-system', 'quilt';
             my (@patches, @badopts);
             my $series_fd = $patch_series->open;
             while (my $patch = <$series_fd>) {

-- System Information:
Debian Release: 9.8
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (400, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: armhf

Kernel: Linux 4.18.0-0.bpo.1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils                          2.28-5
ii  bzip2                             1.0.6-8.1
ii  diffstat                          1.61-1+b1
ii  dpkg                              1.18.25
ii  dpkg-dev                          1.18.25
ii  file                              1:5.30-1+deb9u2
ii  gettext                           0.19.8.1-2
ii  gnupg [gpg]                       2.1.18-8~deb9u4
ii  intltool-debian                   0.35.0+20060710.4
ii  libapt-pkg-perl                   0.1.32
ii  libarchive-zip-perl               1.59-1+deb9u1
ii  libcapture-tiny-perl              0.44-1
ii  libcgi-pm-perl                    4.35-1
ii  libclass-accessor-perl            0.34-1
ii  libclone-perl                     0.38-2+b1
ii  libdpkg-perl                      1.18.25
ii  libemail-valid-perl               1.202-1
ii  libfile-basedir-perl              0.07-1
ii  libio-async-perl                  0.71-1
ii  libipc-run-perl                   0.94-1+deb9u1
ii  liblist-moreutils-perl            0.416-1+b1
ii  libparse-debianchangelog-perl     1.2.0-12
ii  libpath-tiny-perl                 0.100-1
ii  libperl5.24 [libdigest-sha-perl]  5.24.1-3+deb9u5
ii  libtext-levenshtein-perl          0.13-1
ii  libtimedate-perl                  2.3000-2
ii  libtry-tiny-perl                  0.28-1
ii  liburi-perl                       1.71-1
ii  libxml-simple-perl                2.22-1
ii  libyaml-libyaml-perl              0.63-2
ii  man-db                            2.7.6.1-2
ii  patchutils                        0.3.4-2
ii  perl                              5.24.1-3+deb9u5
ii  t1utils                           1.39-2
ii  xz-utils                          5.2.2-1.2+b1

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b2

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  libhtml-parser-perl    3.72-3
ii  libtext-template-perl  1.46-1

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.13.0

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 926767@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 22 Apr 2019 09:01:36 +0000
Source: lintian
Binary: lintian
Built-For-Profiles: nocheck
Architecture: source all
Version: 2.13.0
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 923331 923339 926766 926767 926768
Changes:
 lintian (2.13.0) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - debhelper-compat-level
       - patch-system
       - pkg-js-autopkgtest-file-does-not-exist
       - pkg-js-autopkgtest-test-is-missing
       - pkg-js-tools-test-is-missing
       - vcs
       - vcs-uri
 .
   [ Niels Thykier ]
   * gitlab-ci: Run commands with the time command to get an estimate
     for each part.
   * Ensure that LINTIAN_CFG is always defined as it is used in debug
     output.
   * Fix a typo that called the wrong clean-up function with --unpack.
   * Extract reporting related utilities into a separate module.
   * Remove unused system_env function from Lintian::Util
   * Move Deb822 parsing into its own module called Lintian::Deb822Parser.
 .
   [ Felix Lechner ]
   * Implement universal output format in Lintian.
   * Only run tests in t/bin/runtests but do not build any packages.
 .
   [ Xavier ]
   * Test for Node.js packages that don't ship a debian/tests/pkg-js/test
     file or ship a debian/tests/pkg-js/files that contains invalid/missing
     references. (Closes: #923339)
   * Test for Node.js packages that use "--with nodejs" in debian/rules but
     do not specify a debian/tests/pkg-js/test file. (Closes: #923331)
 .
   [ Adam D. Barratt ]
   * Update private/refresh-locale-codes to work with newer isoquery(1) and
     refresh data/files/locale-codes and data/fields/virtual-packages to
     match.
 .
   [ Lucas Nussbaum ]
   * Emit a classification tag about the current debhelper compat level
     in use. (Closes: #926766)
   * Emit a classification tag that records the patch system in use.
     (Closes: #926767)
   * Emit a classification tags about the revision control system used by
     the package. (Closes: #926768)
 .
   [ Michael Biebl ]
   * Also look in /usr/share/dbus-1/{system,session}.d for dbus
     configuration files. (MR: !187)
 .
   [ Simon Quigley ]
   * Add "eoan" as a known Ubuntu distribution. (MR: !198)
 .
   [ Chris Lamb ]
   * Clarify "Could not determine what you meant by" test harness error
     message; it is not always a parse error.
 .
   [ Paul Wise ]
   * Add/fix several spelling corrections.
Checksums-Sha1:
 9efa26b1ee4de36cf1e7c64c406de2de2647cdf2 3878 lintian_2.13.0.dsc
 2127317ae105225fffe890d9ee285c81e6b33ed8 1706860 lintian_2.13.0.tar.xz
 cb8de91e5c7319e38ad400c26f436f99da9b3152 1174592 lintian_2.13.0_all.deb
 4fd40ad82898e692cac1fe2adf9b16552aa42f4c 8908 lintian_2.13.0_amd64.buildinfo
Checksums-Sha256:
 cba837c234bd7a5d86d66dc357206031f38a9d126bacfebfed4c497f9ec00f1b 3878 lintian_2.13.0.dsc
 3a3e04972a408f4b9dac7e3a831f50ba11fc8cd0a240acfb474429a46e011b63 1706860 lintian_2.13.0.tar.xz
 fc3ff5026d4d930a56b8f0d0bb10cd129ce94b57587d919ef09ff9175199cfea 1174592 lintian_2.13.0_all.deb
 eeebc3487e129df2fcd5148a979214a40a9150e2c1c552952da3ea2b19640917 8908 lintian_2.13.0_amd64.buildinfo
Files:
 d90686844724846f86d6eec52a970be5 3878 devel optional lintian_2.13.0.dsc
 25a301e5f22572bed147db263383ffec 1706860 devel optional lintian_2.13.0.tar.xz
 1415ad9bfcd4cfa9a0fb72242bfcf9aa 1174592 devel optional lintian_2.13.0_all.deb
 ad45f714d8a3dbd06cb6d14edbe00b60 8908 devel optional lintian_2.13.0_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAly9iIEACgkQHpU+J9Qx
HlhtlQ//Y7ChkSAMwnNaQtQLOO6ugLnxxjxJGbEnmT/W3bQGS7cFnp2EEnQI1VYu
GsHUFkYEyFHGeLOZy+P6xYIdu04cLwBv+TLHTQbb0T+S5rKqY6zh5sQ+Yv/mlzJW
u+7jH08x0/cCUOUmFSWVx7rsxpZdFHWeD6kJpKtNhOY24h/LtfGNsAS14kqUU2fy
zJDgQw6c7xV1bkFlbD8/8xS4rAg3Jz7ZXShiiFVS14KGPLMIcmu7FOCZZzO/vkA8
j1S2I3PdBeJYpMqv6AegdJ2GIzdZBluHAtQLxRtWuo9LmpB9kZecbA+rFPs081ts
iawDUdu3JVw9QxEIj3PPS8PcWQwBi4KJLsl5haObvnOSE8xiz2xhWbJuCQXt17jw
SfLDjtdU4EnCT7/+FhDo3VI0vhO/Au+RkgwCjJenxQskeMSkFQRyKLtL+SeHhFCn
WiBbWvUAJrM4mqMQNv8dBFoBaUHcJIC4XZeDmcAHKjwpQU6ushVFKVAo9eDpkR30
7l9Mx3EBpcu+8xRc78MEBVGrw0uJtXsvhCT62LI4MBjf/vaGzJvmKf5BugRJAvYl
sQq57zfrVX8pbEoOqz86VWqiV/eSdsBC1N/Mirtcs6f0i4maMgkZwTM39JDyn52I
ojS70+TdNsnTR/OAvlpvUoJFWQyzgIP07EEhESGp1gEnBeX0SlM=
=CaX2
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: