[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#919604: marked as done (lintian: warnings on new-style init scripts)

Your message dated Mon, 21 Jan 2019 21:35:21 +0000
with message-id <E1glhE1-0001Tz-4f@fasolo.debian.org>
and subject line Bug#919604: fixed in lintian 2.5.123
has caused the Debian Bug report #919604,
regarding lintian: warnings on new-style init scripts
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
919604: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919604
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.5.121
Severity: wishlist

Dear Maintainer,

Lintian seems to be very confused by new style init scripts:

	#!/usr/bin/env /lib/init/init-d-script
	### BEGIN INIT INFO
	# Provides:          bcron-sched
	# Should-Start:      $syslog
	# Required-Start:    $time
	# Required-Stop:     $time
	# Default-Start:     2 3 4 5
	# Default-Stop:      0 1 6
	# Short-Description: bcron system scheduler
	### END INIT INFO
	NAME='bcron-start'
	DESC='bcron system scheduler'
	DAEMON=/usr/sbin/bcron-start

	daemon_ () { /usr/bin/daemon --noconfig --name "${NAME}" "$@"; }
	if ! test -x '/usr/bin/daemon' ; then
		log_failure_msg "install \`daemon' package to use ${NAME} script"
		exit 1
	fi

	do_start_cmd_override () {
		daemon_ "${DAEMON}"
	}

	do_stop_cmd_override () {
		if daemon_ --running ; then
			daemon_ --stop
		fi
	}

and outputs a lot of warnings and errors:

	W: bcron: init.d-script-uses-usr-interpreter etc/init.d/bcron-update /usr/bin/env
	W: bcron: init.d-script-does-not-source-init-functions etc/init.d/bcron-sched
	E: bcron: init.d-script-does-not-implement-required-option etc/init.d/bcron-spool restart
	E: bcron: init.d-script-does-not-implement-required-option etc/init.d/bcron-spool force-reload

Rationale:

  * /lib/init/init-d-script is shell script; kFreeBSD does not
    support shell scripts as shebang interpreters, hence /usr/bin/env
  * /lib/init/init-d-script does source init functions
  * /lib/init/init-d-script does implement both restart and force-reload
    in generic way (stop -> start).

Actually,

	#!/usr/bin/env /lib/init/init-d-script
	### BEGIN INIT INFO
	# Provides:          foo
	# Should-Start:      $syslog
	# Required-Start:    $time
	# Required-Stop:     $time
	# Default-Start:     2 3 4 5
	# Default-Stop:      0 1 6
	# Short-Description: foo daemon
	### END INIT INFO
	NAME='foo daemon'
	DESC='foo deamon that frobnicates bars'
	DAEMON=/usr/sbin/foobar

is perfectly fine new style init script. As you can see, there is no
explicit references to stop/start/restart actions, but they are present.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=eo.utf8, LC_CTYPE=eo.utf8 (charmap=UTF-8), LANGUAGE=eo.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)

Versions of packages lintian depends on:
ii  binutils                       2.31.1-11
ii  bzip2                          1.0.6-9
ii  diffstat                       1.62-1
ii  dpkg                           1.19.2
ii  dpkg-dev                       1.19.2
ii  file                           1:5.35-2
ii  gettext                        0.19.8.1-9
ii  gpg                            2.2.12-1
ii  intltool-debian                0.35.0+20060710.4
ii  libapt-pkg-perl                0.1.34+b1
ii  libarchive-zip-perl            1.64-1
ii  libcgi-pm-perl                 4.40-1
ii  libclass-accessor-perl         0.51-1
ii  libclone-perl                  0.41-1+b1
pn  libdigest-sha-perl             <none>
ii  libdpkg-perl                   1.19.2
ii  libemail-valid-perl            1.202-1
pn  libfile-basedir-perl           <none>
ii  libipc-run-perl                20180523.0-1
ii  liblist-moreutils-perl         0.416-1+b4
ii  libparse-debianchangelog-perl  1.2.0-13
pn  libtext-levenshtein-perl       <none>
pn  libtimedate-perl               <none>
ii  liburi-perl                    1.76-1
ii  libxml-simple-perl             2.25-1
ii  libyaml-libyaml-perl           0.76+repack-1
ii  man-db                         2.8.5-1
ii  patchutils                     0.3.4-2
ii  perl                           5.28.1-3
ii  t1utils                        1.41-3
ii  xz-utils                       5.2.2-1.3

Versions of packages lintian recommends:
pn  libperlio-gzip-perl  <none>

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  libhtml-parser-perl    3.72-3+b3
pn  libtext-template-perl  <none>

-- no debconf information

Attachment: pgpjr7q0NKBt7.pgp
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: lintian
Source-Version: 2.5.123

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 919604@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 21 Jan 2019 18:53:24 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.123
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 907072 919162 919604 919740 919839 919979
Changes:
 lintian (2.5.123) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - inconsistent-appstream-metadata-license
       - package-contains-python-header-in-incorrect-directory
     + Renamed:
       - package-contains-usr-unmerged-pathnames ->
         package-contains-real-file-outside-usr
 .
   [ Chris Lamb ]
   * Group warnings that only differ on the architecture in the HTML
     reports. (Closes: #919162)
   * Prevent a large number false-positives when checking "new style" init
     scripts that use "#!/usr/bin/env /lib/init/init-d-script" as their
     shebang. (Closes: #919604)
   * Check for packages that ship headers in /usr/include/python3.x.
     (Closes: #919979)
   * Check for inconsistencies between debian/copyright and the information
     embedded/duplicated in AppStream metadata files. Thanks to Daniel Kahn
     Gillmor for the idea. (Closes: #907072)
   * package-contains-usr-unmerged-pathnames tag:
     - Prevent false-positives for leading directories. (Closes: #919839)
     - Rename from package-contains-real-file-outside-usr.
     - Move to "Classification" severity instead of a pedantic/experimental
       combination.
   * Use a verb in the debian-changelog-line-too-short tag description.
   * Use "state cache" vs "state-cache" consistently between source and
     binary packages when printing warnings during report generation.
   * Update added/removed tag summary generation code to match "WIP" now we
     are using gbp-dch(1).
 .
   [ Niels Thykier ]
   * lib/lintian: Do entry removals asynchroniously in temp labs.
   * Lintian::Unpacker:
     * Migrate to use IO::Async.
     * Refactor to extract a "find_next_task"-sub(-generator).
     * Add a simple queue to avoid some overhead.
     * Support prioritizing unpacking by collections.
 .
   [ Felix Lechner ]
   * Template cleanup: (MR: !131)
     - Rename tests-watchfile and tests-pedantic.
     - Use renamed template sets in skeletons for suite tests.
     - Move upstream/metadata from debian-native to debian-extra-non-native.
     - Delete unused template set source-arch-independent.
 .
   [ Mike Miller ]
   * Reword the description of the description-too-long tag to match the
     actual check. (Closes: #919740)
 .
   [ Paul Wise ]
   * Add several spelling corrections.
Checksums-Sha1:
 2371969927e53da8e6aa2f4fceab661d270da042 3568 lintian_2.5.123.dsc
 c7b444577d5ede8cd807f42271201a6da67dd35f 1636528 lintian_2.5.123.tar.xz
 7326894ad57711fda1e75f9fce9a74775cca075b 1187544 lintian_2.5.123_all.deb
 2d6de2ea48f23eafd96135e551cd84432019b0c1 17541 lintian_2.5.123_amd64.buildinfo
Checksums-Sha256:
 12658b17dedbc36cb2358bf051b0f190cbc807fa5ccff32eeee6ee4f112bdfa9 3568 lintian_2.5.123.dsc
 74ab0933f04667b9b78566b1728c6a3bef9d7aa32e621c267edb341565767027 1636528 lintian_2.5.123.tar.xz
 e6d72c623bb9f638f00ca800c0d2e2071dcbfea7f005a0e66fb5da24a97892a5 1187544 lintian_2.5.123_all.deb
 687d93d23e2acba96bb31e586d05b48dd872e0d1247cbc9d4df447724ffc71d4 17541 lintian_2.5.123_amd64.buildinfo
Files:
 b11a978456bd89f7d8cdc1fb80236d6b 3568 devel optional lintian_2.5.123.dsc
 790d2a215e0187e7ad49708e18543327 1636528 devel optional lintian_2.5.123.tar.xz
 de5f4e44d2d6c764f2c61a54c95faada 1187544 devel optional lintian_2.5.123_all.deb
 320347fa0e43362485a97a510bc4a1fd 17541 devel optional lintian_2.5.123_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlxGOV8ACgkQHpU+J9Qx
HlhnQQ//fNumJ+fqCUCzRh7GWF64VNviUh3n5aFNr9L/czUBY93Mlmsrw5PmG2eb
r8x+gLMp58mYCdsGnYpfkmi98j+tvOEe6M9g7H/SleP8ujxHqOhwh1g8MssLFWJ+
SqP5x/UMgzQXas4fYsZufhoNaH+qXtsVRvsMhkyaSOLgvkZaj8oalIYj+O5cabAl
2e16zgXpvKkiupW6/0/r3GMTMABQHgAzJE5Ky54xno1m5XumVlMfaqFGB+YIT1/J
ttx10YOfQM2OrJ/mml2IkpRdF7Z096SLZ3VlmCf7UNZashPgt6zrAR9jVM5oAljU
blzRb0euNo66xp1/XxBnE2m16oUeTzA2lQ3Rz5shZcA3eETukB6bsQk2N3gGNp2F
N+UPvZq5S8u45XnS9WQAovOntBghW4ItMo5dJMsXofCt5EIscs/Q/Sq7gEVOAzxd
gYPAMYD0sKwo7YSwSb7+QE2vLBrKz7oaH7LdvRjrc8/suETYOSYw134aJSyvIsxl
wB6dXf1RWB2RsAg/vTa8dpD2Pp32ZLdFI9iuQXqbnFnAXwJK6ymqZB106Usgz89P
5oY8w6L2eJxluwlWJgq8JhnYIVO6WeO1Dex/OEpguwhtj4t98vZF0i3BG8SjR42O
4+SaxxnUDqB9+sVQuYeJ5xozhysb2HI6J5xBVrZS9uYqm/5a5Q8=
=A2pW
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: