[Git][lintian/lintian][stretch-backports] 78 commits: Open new changelog entry for 2.5.121.

Chris Lamb pushed to branch stretch-backports at lintian / lintian

Commits:

174ec301
by Chris Lamb at 2019-01-07T22:35:50Z
```
Open new changelog entry for 2.5.121.
```

c31851cd

by Felix Lechner at 2019-01-08T07:45:28Z

Fix debhelper-compat-experimental test after compat upgrade. (!MR 117)

This test was recently adjusted to the new experimental debhelper
compat level, but unfortunately commit da1b7a36 also implicitly
required debhelper 13. As a result, the test never ran. The point of
the test, however, is to select the experimental level when using the
version below. The test now runs as intended.

Signed-off-by: Chris Lamb <lamby@debian.org>

95a16e01

by Felix Lechner at 2019-01-08T15:51:26Z

Fix test runtests-calibration for repeat runs.

Previous versions appended to the input file, but it breaks repeated
runs. With adaptive rebuilding, the input file is not necessarily
generated on every run. It may already contain the appended line from
a previous run. The line is then duplicated. For this test, the
solution is to replace the file.

Signed-off-by: Chris Lamb <lamby@debian.org>

d832ed5f

by Felix Lechner at 2019-01-08T15:51:33Z

Add module ScriptAge.pm to calculate the age of Perl executables.

This module traverses %INC to calculate an aggregate modification time
for Perl scripts. Unlike stat($0))[9] modules are also considered in
the calculation.

The combined modification time for a script is the newest of all of
its parts.

This change became necessary when the runner was modularized.

Signed-off-by: Chris Lamb <lamby@debian.org>

3c47d29d

by Felix Lechner at 2019-01-08T15:51:38Z

Add module StagedFileProducer.pm for adaptive building in tests.

Provides a way to define and stack file production stages that all
depend on subsets of the same group of files.

After the stages are defined, the processing engine takes an inventory
of all files in a target directory. It excludes some files, like logs,
that should not be considered.

Each stage adds its own products to the list of files to be excluded
before deciding whether to produce them. The decision is based on
relative file modification times, in addition to a systemic rebuilding
threshold. Before rebuilding, each stage asks a lower stage to make
the same determination.

The result is an engine with file production stages that depend on
successively larger sets of files.

Signed-off-by: Chris Lamb <lamby@debian.org>

8b389817

by Felix Lechner at 2019-01-08T15:51:41Z

Calculate HARNESS_EPOCH more accurately.

Uses a facility from the new module ScriptAge to calculate an age for
the harness that includes modules.

Signed-off-by: Chris Lamb <lamby@debian.org>

c336f3e3

by Felix Lechner at 2019-01-08T15:51:44Z

Export RUNNER_EPOCH to the environment.

For the current implementation, RUNNER_EPOCH equals HARNESS_EPOCH.

This is part of adaptive rebuilding for tests.

Signed-off-by: Chris Lamb <lamby@debian.org>

680bb40a

by Felix Lechner at 2019-01-08T15:51:45Z

Calculate LINTIAN_EPOCH and export to environment.

This value is used to re-run Lintian on test tags only when Lintian
has changed. It is part of adaptive rebuilding for tests.

Signed-off-by: Chris Lamb <lamby@debian.org>

e5a186b6

by Felix Lechner at 2019-01-08T15:51:48Z

Set default locale and umask in runner instead of harness.

Provides cleaner separation between test harness and test runner. May
later aid in the experimentation with other test harnesses, such as
TAP::Harness.

Signed-off-by: Chris Lamb <lamby@debian.org>

efbec6dd

by Felix Lechner at 2019-01-08T15:51:50Z

Set lowest possible mtime for files generated from templates.

Changes the file modification time for files generated from templates
to their maximum expected age.  Prevents unnecessary rebuilds when
templates are regenerated even though they have not changed.

Part of adaptive rebuilding for tests.

Signed-off-by: Chris Lamb <lamby@debian.org>

29a75bab

by Felix Lechner at 2019-01-08T15:51:51Z

Calculate oldest possible age for test data in test preparation.

Based on HARNESS_EPOCH and file modification times, calculates the age
of a test specification. Used primarily for rebuilding decisions.

The resulting date is also used to fill templates (unless overridden).
Because of this secondary use, the value is further combined with
POLICY_EPOCH to make sure an old date does not trigger a timewarp
warning. Unless a test specification is more recent, the resulting
date is the oldest permitted according to policy. This may become
unnecessary once the disjointed tags proposal (aka tags.d) is
accepted.

Part of adaptive rebuilding for tests.

Signed-off-by: Chris Lamb <lamby@debian.org>

8d47ac5e

by Felix Lechner at 2019-01-08T15:51:53Z

Calculate and announce various age thresholds in test runner.

Uses environment variables that were set up previously and file
modification times for a test specification to calculate and announce
data age, runner age, harness age and Lintian age.

Also computes a rebuilding threshold to be used when building test
packages.

Part of adaptive rebuilding for tests.

Signed-off-by: Chris Lamb <lamby@debian.org>

c446ff13

by Felix Lechner at 2019-01-08T15:51:56Z

Build tests in stages that are executed only when needed.

Uses StagedFileProducer to build tests adaptively.  The idea is that
building test packages takes a lot of time, but is not actually
necessary when only Lintian has changed, while a test specification,
runner and harness all remained the same. On one system the test suite
speeds up by a factor of 17 (when excluding 'scripts'). It should
benefit consumers of the test suite, i.e.  Lintian developers who do
not modify test runner or harness but who run tests repeatedly.

Since the layout of test working directories is still changing, please
run 'rm -f debian/test-out/' should unexpected errors occur. Please
also do so before making mission-critical assessments.

Due to the granularity of file system modification times at 1 second,
the mechanism may not work properly if changes are made, and the test
suite is run, before 1 second has elapsed. This is unlikely to affect
anyone editing Lintian checks by hand.

Implements the adaptive rebuilding strategy for tests.

Signed-off-by: Chris Lamb <lamby@debian.org>

d8f7241b

by Felix Lechner at 2019-01-08T15:51:57Z

Exclude log file from adaptive building.

The log file is the last file written in a test working directory. It
is therefore always the newest. Its young age relative to expected
build product (the Lintian subject) should not trigger a rebuild.
Excludes the log from the calculation.

This is part of adaptive rebuilding for tests.

Signed-off-by: Chris Lamb <lamby@debian.org>

fc7ca73b

by Felix Lechner at 2019-01-08T15:51:59Z

Make check_result() in test runner independent from test harness.

The function that checks the Lintian output took a harness dependent
test state as an argument. It also used a convoluted logic to make
sure that all Test-For tags were seen, and all Test-Against tags were
not. Rewrites the function to return an list of error instead, if
there are any.

Makes the test runner independent from the harness and may later aid
in the experimentation with other harnesses, such as TAP::Harness.

Signed-off-by: Chris Lamb <lamby@debian.org>

62f2d762

by Felix Lechner at 2019-01-08T15:52:01Z

Remove unused variables.

Signed-off-by: Chris Lamb <lamby@debian.org>

9f2202fc

by Chris Lamb at 2019-01-08T15:52:03Z

Apply a patch series from Felix Lechner to support adaptive rebuilding, speeding up the test test suite speeds up by a factor of 17 (excluding "scripts" tests). (MR: !118)

Signed-off-by: Chris Lamb <lamby@debian.org>

efabd83a

by Chris Lamb at 2019-01-08T18:50:04Z

Check for manual calls to dpkg-maintscript-helper(1) in maintainer scripts. (Closes: #917567)

26bfa6c7

by Chris Lamb at 2019-01-08T19:25:35Z

Fix symbols-file-missing-build-depends-package-field false-positives when a package contains more than one library. (Closes: #918473)

697d353c

by Mo Zhou at 2019-01-09T12:46:55Z

data/scripts/interpreters: Fix the julia interpreter path.

Signed-off-by: Chris Lamb <lamby@debian.org>

26805519

by Felix Lechner at 2019-01-09T12:51:39Z

Run code quality scripts through TAP::Harness instead of 'prove'.

Calling 'prove' to run code quality tests makes it too easy to
overlook results when subsequent outputs follow. With TAP::Harness all
tests become part of the same test summary at the bottom (less
scrolling).

Internal harness tests will be added shortly.

The output may be slightly different compared to 'prove'.

Signed-off-by: Chris Lamb <lamby@debian.org>

0d31bec4

by Felix Lechner at 2019-01-09T12:51:55Z

t/harness: Add four internal tests for harness consistency.

Currently, four tests ensure the following functionality:

* check-result.t: Match algorithm for Lintian tags works as expected.
* logged-prepare.t: Default values in work directories are correct.
* no-watch-file-in-native.t: No watch file in native template.
* watch-file-in-non-native.t: Watch file in non-native template.

More internal tests may be added in the future. This may also be a
good place to test other critical or fragile components in Lintian
proper.

Signed-off-by: Chris Lamb <lamby@debian.org>

152a1655

by Felix Lechner at 2019-01-09T12:52:01Z

Always run internal harness tests regardless of user selection.

Internal harness tests ensure the consistency of test results. They
cannot be deactivated; they run every time.

Signed-off-by: Chris Lamb <lamby@debian.org>

9a4fd71f

by Felix Lechner at 2019-01-09T12:52:07Z

Give a quick usage hint when no tests were selected.

Adds a small notification when the 'onlyrun' command line option was
used but no tests where selected. The message explains the basic
usage of the 'onlyrun' option.

Signed-off-by: Chris Lamb <lamby@debian.org>

f52b08f3

by Felix Lechner at 2019-01-09T12:52:18Z

Add documentation about internal harness tests to README for tests.

This behavior may change in the future, when 'harness' may become a
suite.

Signed-off-by: Chris Lamb <lamby@debian.org>

1c67befb

by Felix Lechner at 2019-01-09T12:52:22Z

Remove reference to sequence numbers in README for tests.

Sequence numbers have not been required for some time. The reference
was removed.

Signed-off-by: Chris Lamb <lamby@debian.org>

8ee72cd3

by Chris Lamb at 2019-01-09T12:52:25Z

Apply a patch series from Felix Lechner to add a number of "internal" tests for the test apparatus itself. (MR: !119)

5d1ae533
by Chris Lamb at 2019-01-09T14:22:59Z
```
Grumpy lamby.
```

5cb9317f

by Chris Lamb at 2019-01-09T14:23:52Z

Check for packages that have maintainer scripts that ship support code for legacy versions of Debian. (Closes: #917566)

b037521b

by Chris Lamb at 2019-01-09T14:58:29Z

Correct older changelog entry; the recommended levels were set to 11 and 12.

1d8eac0a

by Chris Lamb at 2019-01-09T15:03:05Z

Don't emit a pedantic warning for compat level 12 until bullseye.  (Closes: #918809)

9482ccb4

by Chris Lamb at 2019-01-09T15:08:27Z

Appease perlcritic by using underscores in long number.

678561dd

by Chris Lamb at 2019-01-09T15:51:02Z

Re-instate older changelog entry; the levels were set to 12 and 13. Kinda.

This reverts commit b037521b1506c75140cb440cff7e02d9b6914482.

a6bd61f4

by Felix Lechner at 2019-01-09T15:52:56Z

Exit with non-zero when test fails in TAP::Harness. (re. #918817)

This should more or less restore the exit code behavior from before
commit 26805519.

Signed-off-by: Chris Lamb <lamby@debian.org>

6ffd137a

by Felix Lechner at 2019-01-10T08:53:26Z

Use paths in test queue (instead of testcase data structure).

Use file paths to test specification directories to identify tests in
the run queue. It is more portable between harnesses and a
prerequisite to using TAP::Harness for the package tests.

Introduces a small change in the output format, but only for the
summary. For skipped tests, the suite is now part of the line for each
test.

Signed-off-by: Chris Lamb <lamby@debian.org>

a296bbd6

by Felix Lechner at 2019-01-10T08:53:28Z

Use relative paths as process labels instead of suite::testname.

The most portable way to refer to tests is by their paths.  In
addition, the concept of 'suite' for Lintian tests will change
considerably in the near future.  Changes the process label for each
test from ${suite}::${testname} to the relative path to the test
directory.

This changes the output format considerably and may take some time to
get used to. As a positive, the output very much resembles 'prove' or
TAP::Harness and may thus be familiar from other Perl contexts.

Signed-off-by: Chris Lamb <lamby@debian.org>

52d76fc9

by Felix Lechner at 2019-01-10T08:53:29Z

Split test preparation from test runner.

Harnesses are generally better at executing tests than at preparing
test material. Due to the complexity of many Lintian tests, the two
stages are better split.

TAP::Harness may take over the running of the tests. The test
preparation, on the other hand, will continue to run in parallel using
IO::Async::Routing and a setup very much like the existing test
runner. Now it just has its own event loop.

Signed-off-by: Chris Lamb <lamby@debian.org>

0592e05a

by Felix Lechner at 2019-01-10T08:53:31Z

Clean up process messaging in test runner.

Simplifies the logic for process messaging in Test::State and
elsewhere. The key is to issue multiple commands in the worker threads
when changing a test's status. That may not be atomic, but the most
unpleasant consequence should be messages out of sequence. None were
observed so far.

Signed-off-by: Chris Lamb <lamby@debian.org>

8707bed2

by Chris Lamb at 2019-01-10T08:54:17Z

 Apply a patch series from Felix Lechner to split the preparation of tests from the test runner itself. (MR: !122)

ec536787
by Chris Lamb at 2019-01-10T08:58:11Z
```
Fix duplicate word in changelog.
```

b2a48bde

by Felix Lechner at 2019-01-10T15:16:05Z

Send an explicit reference to string when using IO::Async::Channel. (!MR: 123)

A recent commit series to split the test preparation from the test runner
causes the following error:

    not a reference at /usr/share/perl5/IO/Async/Channel.pm line 197.

The problem was likely added in commit 6ffd137a. This now passes (and
also resolves) an explicit reference to the path that identifies each
test.

Signed-off-by: Chris Lamb <lamby@debian.org>

f6ef65e6
by Chris Lamb at 2019-01-10T22:09:42Z
```
Fix tests for debhelper downgrade.
```

470069e2

by Chris Lamb at 2019-01-10T22:09:42Z

Update tests to reflect new dpkg-maintscript-helper warning.

aa2ef273
by Chris Lamb at 2019-01-10T22:09:42Z
```
Release lintian/2.5.121 into unstable.
```
cffde5dd
by Chris Lamb at 2019-01-10T22:24:17Z
```
Open new changelog entry for 2.5.122.
```
4c2b7a48
by Paul Wise at 2019-01-10T23:21:18Z
```
spelling: Add several corrections
```
8b9291c2
by Chris Lamb at 2019-01-11T10:32:51Z
```
Lets try using "gbp dch" this release.
```

4966be69