Bug#947052: lintian: Add check for binNMU changelog entries in source packages

[Guillem Jover <guillem@debian.org>]

Hi!

On Thu, 2019-12-19 at 19:07:04 -0800, Felix Lechner wrote:
> On Thu, Dec 19, 2019 at 6:51 PM Guillem Jover <guillem@debian.org> wrote:
> > I've already noticed at least two instances of maintainers fixing email
> > addresses due to debian-changelog-file-contains-invalid-email-address,
> > for binNMU entries in debian/changelog's in source packages.
> >
> > So it seems counterproductive to emit the above tag, when these
> > entries should instead be removed. :)

> Just to clarify
> Is this what you want me to do?

I'd change your algo a bit like this:

> for all changelog entries:
if version is binNMU and (is latest or previous is binNMU),
  ignore
if version is binNMU and previous is not binNMU,
>     tell user to delete entry
> if version does not indicate binNMU,
>     check email address for validity.

Otherwise, yes!

Thanks,
Guillem