[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#941774: marked as done (lintian: False positive for symbols-file-contains-current-version-with-debian-revision)

Your message dated Sat, 14 Dec 2019 14:24:40 -0800
with message-id <CAFHYt57Q6kTTuuWS2A1i3ug3n5tfNLpOmf0TG9S7DGnHJn7Qug@mail.gmail.com>
and subject line Re: Bug#941774: lintian: False positive for symbols-file-contains-current-version-with-debian-revision
has caused the Debian Bug report #941774,
regarding lintian: False positive for symbols-file-contains-current-version-with-debian-revision
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
941774: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=941774
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.24.0
Severity: normal

The current version of lintian on lintian.d.o generates false positives
for this test.  See https://lintian.debian.org/maintainer/scott@kitterman.com.html#libnitrokey
for an example.  The line in the symbols file that's referenced for
libnitrokey 3.5-1 is:

 (optional=templinst|arch=!amd64 !arm64 !x32)_ZN8nitrokey5proto17ResponseDissectorILNS0_9CommandIDE0ERKNS0_14DeviceResponseILS2_0ENS0_7stick109GetStatus15ResponsePayloadEEEE24status_translate_commandB5cxx11Ei@Base 3.5

 No dash anywhere.  In fact, in only dashes in the entire symbols file
 are in the first three lines of the file:

 # SymbolsHelper-Confirmed: 3.5 alpha amd64 arm64 armel armhf hppa i386 ia64 m68k mips64el mipsel powerpc ppc64 ppc64el riscv64 s390x sh4 sparc64 x32
libnitrokey.so.3 libnitrokey3 #MINVER#
* Build-Depends-Package: libnitrokey-dev

This appears to be a regression from 2.15.0 as when I run lintian
locally on a stable system, this error is not shown.  This is
superficially similar to #539066, but is a distinct problem not related
to the upstream version number.

Scott K

--- End Message ---
--- Begin Message --- 
Hi Scott,

On Fri, Oct 4, 2019 at 11:33 PM Scott Kitterman <debian@kitterman.com> wrote:
>
>  No dash anywhere.

The symbols file in the control section of
libnitrokey3_3.4.1-4+b1_amd64.deb contains the following lines:

$ fgrep -- -4 dir/symbols
 _ZN8nitrokey5proto14QueryDissectorILNS0_9CommandIDE1ERKNS0_9HIDReportILS2_1ENS0_7stick1015WriteToTOTPSlot14CommandPayloadEEEE7dissectB5cxx11ES9_@Base
3.4.1-4+b1
 _ZNSt6vectorIhSaIhEE17_M_realloc_insertIJhEEEvN9__gnu_cxx17__normal_iteratorIPhS1_EEDpOT_@Base
3.4.1-4+b1

Those two symbols show Debian revisions. Lintian is right.

As far as I can tell, that matches Lintian's output. The rate limit on
shared symbols cannot currently be turned off.

$ frontend/lintian --no-tag-display-limit
../bugs/symbols/libnitrokey3_3.4.1-4+b1_amd64.deb
E: libnitrokey3:
symbols-file-contains-current-version-with-debian-revision on symbol
_ZN8nitrokey5proto14QueryDissectorILNS0_9CommandIDE1ERKNS0_9HIDReportILS2_1ENS0_7stick1015WriteToTOTPSlot14CommandPayloadEEEE7dissectB5cxx11ES9_@Base
and 1 others
I: libnitrokey3: spelling-error-in-binary
usr/lib/x86_64-linux-gnu/libnitrokey.so.3.4.1 pacH patch

I am not sure why some symbols were decoded properly using the
appropriate pattern [1], while the offender is raw 'c++'. Did you mix
C and C++ symbols in the same shared library?

Closing this bug. Please reopen if you think that I made a mistake.

Kind regards
Felix Lechner

[1] https://wiki.debian.org/UsingSymbolsFiles

--- End Message ---
Reply to: