[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#848825: marked as done (lintian: Does not apply source-is-missing overrides unless path has wildcard)

Your message dated Sat, 14 Dec 2019 09:16:47 -0800
with message-id <CAFHYt54S+qDgpX2e2BN5r_XweEq42HvQL9HzHAwfh9XH0aYO_A@mail.gmail.com>
and subject line Overrides behave as intended
has caused the Debian Bug report #848825,
regarding lintian: Does not apply source-is-missing overrides unless path has wildcard
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
848825: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848825
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.5.49
Severity: normal

This doesn't override anything:

source/lintian-overrides
source-is-missing deps/v8/benchmarks/regexp.js
source-is-missing doc/api_assets/sh_javascript.min.js
source-is-missing test/fixtures/throws_error5.js
source-is-missing test/fixtures/throws_error6.js

and it lists those overrides as unused.

This does work as intended:
source/lintian-overrides
source-is-missing deps/v8/benchmarks/regexp.js*
source-is-missing doc/api_assets/sh_javascript.min.js*
source-is-missing test/fixtures/throws_error5.js*
source-is-missing test/fixtures/throws_error6.js*

Cheers,

Jérémy.


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.8.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils                          2.27.51.20161212-1
ii  bzip2                             1.0.6-8
ii  diffstat                          1.61-1
ii  file                              1:5.29-2
ii  gettext                           0.19.8.1-1
ii  intltool-debian                   0.35.0+20060710.4
ii  libapt-pkg-perl                   0.1.30
ii  libarchive-zip-perl               1.59-1
ii  libclass-accessor-perl            0.34-1
ii  libclone-perl                     0.38-2+b1
ii  libdpkg-perl                      1.18.17
ii  libemail-valid-perl               1.202-1
ii  libfile-basedir-perl              0.07-1
ii  libipc-run-perl                   0.94-1
ii  liblist-moreutils-perl            0.416-1+b1
ii  libparse-debianchangelog-perl     1.2.0-12
ii  libperl5.24 [libdigest-sha-perl]  5.24.1~rc4-1
ii  libtext-levenshtein-perl          0.13-1
ii  libtimedate-perl                  2.3000-2
ii  liburi-perl                       1.71-1
ii  libyaml-libyaml-perl              0.63-1+b1
ii  man-db                            2.7.6.1-2
ii  patchutils                        0.3.4-2
ii  perl                              5.24.1~rc4-1
ii  t1utils                           1.39-2
ii  xz-utils                          5.2.2-1.2

Versions of packages lintian recommends:
ii  dpkg                                 1.18.17
ii  libautodie-perl                      2.29-2
ii  libperlio-gzip-perl                  0.19-1+b2
ii  perl                                 5.24.1~rc4-1
ii  perl-modules-5.24 [libautodie-perl]  5.24.1~rc4-1

Versions of packages lintian suggests:
ii  binutils-multiarch     2.27.51.20161212-1
ii  dpkg-dev               1.18.17
ii  libhtml-parser-perl    3.72-3
ii  libtext-template-perl  1.46-1

-- no debconf information

--- End Message ---
--- Begin Message --- 
Control: tags -1 + wontfix

Hi Jérémy,

> This doesn't override anything:

As far as I can tell from looking at nodejs_10.17.0~dfsg-2.dsc, the
overrides behave as intended.

Some tags of the type 'source-is-missing' (but not all) include
additional information. That usually happens for more generic tags,
for example those for spelling. Overrides must distinguish those
different instances and therefore require the additional information
in the override. In the present case they did not.

As you pointed out, the override file works because of the asterisks:

$ more nodejs-10.17.0~dfsg/debian/source/lintian-overrides
# false positives
source-is-missing test/fixtures/assert-long-line*
source-is-missing deps/v8/benchmarks/regexp*
source-is-missing test/fixtures/throws_error*
# removed and restored as a patch, false positive
source-is-missing doc/api_assets/sh_javascript.min.js

For the last tag, Lintian issues no additional details, and the
override takes as intended. The overrides were already adjusted, so I
will close this bug.

For the record, here is a partial Lintian output:

N: false positives
O: nodejs source: source-is-missing deps/v8/benchmarks/regexp.js line
length is 2305 characters (>512)
N: removed and restored as a patch, false positive
O: nodejs source: source-is-missing doc/api_assets/sh_javascript.min.js
N: false positives
O: nodejs source: source-is-missing test/fixtures/assert-long-line.js
line length is 9419 characters (>512)
N: false positives
O: nodejs source: source-is-missing test/fixtures/throws_error5.js
line length is 516 characters (>512)
N: false positives
O: nodejs source: source-is-missing test/fixtures/throws_error6.js
line length is 1029 characters (>512)

If you have not already done so, please file additional bugs for the
claims that you encountered false positives. The relevant code is
older and may need some attention.

I did, however, look briefly at the patch that restores
doc/api_assets/sh_javascript.min.js. I am not sure that it is a false
positive. Lintian checks the patched tree, not the upstream sources.
The tag is issued against the file created by the patch.

Kind regards
Felix Lechner

--- End Message ---
Reply to: