-
20af2d8a
by Chris Lamb
at 2019-10-02T09:16:27Z
Open new changelog entry.
Gbp-Dch: ignore
-
9017bd21
by Felix Lechner
at 2019-10-03T15:19:43Z
Split Lintian::Check into Lintian::Maintainer and Lintian::Spelling to clean up the module name space.
This part of the module name space is needed for a Moo::Role covering
all Lintian checks.
Gbp-Dch: ignore
-
155cf8a4
by Felix Lechner
at 2019-10-03T15:21:03Z
Use the split out modules Lintian::Spelling and Lintian::Maintainer in checks.
This split was necessary to clean up the module name space. In the
near future, Lintian::Check will hold a Moo::Role covering all checks.
Gbp-Dch: ignore
-
fe23dc71
by Felix Lechner
at 2019-10-03T16:42:00Z
Also use renamed Lintian::Spelling in Lintian::Test.
The caller refers to a module that was split up and renamed.
For some reason, tests had completed locally without this required change.
Gbp-Dch: ignore
-
185acd34
by Felix Lechner
at 2019-10-03T18:10:18Z
Use new module names in two other places.
The code seems to load older installed version even when testing an
in-tree version of Lintian. The tests completed fine locally but
failed in Gitlab.
Gbp-Dch: ignore
-
90a0329b
by Felix Lechner
at 2019-10-03T19:06:39Z
Use new module names in one more places.
The code seems to load older installed version even when testing an
in-tree version of Lintian and my grepping techniques are deficient.
The tests completed fine locally but failed in Gitlab.
Gbp-Dch: ignore
-
fa1f3e2c
by Felix Lechner
at 2019-10-04T00:16:16Z
Add Moo::Role for Lintian checks.
This is a preparation to instantiate all checks as Moo objects. It is
ultimately expected to bring a number of benefits, such as a reduction
in global variables, easier post-processing of issued tags, and
additional facilities that make it easier to write Lintian checks.
Gbp-Dch: ignore
-
6bdcfc1c
by Felix Lechner
at 2019-10-04T00:20:43Z
Optionally instantiate Lintian checks as objects if they implement the role Lintian::Check.
All checks will gradually be converted to the new format. For now, it
remains optional.
Checks in dependent projects, such as pkg-perl-tools and pkg-js-tools
will ultimately be asked to convert the profiles to the new format. It
is currently still in development.
Gbp-Dch: ignore
-
b51f01c1
by Felix Lechner
at 2019-10-04T00:44:08Z
Convert all checks to instantiated objects using the role Lintian::Check.
It is ultimately expected to bring a number of benefits, such as a
reduction in global variables, easier post-processing of issued tags,
and additional facilities that make it easier to write Lintian checks.
Uses the new Moo-based facility in all checks that ship with Lintian.
-
983624ce
by Felix Lechner
at 2019-10-04T23:09:58Z
When testing checks, refine test for old entry point.
The new role Lintian::Check provides a run methods that may be
misidentified as the old function call 'run' that was previously used
in checks. Refines the check to find only the old applications.
Also removes the 'return' statement to look at all checks. Previously,
only the first offending check was shown.
Gbp-Dch: ignore
-
1a1399bb
by Chris Lamb
at 2019-10-09T20:25:47Z
Correct/improve grammar of the non-consecutive-debian-revision long description.
-
3c80d61f
by Chris Lamb
at 2019-10-09T20:30:17Z
Avoid false-positives in non-consecutive-debian-revision by only performing the test when Debian revisions (eg. -2, -3, etc.) are whole integers. (Closes: #941395, #942013)
-
4ec5b201
by Chris Lamb
at 2019-10-09T21:20:13Z
Correct reference to $latest.
Gbp-Dch: ignore
-
b9ad43d0
by Chris Lamb
at 2019-10-09T23:45:55Z
Correct metadata of non-consecutive-debian-revision tag emissions incorrectly/accidentally changed in 3c80d61fb243732b5c438f1cb38c22f15d95f405.
Gbp-Dch: ignore
-
f19a3bfa
by Chris Lamb
at 2019-10-09T23:51:27Z
Release lintian/2.26.0 into unstable.
-
a5d55e3b
by Chris Lamb
at 2019-10-10T00:19:32Z
Open new changelog entry.
Gbp-Dch: ignore
-
bfbd1880
by Chris Lamb
at 2019-10-10T00:20:24Z
Update data/fields/perl-provides.
-
753ba454
by Chris Lamb
at 2019-10-11T19:25:52Z
Don't warn about package-supports-alternative-init-but-no-init.d-script and systemd-service-file-missing-install-key and for units installed in a subdirectory of (for example) /lib/systemd/system. (Closes: #941419)
-
69bcb2ef
by Felix Lechner
at 2019-10-12T14:42:56Z
Improve error message when profile refers to unknown check.
Gbp-Dch: ignore
-
91e2d8d5
by Felix Lechner
at 2019-10-12T14:43:01Z
Add editing aid section to all Perl files that do not have it, except in tests.
Adds the following block to end of all Perl files, except for a few
modules that appear to be part of test cases:
# Local Variables:
# indent-tabs-mode: nil
# cperl-indent-level: 4
# End:
# vim: syntax=perl sw=4 sts=4 sr et
These local variables are already present in most source files. They
make editing much easier because then most identations automatically
comply with perltidy's requirements.
-
e7eaef23
by Felix Lechner
at 2019-10-13T05:35:32Z
Associate tags with new subchecks for original check 'fields'.
In the near future, the subchecks of 'fields' will stand on their own.
They will no longer be invoked from inside the old check.
This associates the tags emitted by each subcheck with that subcheck.
The split was easy except for maintainer and uploaders, which are
somewhat awkwardly issued by a library module. (There are many
similarities in the way they are processed.) A better way would be for
the library to evaluate the fields, but for the checks to issue their
own tags.
-
e99c4e82
by Felix Lechner
at 2019-10-13T05:39:57Z
Make subchecks of 'fields' stand on their own.
Created '*.desc' files for the subchecks so that Lintian recognizes
them as checks that stand on their own.
These checks were previously invoked via the main check. The main
check will be removed in the near future.
-
05777588
by Felix Lechner
at 2019-10-13T05:41:22Z
Remove old check 'fields', which only called subchecks.
The constituent checks now stand on their own. The old module that
used to call them is no longer needed. It is removed here.
Gbp-Dch: ignore
-
2a4e9519
by Felix Lechner
at 2019-10-13T06:14:04Z
Add to profile debian/main the new checks split from 'fields'; remove 'fields'.
Removes the old check 'fields' from the profile debian/main. Adds the
subcheck, which now stand on their own, to the profile instead.
-
29c15bab
by Felix Lechner
at 2019-10-13T06:14:26Z
Split tests and sort them into the appropriate subchecks for the old check 'fields'.
Tests were copied or duplicated as needed whenever it helped to
evaluate a subcheck. The two scenarios were either that the expected
tags or the tags listed in Test-Against related to the subcheck.
One exception was the test fields-depends-wildcard, which had neither
expected any tags nor defined a Test-Against. Upon examination, that
test was added to the check 'fields/package-relations' with
appropriate settings in Test-Against.
Splits all tests for the old check 'fields' into the subtests so they
can stand on their own.
Gbp-Dch: ignore
-
8d7266b1
by Felix Lechner
at 2019-10-13T06:14:26Z
Adjust literal tests for new tag output order.
In Lintian's output, tags appear in the order they are emitted.
Adjusts literal tests for changes is check execution order.
This commit contains no substantive changes.
Gbp-Dch: ignore
-
33508343
by Felix Lechner
at 2019-10-13T21:09:57Z
In tests, load profiles only from one location; make sure one is loaded in pod-syposis.t. (May fix #942252)
Some test scripts appear to load old profiles. They are presumably
located in the installed location /usr/share/lintian. The errors
depend on the version difference between what is installed and what is
under test. That is probably why the reported bug does not show up in
Gitlab (anymore).
This commit does two things: (1) It unambiguously uses only one
include path when finding profiles, and (2) makes sure a profile is
loaded in the test pod-synopsis.t that fails in the bug report.
This commit is an attempt to resolve Bug#942252. It causes no
breakage, but the bug did never appeared locally. If it works, the bug
report should be closed manually.
-
dccf2351
by Felix Lechner
at 2019-10-14T03:35:18Z
Remove unused import.
Gbp-Dch: ignore
-
104baa6a
by Felix Lechner
at 2019-10-14T03:35:28Z
In test runner, use [% and %] as delimiters for Text::Template.
The standard delimiter setting in Text::Template is curly braces. They
have several disadvantages. Changes the configuration of the module in
tests (but not in reports) to [% and %].
The new setting is the default for Template::Toolkit, which we may use
in the future. For now, we continue to use Text::Template.
The biggest disadvantage of the curly braces is that variables in
Debian control files, such as ${misc:Depends}, must be escaped. The
resulting backslashes are cumbersome, visually unattractive, and error
prone.
Another disadvantage may be speed, although probably not paramount for
our application. The module's author wrote:
"Because the parsing of templates is simplified by the absence of
backslash escapes, using alternative DELIMITERS may speed up the
parsing process by 20-25%. This shows that my original choice of
{ and } was very bad."
This sets the programmatic delimiters for template substitutions in
the test runner. Subsequent commits will actually change the
templates.
The reporting framework also uses Text::Template but is not affected.
-
dcc08fdc
by Felix Lechner
at 2019-10-14T03:36:53Z
In defaults, use [% and %] as delimiters for Text::Template.
The standard delimiter setting in Text::Template is curly braces. They
have several disadvantages. Changes the delimiter in the defaults for
the test suite to [% and %].
The new setting is the default for Template::Toolkit, which we may use
in the future. For now, we continue to use Text::Template.
The biggest disadvantage of the curly braces is that variables in
Debian control files, such as ${misc:Depends}, must be escaped. The
resulting backslashes are cumbersome, visually unattractive, and error
prone.
Another disadvantage may be speed, although probably not paramount for
our application. The module's author wrote:
"Because the parsing of templates is simplified by the absence of
backslash escapes, using alternative DELIMITERS may speed up the
parsing process by 20-25%. This shows that my original choice of
{ and } was very bad."
This replaces the delimiters for template substitutions in the
defaults for the test suite.
Gbp-Dch: ignore
-
02c23f0d
by Felix Lechner
at 2019-10-14T03:38:11Z
In templates, use [% and %] as delimiters for Text::Template.
The standard delimiter setting in Text::Template is curly braces. They
have several disadvantages. Changes the delimiters in templates used
in the test suite.
The new setting is the default for Template::Toolkit, which we may use
in the future. For now, we continue to use Text::Template.
The biggest disadvantage of the curly braces is that variables in
Debian control files, such as ${misc:Depends}, must be escaped. The
resulting backslashes are cumbersome, visually unattractive, and error
prone.
Another disadvantage may be speed, although probably not paramount for
our application. The module's author wrote:
"Because the parsing of templates is simplified by the absence of
backslash escapes, using alternative DELIMITERS may speed up the
parsing process by 20-25%. This shows that my original choice of
{ and } was very bad."
This replaces the delimiters for template substitutions in the
templates for the test framework.
Gbp-Dch: ignore
-
377f1606
by Felix Lechner
at 2019-10-14T03:40:13Z
In templates, remove the escaping backslashes before curly braces.
The escape characters are no longer needed. We now use [% and %] as
delimiters for template substitutions in the test suite.
Gbp-Dch: ignore
-
d971f5e6
by Felix Lechner
at 2019-10-14T03:40:28Z
In tests, use [% and %] as delimiters for Text::Template.
The standard delimiter setting in Text::Template is curly braces. They
have several disadvantages. Changes the delimiters in all test
specifications.
The new setting is the default for Template::Toolkit, which we may use
in the future. For now, we continue to use Text::Template.
The biggest disadvantage of the curly braces is that variables in
Debian control files, such as ${misc:Depends}, must be escaped. The
resulting backslashes are cumbersome, visually unattractive, and error
prone.
Another disadvantage may be speed, although probably not paramount for
our application. The module's author wrote:
"Because the parsing of templates is simplified by the absence of
backslash escapes, using alternative DELIMITERS may speed up the
parsing process by 20-25%. This shows that my original choice of
{ and } was very bad."
This replaces the delimiters for template substitutions in Lintian's
test specifications.
The reporting framework also uses Text::Template but is not affected.
-
f1b0d6c0
by Felix Lechner
at 2019-10-14T03:40:33Z
In tests, remove the escaping backslashes before curly braces.
The escape characters are no longer needed. We now use [% and %] as
delimiters for template substitutions in the test suite.
-
814c2646
by Chris Lamb
at 2019-10-14T17:40:35Z
Refresh data/fields/perl-provides.
-
ad231c89
by Chris Lamb
at 2019-10-14T17:40:35Z
Release lintian/2.27.0 into unstable.
-
4c8b9a4e
by Chris Lamb
at 2019-10-17T16:53:11Z
Rebuild for stretch-backports.