--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: lintian: false positive package-supports-alternative-init-but-no-init.d-script if systemd unit is statically enabled
- From: Simon McVittie <smcv@debian.org>
- Date: Mon, 30 Sep 2019 13:03:52 +0100
- Message-id: <20190930120352.GA19831@espresso.pseudorandom.co.uk>
Package: lintian
Version: 2.24.0
Severity: minor
Steps to reproduce
------------------
Run lintian against a package like dbus that:
1) statically enables a systemd unit, i.e. installs a symbolic link
/lib/systemd/system/multi-user.target.wants/dbus.service ->
../dbus.service
2) has a corresponding LSB init script /etc/init.d/dbus
(This is unusual and special, but a few packages that are entangled with
systemd, or more generally, with system boot - such as dbus, plymouth,
and systemd itself - legitimately do this.)
Expected result
---------------
lintian warns me about systemd-service-file-missing-install-key (unless I
override it, which I do in dbus). As I said, this is an unusual situation,
so I'm OK with this being something I'm expected to override.
lintian does not warn me about
package-supports-alternative-init-but-no-init.d-script (sic), because I have
a corresponding LSB init script.
(Side note: the name of the tag is misleading now that systemd is the
default; I don't think we can really claim that our default init system
is an "alternative" any more. However, I realise Policy has the same bug.)
Actual result
-------------
I get warned about systemd-service-file-missing-install-key twice:
once for /lib/systemd/system/dbus.service (as expected), and once for
/lib/systemd/system/multi-user.target.wants/dbus.service (not necessarily
desired, and might point towards the nature of this bug).
I also get warned about
package-supports-alternative-init-but-no-init.d-script for
/lib/systemd/system/multi-user.target.wants/dbus.service. This is
just not true: the closest LSB equivalent, /etc/init.d/dbus, does
exist. Perhaps Lintian mistakenly thinks it should be looking for
/etc/init.d/multi-user.target.wants/dbus?
Suggested solution
------------------
If a symlink to a systemd unit appears in a directory in the search path
(/etc/systemd/system, /lib/systemd/system, possibly others), consider it
for analysis as usual.
If a symlink to a systemd unit appears in *a subdirectory of* a directory
in the search path (/etc/systemd/system/multi-user.target.wants,
/lib/systemd/system/sysinit.target.requires, many others), do not
analyze it as though it was a systemd unit in its own right.
Thanks,
smcv
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'stable-debug'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.2.0-3-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages lintian depends on:
ii binutils 2.32.51.20190909-1
ii bzip2 1.0.8-2
ii diffstat 1.62-1+b1
ii dpkg 1.19.7
ii dpkg-dev 1.19.7
ii file 1:5.37-5
ii gettext 0.19.8.1-9
ii gpg 2.2.17-3
ii intltool-debian 0.35.0+20060710.5
ii libapt-pkg-perl 0.1.36+b1
ii libarchive-zip-perl 1.66-2
ii libcapture-tiny-perl 0.48-1
ii libcgi-pm-perl 4.44-1
ii libclass-accessor-perl 0.51-1
ii libclone-perl 0.41-1+b1
ii libdpkg-perl 1.19.7
ii libemail-valid-perl 1.202-1
ii libfile-basedir-perl 0.08-1
ii libfile-find-rule-perl 0.34-1
ii libio-async-loop-epoll-perl 0.20-1
ii libio-async-perl 0.74-1
ii libipc-run-perl 20180523.0-1
ii liblist-compare-perl 0.53-1
ii liblist-moreutils-perl 0.416-1+b4
ii libmoo-perl 2.003004-2
ii libpath-tiny-perl 0.108-1
ii libtext-levenshtein-perl 0.13-1
ii libtimedate-perl 2.3000-2
ii libtry-tiny-perl 0.30-1
ii libtype-tiny-perl 1.004004-1
ii liburi-perl 1.76-1
ii libxml-simple-perl 2.25-1
ii libyaml-libyaml-perl 0.80+repack-2
ii man-db 2.8.7-3
ii patchutils 0.3.4-2+b1
ii perl [libdigest-sha-perl] 5.28.1-6
ii t1utils 1.41-3
ii xz-utils 5.2.4-1+b1
Versions of packages lintian recommends:
ii libperlio-gzip-perl 0.19-1+b5
Versions of packages lintian suggests:
ii binutils-multiarch 2.32.51.20190909-1
ii libhtml-parser-perl 3.72-3+b3
ii libtext-template-perl 1.55-1
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.27.0
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 941419@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 13 Oct 2019 22:27:26 +0000
Source: lintian
Architecture: source
Version: 2.27.0
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 941419 942252
Changes:
lintian (2.27.0) unstable; urgency=medium
.
[ Chris Lamb]
* Don't warn about package-supports-alternative-init-but-no-init.d-script
and systemd-service-file-missing-install-key and for units installed in
a subdirectory of (for example) /lib/systemd/system. (Closes: #941419)
* Update data/fields/perl-provides.
.
[ Felix Lechner ]
* In the tests, load profiles only from one location, ensuring one is
loaded in pod-syposis.t. (Closes: #942252)
* Make subchecks of 'fields' stand on their own:
- Associate tags with new subchecks for original check 'fields'.
- Add to the debian/main profile the new checks split from 'fields'.
* Add editing aid section to all Perl files that do not have it, except
in tests.
Checksums-Sha1:
baa04f208cd7b510a6b93273f5cd7e5346215408 3920 lintian_2.27.0.dsc
51612a6bf65f1c519f3b73792a57120bec4add2a 1771976 lintian_2.27.0.tar.xz
729c3ca64c3c11e6fbcc04a4d25214f183b1a455 16537 lintian_2.27.0_amd64.buildinfo
Checksums-Sha256:
13f506e06ead7d33410523698f1b2f74df3bfb13d9e99104376b048a41b5afca 3920 lintian_2.27.0.dsc
50072ffa6d77fc155b708c6d83fbc54b293a569f56360df1fb21fa0901a14159 1771976 lintian_2.27.0.tar.xz
9976485757d07158ba4d33c34c0994adcaad9f267f06a6ff613c0e79293c7182 16537 lintian_2.27.0_amd64.buildinfo
Files:
cc6c6a7257a16024e4c7ffc04afc3501 3920 devel optional lintian_2.27.0.dsc
08b63d69e8a2aca0e65b6f7c8f55a374 1771976 devel optional lintian_2.27.0.tar.xz
f99cde9e246b38b9dc654833885af12d 16537 devel optional lintian_2.27.0_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl2kt8wACgkQHpU+J9Qx
HljmtRAAoN4B6sc2ghC/YWuPkwVkoSQkQ1fSVf9lJv+ZzS0V4M2MBNY5iCf1ZSKA
5f52QAGTDN2INvGnfJsGTlY1dvPrLNI6Dq4pfMZam480al608ZnKUMvnMvr3m/i1
03hJa0og3L5w+uKSAWIGyS9fCjzSSBT7JiwKuTuHFAP9+HNY4BAy1u9Alzl/61E6
TQtucov1bwX9Jal2uAi9dP6SOpOH3mCRsH5QCHIyrVFU6mPuchHFr1U8BwyYtvGB
JkFelz2UyofwJgCaOvnO5ygSN2sz3FahnlVAQL3OrkNlq0UBWZmBLOczDd2Ka5N7
1dsPW5KXjaNQ7VCWN2grQutUSJmlrbIGigmKoKKiNkDYhH3BJZ4xU8NZifdIsrqW
Wjvf0nfAiZBgPcrCjJoWo9DyMe0+zumwVmqCZQ3K9/6vWkT1ZmFChlvf0WI8+NEO
DzGhBU7oIFodSRGWAICjKk21vQLO/UtO2LBbHSNjT0nazlV8s5npGcxfiA/jVtBv
LB8wzAJa5ytsvaCmmFNyQgmT9vY76L2387eShMYO8ZKpbtL3GpApfVHTO5NJmR43
shBTLFB90KXMraIy1PiR3ELm4jA6c0E2SBbWjAMdHTm3aKwQzXeU44W8X6CQ7wjK
hSyqntU067v+2oNZm9HxeKMN6UfgPriNaPYHhEoVnDySakiv0Qo=
=/9zz
-----END PGP SIGNATURE-----
--- End Message ---