-
e00fde12
by Felix Lechner
at 2019-02-07T15:45:31Z
Demote the Test-Against test metadata field to be a selector for false-positives only. (MR: !142)
The field Test-Against used to have two functions. First, it would
help the harness determine which tests should be run when a tag was
selected. The second function was to generate errors when those tags
were present in the output.
The test suite calculates Test-Against automatically from Check and
'tags'. To preserve old behavior, Test-Against was allowed to override
the calculated value. As it turns out, that has dangerous side effects
when unrelated tags are ignored (a coming feature). The override
capability has been disabled.
Test-Against is now used only for the first purpose, which is to
select tests when running for a particular tag. Its only function is
to limit the tests that are run beyond those in which the tag does not
appear (but which belong to Check). Test-Against is thus just an
identifier for tests against false positives. Its use is expected to
fade, and eventually be obsolete, as broad checks become more narrow.
The danger of the override occurs when exact matching of tags is
turned off. This is a planned feature to reduce nuisance tags. Using a
new field Ignore-Unrelated-Tags, the test can discard any annoying
tags such as 'package-has-long-file-name' or, until recently, the
ubiquitious 'debian-watch-does-not-check-gpg-signature'. (It was
marked experimental.)
The test that checked this feature, 'runtests-empty-test-against',
will be discarded in the very near future.
-
f4e984cc
by Felix Lechner
at 2019-02-07T15:46:09Z
Discard 'runtests-empty-test-against' for obsolete feature.
The test was for a feature that is not obsolete. Test-Against no
longer restricts the tags that may not appear in the output. It has no
further implied bearing on the relationship between the calculated
Test-For and the expected tags. Discards the test.
Gbp-Dch: ignore
-
42e6bfaf
by Felix Lechner
at 2019-02-07T15:46:09Z
Separate tests that track historical packaging; no truth value.
The two tests 'generic-dh-make-2005' and 'generic-dh-make-2008' exist
to track the performance of these historical file sets vis-a-vis the
latest version of Lintian. They come with specific instructions to
update the tags whenever necessary. Because of that, they do not have
much truth value. They should especially not count in calculations for
test coverage. Separates them from the other tests.
The fields Check and Test-Against in the specifications for these
tests are meaningless. They are removed.
Gbp-Dch: ignore
-
cb5f9e7f
by Felix Lechner
at 2019-02-07T15:46:09Z
In tests for output and command line, remove check association.
These tests do not test tags. They test other features based on the
Lintian command line and the expected output. The association with tag
tests is not appropriate. Removes the fields Check and Test-Against.
These tests will probably moved elsewhere in the future.
Gbp-Dch: ignore
-
90451963
by Felix Lechner
at 2019-02-07T15:46:09Z
Duplicate test legacy-relations for seven different checks.
The test legacy-relations was associated with seven different checks.
Splits the test into seven different version that are suitable for
placement in t/tags/checks/. Moves the tests there.
Gbp-Dch: ignore
-
d4f6823b
by Felix Lechner
at 2019-02-07T15:46:09Z
Split up two tests for four checks each, and move them.
The tests that were each exactly associated with four checks each were
split and a copy was moved to each check. The following tests were
affected:
t/tags/tests/spelling-general/
t/tags/tests/debhelper-compat-old/
The fields for Test-Against were likewise split such that the tags
mentioned there belong only to the check with which that copy of the
test is associated.
Gbp-Dch: ignore
-
9be6d42d
by Felix Lechner
at 2019-02-07T15:46:09Z
Split up two tests for eight checks each, and move them.
The tests that were each exactly associated with eight checks each
were split and a copy was moved to each check. The following tests
were affected:
t/tags/tests/generic-empty/
t/tags/tests/legacy-fields/
The fields for Test-Against were likewise split such that the tags
mentioned there belong only to the check with which that copy of the
test is associated.
Gbp-Dch: ignore
-
43d45388
by Felix Lechner
at 2019-02-07T15:46:09Z
Split up two tests for ten checks each, and move them.
The tests that were each exactly associated with ten checks each were
split and a copy was moved to each check. The following tests were
affected:
t/tags/tests/legacy-etcfiles/
t/tags/tests/legacy-debug/
The fields for Test-Against were likewise split such that the tags
mentioned there belong only to the check with which that copy of the
test is associated.
Gbp-Dch: ignore
-
14e8657a
by Felix Lechner
at 2019-02-07T15:46:09Z
Split up two tests for eleven checks each, and move the copies.
The tests that were each exactly associated with eleven checks each
were split and a copy was moved to each check. The following tests
were affected:
t/tags/tests/legacy-foo++/
t/tags/tests/legacy-debconf/
The fields for Test-Against were likewise split such that the tags
mentioned there belong only to the check with which that copy of the
test is associated.
Gbp-Dch: ignore
-
4b2db992
by Felix Lechner
at 2019-02-07T15:46:09Z
Split up two tests for fourteen checks each, and move them.
The tests that were each exactly associated with fourteen checks each
were split and a copy was moved to each check. The following tests
were affected:
t/tags/tests/legacy-filenames/
t/tags/tests/legacy-maintainer-scripts/
The fields for Test-Against were likewise split such that the tags
mentioned there belong only to the check with which that copy of the
test is associated.
Gbp-Dch: ignore
-
bc6f36fb
by Felix Lechner
at 2019-02-07T15:46:09Z
Split up two tests for fifteen checks each, and move them.
The tests that were each exactly associated with fifteen checks each
were split and a copy was moved to each check. The following tests
were affected:
t/tags/tests/legacy-scripts/
t/tags/tests/legacy-libbaz/
The fields for Test-Against were likewise split such that the tags
mentioned there belong only to the check with which that copy of the
test is associated.
Gbp-Dch: ignore
-
bf8d5c7b
by Felix Lechner
at 2019-02-07T15:46:09Z
Add internal test to detect duplicate fields in test specifications.
Apparently, some tests have duplicate fields in their specifications.
Adds an internal harness test looking for duplicate fields in 'desc'.
Gbp-Dch: ignore
-
2ed2d5ac
by Felix Lechner
at 2019-02-07T15:46:09Z
Combine duplicate Test-Against fields in two tests.
Two tests have duplicate declarations for Test-Against. The fields
were combined.
The following two tests were affected:
t/tags/tests/legacy-binary/
t/tags/checks/changelog-file/changelog-file-epoch-change-without-comment-same/
Gbp-Dch: ignore
-
20447e67
by Felix Lechner
at 2019-02-07T15:46:09Z
Add missing check to test 'legacy-binary'.
An internal test detected a duplicate field for Test-Against. The
combined field set off another internal test: One of the tags in
Test-Against (control-file-is-empty) did not belong to any of the
checks mentioned in Check. Adds the missing check (control-files).
Gbp-Dch: ignore
-
6d3466d5
by Felix Lechner
at 2019-02-07T15:46:09Z
Split up test 'legacy-binary' for twenty checks, and move the copies.
One tests was associated with exactly twenty checks. It was split
and a copy was moved to each check. The following test was affected:
t/tags/tests/legacy-binary/
The fields for Test-Against were likewise split such that the tags
mentioned there belong only to the check with which that copy of the
test is associated.
Gbp-Dch: ignore
-
7b96feb6
by Felix Lechner
at 2019-02-07T15:46:10Z
Split up six tests for three checks each, and move them.
The tests that were each exactly associated with fourteen checks each
were split and a copy was moved to each check. The following tests
were affected:
t/tags/tests/control-file-rules-requires-root-no/
t/tags/tests/binaries-multiarch/
t/tags/tests/control-file-rules-requires-root-binary-targets/
t/tags/tests/binaries-missing-lfs/
t/tags/tests/changelog-file-stable/
t/tags/tests/cruft-general-wig-pen/
The fields for Test-Against were likewise split such that the tags
mentioned there belong only to the check with which that copy of the
test is associated.
Gbp-Dch: ignore
-
c013a5d5
by Felix Lechner
at 2019-02-07T15:46:10Z
Split up sixty tests for two checks each, and move them.
Sixty tests that were each exactly associated with two checks each
were split and a copy was moved to each check.
The fields for Test-Against were likewise split such that the tags
mentioned there belong only to the check with which that copy of the
test is associated.
Gbp-Dch: ignore
-
32d0d85e
by Felix Lechner
at 2019-02-07T15:46:10Z
Associate a test with check for debhelper.
The test debhelper-compat-virtual-relation-both is not associated with
any checks. It does not emit any tags. Based on test name, the
description in desc and other contents, the test was associated with
the check 'debhelper'.
Gbp-Dch: ignore
-
f2852b84
by Felix Lechner
at 2019-02-07T15:46:10Z
Associate test 'fields-depends-wildcard' with two checks.
The test fields-depends-wildcard is not associated with any checks. It
does not emit any tags. Based on test name, the description in desc
and other contents, the test was associated with the checks 'fields'
and 'control-file'.
The test was duplicated for each destination.
Gbp-Dch: ignore