[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#920878: lintian: please check for missing Build-Depends: qt5-qmake:native when using lrelease



Hi Helmut!

On Thu, Feb 07, 2019 at 06:19:16AM +0100, Helmut Grohne wrote:
> I've seen packages that call lrelease directly from debian/rules. I'm
> not sure how you use lrelease without qmake though. When qmake is
> missing, lrelease prints
>
>     WARNING: Could not find qmake configuration file linux-g++.
>     lrelease error: cannot process project file '$PROJECT.pro'.
>
> and exits successfully without having done the work it was tasked to do.
> Given that it fails silently (in violation of policy 4.6), I cannot
> easily detect them.
>
> So I agree that you can run lrelease outside qmake, but that doesn't
> mean that it actually works or does anything useful in the absence of
> qmake.

Thanks for the explanation! Now I remember that lrelease has two modes.
Quoting from its manpage:

SYNOPSIS
       lrelease [ options ] project-file
       lrelease [ options ] ts-files [ -qm qm-file ]

When you call it with a project file (*.pro), it really needs qmake to
process that file (in Qt 5.11).

However, in the upcoming Qt 5.13 release, the first mode of lrelease is
deprecated [1] and the new tool lrelease-pro is introduced.

So if we want a future-proof solution, only packages that are using
lrelease-pro or ‘lrelease *.pro’ or ‘lrelease -project *.pro’ should have
a build-dependency on qt5-qmake:native. Packages which are using
‘lrelease *.ts’ do not need qmake.

Maybe when we package Qt 5.13, I can split lrelease-pro into a separate
package that will depend on qt5-qmake.

[1]: https://codereview.qt-project.org/234756

> > Do you have a list of packages where adding qt5-qmake:native will actually
> > make them cross-buildable?
>
> #889752 #896699 #901212 #920850

Thanks for the references! There are not many of them, and only one is open,
so maybe we can delay this bug until Bullseye (when we package Qt 5.13)?

Attachment: signature.asc
Description: PGP signature


Reply to: