-
3b6cfd3d
by Felix Lechner
at 2019-02-06T21:26:12Z
Move all t/tags/tests addressing a single check into t/tags/checks/. (MR: !141)
To disentangle the test directories in t/tags/tests, moves all test
dealing with a single check into t/tags/check. Moves 511 tests to new
locations.
The remaining 174 tests fall into one of these categories:
1. They test more than one Lintian check.
2. They test no checks, but only output (e.g. generic-dh-make-2005).
3. They belong to the old suites debs, changes or source.
Test for more than one Lintian check will be split, if possible.
Test for output unrelated to single checks may be resorted in other
meaningful ways. Some, such as basic-quilt, may be deleted. Other,
such as generic-dh-make-2005, should remain. One option is a separate
suite called output.
Tests could be sorted now but require more work. Many of them generate
files in Makefiles, which should be devolved. They also lack in
parameterization. Leaving the tests where they are just makes them
easier to find. They will be moved later manually.
Also, tests for a false positive that did not originally specify a
Test-Against but which tested positive for tags from only one
unrelated check ended up in a wrong location. Perhaps most glaringly,
binaries-unsafe-open is in t/tags/checks/manpages. These will likewise
be taken care of later.
-
5d91d5b7
by Felix Lechner
at 2019-02-06T21:26:20Z
Add internal harness test enforcing sort order for tests.
Enforces that all children of t/tags/checks correspond to valid
Lintian checks. Furtermore, any tests located in such a subfolder must
relate to that Lintian check (and only that check).
Gbp-Dch: ignore
-
8703afe3
by Felix Lechner
at 2019-02-06T21:26:20Z
Small enhancements to desc-fields.t; better output.
Add test names in ok() statements for better test output. Also, move
'lib' declaration to make sure latest modules are used.
Gbp-Dch: ignore
-
9f7746ad
by Felix Lechner
at 2019-02-06T21:26:56Z
Reassign watch-file-bug-765995 to check watch-file from changes-file.
The original test specification had
Test-For: orig-tarball-missing-upstream-signature
so the test was erroneously assigned to the check changes-file.
Reassigning to watch-file.
Also, the bug report does not list a tag, but rather a Perl error
message. Remove Tag-Against. Configures this as a test against false
positives for any tags in check watch-file.
Gbp-Dch: ignore
-
7758a2f8
by Felix Lechner
at 2019-02-06T21:27:00Z
Reassign binaries-unsafe-open to check binaries from manpages.
The original test specification had
Test-For: empty-manual-page
so the test was erroneously assigned to the check manpages.
Reassigning to binaries.
Also, remove Tag-Against. Configures this as a test against false
positives for any tags in check binaries, which includes the hardening
features the test was probably designed for.
Gbp-Dch: ignore
-
d8d44a07
by Felix Lechner
at 2019-02-06T21:27:03Z
Move runtests-empty-test-against to t/tags/tests; not check-related.
Tests a feature of the test runner whereby Test-Against cannot be
empty while 'tags' is also empty. (Actually, not even the subset of
'tags' belonging to Check may be empty.) This test is not tag-related
in the usual sense. Moving back to t/tags/tests for further
evaluation.
The test needs a check, so 'manpages' cannot be removed. This test
will probably be transformed into script that checks this feature of
the runner via mocking.
Gbp-Dch: ignore
-
e9fda64c
by Felix Lechner
at 2019-02-06T21:27:03Z
Move lintian-ftp-rejects to t/tags/tests; is for command line option.
Tests a command-line feature of Lintian and is not tag-related. Moving
back to t/tags/tests for further evaluation.
Also removing Check and empty Test-Against.
Gbp-Dch: ignore
-
97f7b4d0
by Felix Lechner
at 2019-02-06T21:27:05Z
Move lintian-no-override to t/tags/tests; is for command line option.
Tests a command-line option of Lintian and is not tag-related. Moving
back to t/tags/tests for further evaluation.
Also, removing Check and empty Test-Against.
Gbp-Dch: ignore
-
10169fa3
by Felix Lechner
at 2019-02-06T21:27:08Z
Tighten requirements for Test-Against vs expected tags.
The requirement that Test-Against may not be empty when 'tags' is
empty can be tightened. There could actually be tags present as long
as they do not belong to Check. In other words, the calculated
Test-For and the overridden Test-Against may not both be empty.
The behavior is being tested in runtests-empty-test-against from
commit ec81e0c9. We are not adding other valid tags to the test
because it is marked TODO. It would be too difficult to verify if the
test fails because a tag disappeared or because the calculation went
awry. The current situation is not perfect but more desirable.
Gbp-Dch: ignore