[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#917567: maintainer-script-should-not-use-dpkg-maintscript-helper matched valid calls



retitle 917567 maintainer-script-should-not-use-dpkg-maintscript-helper
matched valid calls
found 917567 2.5.121
reopen 917567
thanks

On 11.01.19 17:59, Chris Lamb wrote:
> Hi Sven,
> 
>> While routinely checking the bacula sources
>> https://salsa.debian.org/bacula-team/bacula with the new lintian, I now
>> get a warning for *every* (post|pre)(inst|rm) script containing a call
>> to dpkg-maintscript-helper.
> 
> So I just checked a bacula_9.4.1-2_amd64.changes that I built
> myself and do not see this. Can you clarify exactly what sources
> you are running this on, which version of Lintian, which flags,
> etc. etc. Usual things.
> 
> If you can still reproduce, please reopen and retitle.

I am using Lintian v2.5.121 on Sid.

Building from the current GIT master of Bacula via "gbp buildpackage" in
a clean Sid cowbuilder chroot.

lintian command-line is:
lintian --color always -EvIL +pedantic --profile debian/main --info
bacula_9.4.1-3_amd64.changes

The output is attached.

It for example matches on debian-common-pgsql postinst4:

#!/bin/sh
set -e
# Automatically added by dh_installdeb/12
dpkg-maintscript-helper dir_to_symlink
/usr/share/doc/bacula-common-pgsql bacula-common 7.0.5\+dfsg-4\~ -- "$@"
# End automatically added section

But this line was not added manually but by dh_installdeb instead via
bacula-common-pgsql.maintscript, as one is supposed to do this.

Grüße,
Sven.


N: Using profile debian/main.
N: Setting up lab in /tmp/user/1000/temp-lintian-lab-nRpN7FlqpB ...
N: Starting on group bacula/9.4.1-3
N: Unpacking packages in group bacula/9.4.1-3
N: ----
N: Processing changes file bacula (version 9.4.1-3, arch source amd64 all) ...
N: ----
N: Processing source package bacula (version 9.4.1-3, arch source) ...
W: bacula source: changelog-should-mention-nmu
N: 
N:    When you NMU a package, that fact should be mentioned on the first line
N:    in the changelog entry. Use the words "NMU" or "Non-maintainer upload"
N:    (case insensitive).
N:    
N:    Maybe you didn't intend this upload to be a NMU, in that case, please
N:    double-check that the most recent entry in the changelog is
N:    byte-for-byte identical to the maintainer or one of the uploaders. If
N:    this is a local package (not intended for Debian), you can suppress this
N:    warning by putting "local" in the version number or "local package" on
N:    the first line of the changelog entry.
N:    
N:    Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/
N:    queue) for details.
N:    
N:    Severity: normal, Certainty: certain
N:    
N:    Check: nmu, Type: source
N: 
W: bacula source: source-nmu-has-incorrect-version-number 9.4.1-3
N: 
N:    A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a
N:    native package). This is to prevent stealing version numbers from the
N:    maintainer.
N:    
N:    Maybe you didn't intend this upload to be a NMU, in that case, please
N:    double-check that the most recent entry in the changelog is
N:    byte-for-byte identical to the maintainer or one of the uploaders. If
N:    this is a local package (not intended for Debian), you can suppress this
N:    warning by putting "local" in the version number or "local package" on
N:    the first line of the changelog entry.
N:    
N:    Refer to Debian Developer's Reference section 5.11.2 (NMUs and
N:    debian/changelog) for details.
N:    
N:    Severity: normal, Certainty: certain
N:    
N:    Check: nmu, Type: source
N: 
P: bacula source: no-dep5-copyright
N: 
N:    This package does not use a machine-readable debian/copyright file.
N:    
N:    This format makes it easier to review licenses and can be easily parsed
N:    by Lintian.
N:    
N:    Refer to
N:    https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N:    details.
N:    
N:    Severity: pedantic, Certainty: certain
N:    
N:    Check: source-copyright, Type: source
N: 
X: bacula source: maybe-not-arch-all-binnmuable bacula-director -> bacula-director-pgsql
N: 
N:    Tag to attempt to measure the number of packages that might have an
N:    issue with arch:all binNMUs.
N:    
N:    At this time, please do <not> attempt to "fix" the problem. It is not
N:    clear what the solution is (if any at all), nor is it clear that this is
N:    something that will or should be supported.
N:    
N:    Severity: pedantic, Certainty: wild-guess
N:    
N:    Check: version-substvars, Type: source
N:    
N:    This tag is marked experimental, which means that the code that
N:    generates it is not as well-tested as the rest of Lintian and might
N:    still give surprising results. Feel free to ignore experimental tags
N:    that do not seem to make sense, though of course bug reports are always
N:    welcome.
N: 
N: ----
N: Processing binary package bacula-sd (version 9.4.1-3, arch amd64) ...
W: bacula-sd: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:41
N: 
N:    The maintainer script seems to make manual calls to the
N:    dpkg-maintscript-helper(1) utility.
N:    
N:    Please use package.maintscript files instead; the dh_installdeb(1) tool
N:    will do some basic validation of some of the commands listed in this
N:    file to catch common mistakes.
N:    
N:    Refer to the dpkg-maintscript-helper(1) manual page and the
N:    dh_installdeb(1) manual page for details.
N:    
N:    Severity: minor, Certainty: certain
N:    
N:    Check: scripts, Type: binary
N: 
W: bacula-sd: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:42
W: bacula-sd: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:74
W: bacula-sd: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:75
W: bacula-sd: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-sd: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:5
W: bacula-sd: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:14
W: bacula-sd: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:15
X: bacula-sd: systemd-service-file-missing-hardening-features lib/systemd/system/bacula-sd.service
N: 
N:    The specified systemd .service file does not appear to enable any
N:    hardening options.
N:    
N:    systemd has support for many security-oriented features such as
N:    isolating services from the network, private /tmp directories, as well
N:    as control over making directories appear read-only or even
N:    inaccessible, etc.
N:    
N:    Please consider supporting some options, collaborating upstream where
N:    necessary about any potential changes.
N:    
N:    Refer to the systemd.service(5) manual page and
N:    http://0pointer.de/blog/projects/security.html for details.
N:    
N:    Severity: pedantic, Certainty: wild-guess
N:    
N:    Check: systemd, Type: binary
N:    
N:    This tag is marked experimental, which means that the code that
N:    generates it is not as well-tested as the rest of Lintian and might
N:    still give surprising results. Feel free to ignore experimental tags
N:    that do not seem to make sense, though of course bug reports are always
N:    welcome.
N: 
N: ----
N: Processing binary package bacula-fd (version 9.4.1-3, arch amd64) ...
W: bacula-fd: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:35
W: bacula-fd: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:74
W: bacula-fd: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-fd: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:14
X: bacula-fd: systemd-service-file-missing-hardening-features lib/systemd/system/bacula-fd.service
N: ----
N: Processing binary package bacula-common-mysql-dbgsym (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-bscan (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-fd-dbgsym (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-sd-dbgsym (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-console-qt (version 9.4.1-3, arch amd64) ...
W: bacula-console-qt: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:34
W: bacula-console-qt: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:69
W: bacula-console-qt: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-console-qt: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:4
N: ----
N: Processing binary package bacula-tray-monitor (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula (version 9.4.1-3, arch all) ...
N: ----
N: Processing binary package bacula-client (version 9.4.1-3, arch all) ...
N: ----
N: Processing binary package bacula-director (version 9.4.1-3, arch amd64) ...
X: bacula-director: systemd-service-file-missing-hardening-features lib/systemd/system/bacula-director.service
N: ----
N: Processing binary package bacula-common-sqlite3 (version 9.4.1-3, arch amd64) ...
W: bacula-common-sqlite3: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:4
W: bacula-common-sqlite3: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:4
W: bacula-common-sqlite3: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-common-sqlite3: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:4
N: ----
N: Processing binary package bacula-server (version 9.4.1-3, arch all) ...
N: ----
N: Processing binary package bacula-tray-monitor-dbgsym (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-director-mysql (version 9.4.1-3, arch all) ...
W: bacula-director-mysql: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:46
W: bacula-director-mysql: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:21
W: bacula-director-mysql: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-director-mysql: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:20
N: ----
N: Processing binary package bacula-director-pgsql (version 9.4.1-3, arch all) ...
W: bacula-director-pgsql: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:46
W: bacula-director-pgsql: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:21
W: bacula-director-pgsql: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-director-pgsql: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:20
N: ----
N: Processing binary package bacula-common-sqlite3-dbgsym (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-common-mysql (version 9.4.1-3, arch amd64) ...
W: bacula-common-mysql: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:4
W: bacula-common-mysql: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:4
W: bacula-common-mysql: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-common-mysql: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:4
N: ----
N: Processing binary package bacula-common (version 9.4.1-3, arch amd64) ...
X: bacula-common: duplicate-files usr/share/doc/bacula-common/examples/devices/DDS.conf usr/share/doc/bacula-common/examples/devices/Sony-DDS.conf
N: 
N:    The package ships the two (or more) files with the exact same contents.
N:    
N:    Note: empty files are exempt from this check.
N:    
N:    Severity: pedantic, Certainty: possible
N:    
N:    Check: duplicate-files, Type: binary
N:    
N:    This tag is marked experimental, which means that the code that
N:    generates it is not as well-tested as the rest of Lintian and might
N:    still give surprising results. Feel free to ignore experimental tags
N:    that do not seem to make sense, though of course bug reports are always
N:    welcome.
N: 
W: bacula-common: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:44
W: bacula-common: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:20
W: bacula-common: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:29
W: bacula-common: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:4
N: ----
N: Processing binary package bacula-console-qt-dbgsym (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-console (version 9.4.1-3, arch amd64) ...
W: bacula-console: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:39
W: bacula-console: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:69
W: bacula-console: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-console: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:4
N: ----
N: Processing binary package bacula-director-common (version 9.4.1-3, arch all) ...
W: bacula-director-common: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:4
W: bacula-director-common: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:4
W: bacula-director-common: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-director-common: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:4
N: ----
N: Processing binary package bacula-director-dbgsym (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-director-sqlite3 (version 9.4.1-3, arch all) ...
W: bacula-director-sqlite3: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:46
W: bacula-director-sqlite3: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:21
W: bacula-director-sqlite3: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-director-sqlite3: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:20
N: ----
N: Processing binary package bacula-common-pgsql-dbgsym (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-bscan-dbgsym (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-common-dbgsym (version 9.4.1-3, arch amd64) ...
N: ----
N: Processing binary package bacula-common-pgsql (version 9.4.1-3, arch amd64) ...
W: bacula-common-pgsql: maintainer-script-should-not-use-dpkg-maintscript-helper postinst:4
W: bacula-common-pgsql: maintainer-script-should-not-use-dpkg-maintscript-helper postrm:4
W: bacula-common-pgsql: maintainer-script-should-not-use-dpkg-maintscript-helper preinst:4
W: bacula-common-pgsql: maintainer-script-should-not-use-dpkg-maintscript-helper prerm:4
N: ----
N: Processing binary package bacula-console-dbgsym (version 9.4.1-3, arch amd64) ...
N: Finished processing group bacula/9.4.1-3
N: 43 tags overridden (1 error, 8 warnings, 34 info)

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: