Bug#918817: lintian: Returns with exit code of 0 (zero) on failed tests

[Chris Lamb <lamby@debian.org>]

Package: lintian
Version: 2.5.119
Severity: serious
X-Debbugs-CC: Felix Lechner <felix.lechner@lease-up.com>

Hi Felix,

It appears like one of your recent changes has meant that a failing
test does not return an non-zero error code. For example:

    $ debian/rules runtests onlyrun=01-critic
    t/scripts/01-critic/commands.t ........ ok                              
    t/scripts/01-critic/checks.t .......... 33/? #   Failed test 'Test::Perl::Critic for "checks/scripts.pm"'
    #   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
    # 
    #   checks/scripts.pm:93:25:Long number not separated with underscores
    t/scripts/01-critic/checks.t .......... Dubious, test returned 1 (wstat 256, 0x100)
    Failed 1/58 subtests 

    Test Summary Report
    -------------------
    t/scripts/01-critic/checks.t        (Wstat: 256 Tests: 58 Failed: 1)
      Failed test:  39
      Non-zero exit status: 1
    Files=13, Tests=267, 19 wallclock secs ( 0.12 usr  0.04 sys + 128.27 cusr  3.38 csys = 131.81 CPU)
    Result: FAIL

    $ echo $?
    0

(Marking as RC as we should not release with this issue pending.)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-